speckleworks / grevit Goto Github PK

Revit Create Extensions need a cleanup, there is a lot of undocumented code.

• document code
• remove old comments
• cleanup variable names

Seems to missing from the ui, eh?

🤗

Right now, what works is:

• slabs
• walls (partially - some arc-based things get confused)
• shafts
• adaptive families
• columns
• grids
• levels

There's now some minor interfaces that hint at trying to work with multiple different integrations, albeit I want to understand better if we can have a single ui serving streams containing multiple object models (ie, grevit, ggIFC, etc.) and centralise the whole updating logic within speckle.

Just to flex the mechanics a bit, ie demonstrate the flow:

1. User creates grevit obj in gh
2. Plugs them in a speckle sender
3. Get them out (programatically) in Revit via SpeckleCore, then deserialise back to native Grevit obj via SpeckleConverter

The rest is thereafter up to existing Grevit magic... In theory 🤞

@didimitrie sorry, still cannot branch - did you give me permissions for this repo or only in the team?

The Revit search location for families is hardcoded and points to a location that doesn't need to exist this way:
https://github.com/speckleworks/Grevit/blob/master/Grevit.Revit/Revit.cs#L208
Pull library location from LibraryPaths property instead.

Mostly because we don't have the resources to test on all.

While the revit bake operation is happening, pass back progress info to the user interface and display it somehow (progress bar, or message; per stream or global?).

so as to be able to reinitialise them later on.

@didimitrie you mentioned adding new components which are easier to handle. I'd vote for keeping the existing ones as well so we won't break existing definitions. Users could upgrade their definitions by simply replacing the Send component with a new one. Additionally we can provide new components for new definitions. What do you think?
If we keep the old ones, what input would you need on the Speckle side? Could we feed in the Grevit element + the Rhino mesh?

• Cleanup and define entry point for creating a Revit model