sparkfun / sik-guide-code Goto Github PK

In experiment #14, SIK_circuit14_shiftRegister, line 89 is missing an open bracket at the end of the line. Should read

void shiftWrite(int desiredPin, boolean desiredState){

THanks!

Rob Reynolds

Dear SparkFun,

First I want to thank you for your work, and your contribution to the maker community. You products are great and this KIT is again a perfect example.

Nevertheless, I found a misleading typo in the comment of the DistanceSensor .ino file.

float getDistance()
{
  float echoTime;                   //variable to store the time it takes for a ping to bounce off an object
  float calculatedDistance;         //variable to store the distance calculated from the echo time

  //send out an ultrasonic pulse that's 10ms long
  digitalWrite(trigPin, HIGH);
  delayMicroseconds(10);
  ...

The call delayMicroseconds(10) delay for 10 microseconds, however the comment says: "an ultrasonic pulse that's 10ms long"
it should be "10us", nothing bad, but it maybe misleading for non-physicists.

Thank you again, and I wish you a nice day,

Yori

Pin assignments for echoPin and trigPin (code lines 14-15) are inconsistent with the wiring diagram in the hookup guides, both printed and online. To match code for experiment 3C, code should read

const int trigPin = 11;           //connects to the trigger pin on the distance sensor 
const int echoPin = 12;           //connects to the echo pin on the distance sensor   

Thanks!

Hi,

I am just getting back into the coding game after a long absence, but looking at the code description for shiftWrite and referring to the datasheet for the HC595 I think the latching description below is incorrect - by my understanding of the datasheet, the latch actually activates on the low-to-high transition rather than the high-to-low. Am I correct?

// Once the data is in the shift register, we still need to
// make it appear at the outputs. We'll toggle the state of
// the latchPin, which will signal the shift register to "latch"
// the data to the outputs. (Latch activates on the high-to
// -low transition).

Thank you for your time.
Rowley

PR #18 made some changes in this area but didn't quite go far enough. The value assigned to index by the assignment and the pre-increment operators in the various for-loops should rationally be the same. However, two identical side effects occurring on the same 'object' is, at best, redundant or, in truth, incorrect. For reference, see:

• C99 § 6.5 Expressions
• C++11 § 1.9 Program execution
• C++ Super-FAQ § Miscellaneous Technical Issues
• comp.lang.c FAQ § 3. Expressions

Dear SparkFun,

In the tutorial DistanceSensor the pin are defined for the first time as const int, instead of int. I think it is a great opportunity to introduce constants.

However I found that such values like pin ID may not need a variable and I believe can be solved via a MACRO definition since the latter do not require memory space.

As a results I could imagine introducing const int in the second project and #define XXX_PIN YY in the third project. The advantage being a smooth learning curve and introducing the challenges of memory management in embedded systems.

Thank you for your work, and your contributions to the open hardware community,

I wish you a nice day,

Yori

The guide suggest to install the examples in the Arduino IDE by dragging the SIK-Guide-Code-master folder into Contents/Resources/Java. Unfortunately, the folder doesn't not exist. I tried different paths:

1. I created the Contents/Resources/Java manually and drag the folder and it does not seem to work.
2. I also tried to drag the folder into Contents/Java and Contents/Java/libraries and still not working.
3. Also tried to install int as a .ZIP library.

It seems the right way to install examples is through the Install Libraries option from the IDE menu, but the zip file from GitHub is missing the library definition files, so it is not recognized as such.

Suggestions?

SIK-Guide-Code/SIK_circuit14_shiftRegister/SIK_circuit14_shiftRegister.ino
line 90

I was briefly looking through the "edu_rework" branched repository and noticed a misspelled word. "Therimin" should be spelled "Theremin" here => https://github.com/sparkfun/SIK-Guide-Code/tree/edu_rework/Project13_Therimin .

Is that what was meant?