spacetelescope / jwreftools Goto Github PK

Tyler Desjardins mentions that we should consider moving emails from help[at]stsci.edu to point to the web portal where possible and appropriate. For HST (or any non-JWST), it is https://hsthelp.stsci.edu . For JWST, it is https://jwsthelp.stsci.edu . Please update info in setup.py, setup.cfg, documentation, etc as appropriate.

Please close this issue if it is irrelevant to your repository. This is an automated issue. If this is opened in error, please let pllim know!

xref spacetelescope/hstcal#317

The pipeline expects the output of the transforms to V2V3 to be in units of arcsec. The output of the NIRSPEC transform (in V2, V3) is in deg. Append a scaling transform to convert to arcsec to the ote file.

This is a ticket to keep track of work related to NIRSPEC reference files for build 6.

• Create an IFU slicer file. Requires a new reference type in CRDS
• Add the IFU decription to the msa reference file
• Create the IFU-POST reference files - new CRDS reference type
  The files were created but the ESA team has indicated that the chromatic distortion delivered with the files should not be used. The ifupost2asdf function needs to be modified and the files created again.
• Create an IFU fore reference file
• Create an IFU_OUTSIDE reference file - new CRDS reference file
  The ESA team has indicated this is not to be used
• Create a Collimator_IFU reference file - need change of CRDS rmap
  The ESA team has indicated this is not to be used
• Create a disperser file for the prism
• Test the reference files
• Deliver to CRDS

Python 2 will not be maintained past Jan 1, 2020 (see https://pythonclock.org/). Please remove all Python 2 compatibility and move this package to Python 3 only.

For conda recipe (including astroconda-contrib), please include the following to prevent packaging it for Python 2 (https://conda.io/docs/user-guide/tasks/build-packages/define-metadata.html?preprocessing-selectors#skipping-builds):

build: 
  skip: true  # [py2k] 

Please close this issue if it is irrelevant to your repository. This is an automated issue. If this is opened in error, please let pllim know!

jwst_nirspec_wavelengthrange_0004.asdf has extra spaces in the value of meta.exposure.p_exptype. Simple demonstration:

import asdf
import crds
keys = {'INSTRUME': 'NIRSPEC', 'EXP_TYPE': 'NRS_BRIGHTOBJ', 'DATE-OBS': '2021-03-30', 'TIME-OBS': '00:00:00'}
refs = crds.getreferences(keys, reftypes=['wavelengthrange'])
content = asdf.open(refs['wavelengthrange'])
p_exptype = content['meta']['exposure']['p_exptype']
print(p_exptype)

yields

NRS_TACQ|NRS_TASLIT|NRS_TACONFIRM|    NRS_CONFIRM|NRS_FIXEDSLIT|NRS_IFU|NRS_MSASPEC|NRS_IMAGE|NRS_FOCUS|    NRS_MIMF|NRS_BOTA|NRS_LAMP|NRS_BRIGHTOBJ|

Note the four extra spaces in front of NRS_CONFIRM and NRS_MIMF, both of which occur at the start of a continuation line in wave_range2asdf.py.

In conversation with @jaytmiller, he mentioned @philhodge has code for helping to convert or create SFlat, DFlat, and FFlat reference files. This code should be added to this repository.

The units of all angles in the IDT ref files are described in various parts of the ICD document.
The unit of QUAD_ROT is wrong in the build 6 reference files. Need to double check all of them.

This issue keeps track of MIRI reference files work for build 6.

• Create CDP-5 MRS reference files
• Check if there's new reference data for the MIRI Imager delivered with CDP-5
• Check if there's new reference data for the MIRI LRS delivered with CDP-5
• Test the reference files
• Deliver to CRDS

• Create a reference file for FGS imaging mode
• Test the file
• Deliver to CRDS