spacetalk / spacetalk Goto Github PK

Instead of the current emoji library we should pick this one I think. I like the visual graphics of the icons more.

http://emojione.com/demo

What do you guys think?

https://github.com/SpaceTalk/SpaceTalk/blob/develop/server/methods/channels/remove.js#L3-L6

tinyscrollbar used to display per element scrollbar is not working

On the left sidebar. I'm going to wrap the left sidebar with {{#if currentTeam}} so that it doesn't show.

I've noticed a few different versions of the event variable already:

We've got:

function (e) { ... }

function (event) {...}

function (event, template) { ... } // admittedly me, and probably not common or necessary

The Meteor Style Guide doesn't give a preference here, but it should be consistent.

Because iron:router is starting to lose the hearts of the meteor developers because it's not being maintained frequently enough we're thinking of using flow:router as our routing option

Let's use this:
https://github.com/raix/Meteor-jshintrc/blob/master/.editorconfig

As well as this:
https://github.com/raix/Meteor-jshintrc/blob/master/.jshintrc

As a user, i want to display the channel info by clicking info icon in the header

After starting up the app encountered with the following error

[[[[[ C:\Users\dmitrijsbalcers\Documents\GitHub\SpaceTalk ]]]]]

=> Started proxy.
=> Started MongoDB.
=> Errors prevented startup:

   While checking for fourseven:[email protected]:
   error: No compatible binary build found for this package. Contact the
   package author and ask them to publish it for your platform.

=> Your application has errors. Waiting for file change.

The version of the package should be changed to the 3.1.1. At the moment, I cannot apply the fix due to an issue described here - #28

As a user
I want to be able to delete a channel
so that it doesn't exist anymore.

Spec:

• Any user can delete any channel
• Warning should appear before deleting a channel
• All messages associated with a channel get deleted as well.

Trello Card

This is causing it to go to the /teams/public page all the time.

There I said it. @dstollie @timbrandin you with me on this? We should really get this on point right?

see: https://trello.com/c/PpJKQcCy

decided to go with iframely

They current homepage doesnt look that attracting as it should be.. Let's make it somehwat nicer

Working on users' online status && listing them in the sidebar

we need some sort of generic way of forcing people to code in the right style.. I say implementing editorconfig. What do you guys say?

# EditorConfig helps developers define and maintain consistent
# coding styles between different editors and IDEs
# editorconfig.org

root = true


[*]

# Change these settings to your own preference
indent_style = space
indent_size = 2

# We recommend you to keep these unchanged
end_of_line = lf
charset = utf-8
trim_trailing_whitespace = true
insert_final_newline = true

[*.md]
trim_trailing_whitespace = false

As discussed on https://trello.com/c/q2cx1oYh. We would want bootstrap support for SpaceTalk.

Ill start of making some simple test for the most basic functionalitities in SpaceTalk using jasmine

https://github.com/SpaceTalk/SpaceTalk/blob/develop/client/views/channel-info/channel-info.html#L10

Is there a way to not use checkboxes? I find that sometimes I can't get it to expand unless I click just the right spot. I should be able to click that entire block where the heading is to expand it.

You can insert a channel with the names:

hello world
hello           world
hello                           world

And in the front-end they'll all show up as:

hello world
hello world
hello world

When inserting, we need to do:

channelName.replace(/\s{2,}/g, ' ').toLowerCase().trim();

Trello card: https://trello.com/c/ehJfaysD/65-re-style-sweet-alerts-to-conform-to-space-talk-core-design

To conform to the Meteor style guide (and for future i18n) it is better to generate error messages on the client as per this guide: https://github.com/meteor/meteor/wiki/Meteor-Style-Guide#generate-error-messages-on-the-client-not-on-the-server

Right: In the event of failure, the server returns a symbolic error code, 'no-such-user', 'site-not-found', or 'access-denied'. The client then looks up that error code in a table to get an appropriate message and displays it to the user.

https://trello.com/c/f5vprsnB/73-pin-messages

I think CSS is probably more different between personal developers than any other language; so we could do with some stricter guidelines on custom styling. Especially when it comes to the maintainability of the CSS going forwards.

Any rules are better than no rules to some extent, but I'd suggest we use BEM:

• It's got clearly defined rules
• All rules are on classes so specificity stays under control
• It plays great with SCSS
• Developers could write classes to perform actions without needing to look them up in the CSS.

e.g. We currently have this.

  <aside class="channel-info channel-info-out">
    <span class="title">
      Channel info
      <i data-action="display-channel-info" class="fa fa-times channel-info-exit"></i>
    </span>
    <div class="aside-section channel-accordion">
      <ul class="scroll">
        <li>
          <input type="checkbox" checked>
          <i class="fa fa-caret-down"></i>
          <h2><i class="fa fa-info-circle icon icon-about"></i> About this channel</h2>
          <p>About this channel to be here</p>
        </li>
        <li>
          <input type="checkbox" checked>
          <i class="fa fa-caret-down"></i>
          <h2><i class="fa fa-thumb-tack icon icon-pinned"></i> Pinned items</h2>
          <p>Pinned items content to be here</p>
        </li>
        <li>
          <input type="checkbox" checked>
          <i class="fa fa-caret-down"></i>
          <h2><i class="fa fa-user icon icon-members"></i> Members</h2>
          <p>Members content to be here</p>
        </li>
      </ul>
    </div>
  </aside>

Combined with a lot of styling based on element names, or nested styles. I'll point out some of the potential problem areas.

(I should point out, this is actually a nice pure-CSS solution for the info panel written by @nabiltntn, it's just the naming conventions and scalability that may need addressing).

.channel-info .title {} // .title could be used elsewhere, so this may not do what is expected
.channel-info .channel-accordion ul li {} // I actually tried to add another ul here for other reasons, heavily affected by this CSS

/* we're restricted to using a p element here */
.channel-info .channel-accordion {
 ul li input[type=checkbox]:checked ~ p {
       margin-top: 0;
       max-height: 0;
       opacity: 0;
      transform: translate(0, 50%);
     }
}

In BEM, we'd have something more like this:

  <aside class="channel-info channel-info--out">
    <span class="channel-info__title">
      Channel info
      <i data-action="display-channel-info" class="fa fa-times channel-info-exit"></i>
    </span>
    <div class="channel-info__section channel-accordion">
      <ul class="scroll">
        <li class="channel-accordion__list-item">
          <input type="checkbox" checked>
          <i class="fa fa-caret-down"></i>
          <h2><i class="fa fa-info-circle icon icon-about"></i> About this channel</h2>
          <p class="channel-accordion__list-item-content">About this channel to be here</p>
        </li>
      </ul>
    </div>
  </aside>

and the classes used here make the CSS become markup agnostic.

// Blocks
.channel-info {}
.channel-accordion {}

// elements
.channel-info__title {}
.channel-info__section {}

.channel-accordion__list-item {}
.channel-accordion__list-item-content {}

// modifiers (or 'states')
.channel-info--out {}
.channel-footer--full {}
.channel-content--full {}

Lastly, using a pre-defined method would give us a great reference point to pass on to people trying to skin their own version; add new features; submit changes, etc.

http://docs.meteor.com/#/full/template_currentuser

We're defining it again here.

We need direct message channels that can be created by either of the two users involved and always be the same channel.

When you edit a text message and you want to move the key cursor the textarea gets removed..

@mitar, it would be great if you share with us your opinions/feedback/answer questions about how we've been using Blaze Components.

Contributors, feel free to ask questions and share concerns about the usage of Blaze Components.

Adding fortawesome:fontawesome package for icons.

https://trello.com/c/8OdxVton

see trello: https://trello.com/c/X5kwmhwC for the discusson about it

and when the emoji is the last element in the message, delete and edit icons are misplaced

Adding specific style guide notes to the readme.md that differ (or are not covered) in the meteor style guide, mainly those decided on in the following trello cards;

Style Guide

• https://trello.com/c/zIU1foBN/36-file-naming-conventions
• https://trello.com/c/jadwd30J/33-routing-structure
• https://trello.com/c/4wMBngXF/48-html-id-and-class-naming-conventions-custom-ones
• https://trello.com/c/Lx9kwof2/37-template-naming-conventions

Agreed Libraries

• https://trello.com/c/6Wu3pfsd/34-css-pre-processors
• https://trello.com/c/8OdxVton/63-icons-fonts-or-svg-icons

https://github.com/SpaceTalk/SpaceTalk/blob/fe586b12f9226379f1ab7c9b5b44b0a520f50b6d/server/methods/channels/remove.js

Also are we using methods or minimongo + meteor.allow rules @timbrandin @dstollie .

https://trello.com/c/PbRfcm5M/66-use-methods-or-minimongo-for-writes-or-both-depending-on-use-case

In addition should we use matb33:collection-hooks to be deleting messages when channels are deleted?

I would rather use minimongo to delete it and use meteor.allow rules to first check if this user can delete this channel than checking in the method.

Here's the first revision.

Right after cloning the project into Windows environment, a lot of files are being marked as deleted.

I presume that there might be some conflict in the way, where different environments set up the directory structure?

C:\Users\dmitrijsbalcers\Documents\GitHub\SpaceTalk>git status
On branch develop
Your branch is up-to-date with 'origin/develop'.

Changes to be committed:
  (use "git reset HEAD <file>..." to unstage)

        deleted:    packages/useraccounts:core/.editorconfig
        deleted:    packages/useraccounts:core/.gitignore
        deleted:    packages/useraccounts:core/.jshintignore
        deleted:    packages/useraccounts:core/.jshintrc
        deleted:    packages/useraccounts:core/.travis.yml
        deleted:    packages/useraccounts:core/Guide.md
        deleted:    packages/useraccounts:core/History.md
        deleted:    packages/useraccounts:core/LICENSE.md
        deleted:    packages/useraccounts:core/README.md
        deleted:    packages/useraccounts:core/lib/client.js
        deleted:    packages/useraccounts:core/lib/core.js
        deleted:    packages/useraccounts:core/lib/field.js
        deleted:    packages/useraccounts:core/lib/methods.js
        deleted:    packages/useraccounts:core/lib/server.js
        deleted:    packages/useraccounts:core/lib/templates_helpers/at_error.js
        deleted:    packages/useraccounts:core/lib/templates_helpers/at_form.js
        deleted:    packages/useraccounts:core/lib/templates_helpers/at_input.js
        deleted:    packages/useraccounts:core/lib/templates_helpers/at_message.js
        deleted:    packages/useraccounts:core/lib/templates_helpers/at_nav_button.js
        deleted:    packages/useraccounts:core/lib/templates_helpers/at_oauth.js
        deleted:    packages/useraccounts:core/lib/templates_helpers/at_pwd_form.js
        deleted:    packages/useraccounts:core/lib/templates_helpers/at_pwd_form_btn.js
        deleted:    packages/useraccounts:core/lib/templates_helpers/at_pwd_link.js
        deleted:    packages/useraccounts:core/lib/templates_helpers/at_reCaptcha.js
        deleted:    packages/useraccounts:core/lib/templates_helpers/at_result.js
        deleted:    packages/useraccounts:core/lib/templates_helpers/at_sep.js
        deleted:    packages/useraccounts:core/lib/templates_helpers/at_signin_link.js
        deleted:    packages/useraccounts:core/lib/templates_helpers/at_signup_link.js
        deleted:    packages/useraccounts:core/lib/templates_helpers/at_social.js
        deleted:    packages/useraccounts:core/lib/templates_helpers/at_terms_link.js
        deleted:    packages/useraccounts:core/lib/templates_helpers/at_title.js
        deleted:    packages/useraccounts:core/lib/utils.js
        deleted:    packages/useraccounts:core/package.js
        deleted:    packages/useraccounts:core/tests/tests.js

Any suggestions how to solve this?

https://github.com/SpaceTalk/SpaceTalk/blob/develop/server/methods/channels/remove.js#L4
Please wrap your method with this before doing anything, even checks:

if (this.userId) {
  // Do stuff
  // check(param1, String);
  // check(parame2, Number);
}

Pressing enter directly with empty channel name allows insertion

Looks like there is somethign wrong with displaying the time per message when I look at older messages they all show the same date/time

tried SpaceTalk on windows and the styles are not getting reflected.

It is required to develop the following functionality (suggestions are welcome):

• Introduce a new property topic of a channel document;
• Create a dropdown button next to the channel title
  • Provide a textbox in a dropdown, which would contain an editable field topic
• Represent topic next to the title as shown in the screenshot below

Trello: https://trello.com/c/eMHSS5uy/76-channel-description