spacestation13 / byonddiffbots Goto Github PK

Description

When comparing diff between map changes, mobs aren't highlighted in red.

Steps to reproduce

1. make a mapping change that deals with mobs
2. view the diff
3. cry when you can't tell what mobs are changed

Expected Behavior

All diff is highlighted for ease of viewing and review

Additional Information & Screenshots

Case of object critter to mob critter

MapDiffBot2 shits its self after a while

https://github.com/pariahstation/Pariah-Station/pull/732/checks?check_run_id=6533769820 IDB 2
https://github.com/pariahstation/Pariah-Station/pull/732/checks?check_run_id=6533770185 IDB Stable

https://github.com/cmss13-devs/cmss13/pull/6233/checks?check_run_id=24534214701

Above PR is a fairly simple one to repath a few item types. However, the diff for BigRed.dmm seems to imply a lot was changed, despite nothing being different between the new/old images (aside from what was actually changed)

https://affectedarc07.blob.core.windows.net/mdb2/images/366979357/24534214701/m/maps_map_files_BigRed_BigRed/0-diff.png

This only seems to have happened with the one .dmm diff, the rest of the maps seem unaffected by any kind of bug.

Here it show almost entire file changed, and icons shuffled randomly ss220-space/Paradise#3342
Here it shows chnages in nianflag_fire (flags_lefthand.dmi, flags_righthand.dmi) when there was no changes, also it show wrong animation ss220-space/Paradise#3354
When DMI files not contains animation behavior looks correct

https://github.com/tgstation/tgstation/pull/67184/checks?check_run_id=6534382354

IconDiff Bot worked just fine

See:

0: Fetching and constructing diffs
1: Merging
2: Trying to merge base into head
3: 1 uncommitted change would be overwritten by merge; class=Merge (22); code=Conflict (-13)

https://github.com/goonstation/goonstation/pull/19258/checks?check_run_id=25687782375

Basically, title says it all. It just links to resources that don't seem to actually exist.

Here's the most recent example I can give you.

Stack trace:
task 220795 panicked

TauCetiStation/TauCetiClassic#10046

I tested this on two different repos. The diff generates, but images (including raw links) are invalid.

All of Old - New - Diff, both the in-github preview and the raw link.

Due to how repos are cloned by IDB and MDB, it's not possible for them to create diffs for private git respositories. I'd like to just hand an access token and have that squared away. @Cyberboss

https://github.com/tgstation/tgstation/pull/83507/checks?check_run_id=25438632704

I checked the raw links and they're just blank png's, not sure what happened.

Asd asked me to put this here for their convenience.

It may not be possible, but it would be incredibly nice if any sort of pipe/wire changes that are under tiles are highlighted. It would make checking rewires/repipes much easier.

From:
https://github.com/yogstation13/Yogstation/runs/19222841503

Stack trace:
`Error handling job

An unexpected error occured during processing, possibly caused by malformed maps, icons, or server catching fire.

The following stack trace may be useful:
Stack trace

IconFile::from_bytes failed for "yogstation/icons/mob/screen_full_big.dmi"

Caused by:
Unexpected end of data before image end.`

File in question:
https://github.com/EdgeLordExe/Yogstation/blob/jungleland/yogstation/icons/mob/screen_full_big.dmi

Idea:

Highlight 1 alpha pixels on sprites so that we can tell if holes/outlines are done. See image for a (fake) example.

Possible implementation:

for color in dmi.pallete:
  if color.alpha == 1:
    color.alpha = 255
    color = "#ff00ff" // magenta

Downsides / Alternatives:

Some app users may not want this because they dum.
Perhaps make it opt-in using a config file, similar to SpacemanDMM (maybe in .github?):

IconDiffBot.toml:
[alpha_highlight]
enabled = true
color = "#ff00ff"

Example Images (there's not actually a 1 alpha outline but you get the point):

Shit like this jupyterkat/BeeStation-Hornet#1284

Causes shit like this

50% of the MDB storage being used on one codebase and said codebase being entirely automated PRs is an embarrassment.