Git Product home page Git Product logo

byonddiffbots's People

Contributors

affectedarc07 avatar cyberboss avatar jupyterkat avatar mchsl avatar tigercat2000 avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar

byonddiffbots's Issues

[IDB] Feature Request: 1 alpha pixel highlighting

Idea:

Highlight 1 alpha pixels on sprites so that we can tell if holes/outlines are done. See image for a (fake) example.

Possible implementation:

for color in dmi.pallete:
  if color.alpha == 1:
    color.alpha = 255
    color = "#ff00ff" // magenta

Downsides / Alternatives:

Some app users may not want this because they dum.
Perhaps make it opt-in using a config file, similar to SpacemanDMM (maybe in .github?):

IconDiffBot.toml:
[alpha_highlight]
enabled = true
color = "#ff00ff"

Example Images (there's not actually a 1 alpha outline but you get the point):

image
image

IconDiffBot2 shits itself on some .dmi files with big icons

From:
https://github.com/yogstation13/Yogstation/runs/19222841503

Stack trace:
`Error handling job

An unexpected error occured during processing, possibly caused by malformed maps, icons, or server catching fire.

The following stack trace may be useful:
Stack trace

IconFile::from_bytes failed for "yogstation/icons/mob/screen_full_big.dmi"

Caused by:
Unexpected end of data before image end.`

File in question:
https://github.com/EdgeLordExe/Yogstation/blob/jungleland/yogstation/icons/mob/screen_full_big.dmi

MDB2 diff rarely doesn't represent the present changes

https://github.com/cmss13-devs/cmss13/pull/6233/checks?check_run_id=24534214701

Above PR is a fairly simple one to repath a few item types. However, the diff for BigRed.dmm seems to imply a lot was changed, despite nothing being different between the new/old images (aside from what was actually changed)

https://affectedarc07.blob.core.windows.net/mdb2/images/366979357/24534214701/m/maps_map_files_BigRed_BigRed/0-diff.png

This only seems to have happened with the one .dmm diff, the rest of the maps seem unaffected by any kind of bug.

[MDB] Mob difference isn't highlighted

Description

When comparing diff between map changes, mobs aren't highlighted in red.

Steps to reproduce

  1. make a mapping change that deals with mobs
  2. view the diff
  3. cry when you can't tell what mobs are changed

Expected Behavior

All diff is highlighted for ease of viewing and review

Additional Information & Screenshots

image

Case of object critter to mob critter

[MDB] Images of diffs aren't being generated

I tested this on two different repos. The diff generates, but images (including raw links) are invalid.

All of Old - New - Diff, both the in-github preview and the raw link.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.