spacelift-io / terraform-spacelift-msteams Goto Github PK

When creating a webhook with this module, the named webhook that gets created is "MS Teams Integration ()".

This is a problem because there may be multiple spaces using the same channel name on Teams, not aware that this is going to cause a name collision for this module.

Proposed Solution
Add the Space ID in the webhook name:
MS Teams Integration (channel-name) [space-id]

Our organization self-hosts Spacelift at a custom url. When using this module, the links in the webhook take us to a spacelift.io URL instead of our custom domain name. When we click on the link it says that an account is not found, which makes the links in the webhook unusable.

Example of what we get:
https://account-name.app.spacelift.io/stack/my-stack-name

Example of what we expect:
https://spacelift.mycompany.com/stack/my-stack-name

Proposed Solution
Add a new input to the module that defines the domain name.

Example:

module "my-webhooks" {
  source = "spacelift-io/msteams/spacelift"

  domain       = "spacelift.mycompany.com"
  channel_name = spacelift_space.this.id
  space_id     = spacelift_space.this.id
  webhook_url  = local.webhook_url
}