Git Product home page Git Product logo

card-catalog's People

Contributors

jrtashjian avatar nickhamze avatar

Watchers

 avatar

card-catalog's Issues

Styling of buttons

I think we are setting too many of the CSS settings instead of just letting them inherit theme styles. I see this now:
Screen Shot 2020-02-23 at 9 41 27 PM

For example, with the buttons if I remove all the CSS (except for white-space: nowrap;) they end up looking like this, which I think matches much better.
Screen Shot 2020-02-23 at 9 40 27 PM

We also need to set it up so when you click on something it adds the active class or something so the button changes color and people know which one is selected.

With the search bar if we change it from class="search" to "type="search" it ends up looking much nicer as it inherits the theme styles:
Screen Shot 2020-02-23 at 9 39 26 PM

Styles?

What the difference between the default style and the list one? The look the same but the default one seems to have more space than the other one. I don't think we need both. I would get remove the list one and just have default and grid.

Also on the backend the list and default one look fine but on the frontend the text is aligned to the left.

Screen Shot 2020-02-23 at 9 30 06 PM

Screen Shot 2020-02-23 at 9 30 14 PM

CSS Tweak

You have this line of CSS

.wp-block-sortabrilliant-card-catalog .far {
    font-family: 'Font Awesome 5 Free' !important;
    font-weight: 400 !important;
}

But it ends up messing up the text when I think you just want it to apply to the icon. What if we changed it to this:

.wp-block-sortabrilliant-card-catalog .far:before {
    font-family: 'Font Awesome 5 Free' !important;
    font-weight: 400 !important;
}

Filter list incomplete

For the filter list we probably need to have ones for every type of file we have icons for. I'm using videos and there isn't a filter for that.

Also the filter for a particular file type should appear unless the file type is being used in that card catalog block.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.