Refactoring some common logic into a library about dinghy HOT 4 CLOSED

Hi,

What are you trying to achieve with the rust test suite exactly ? What specific parts of dinghy do you want to share with rust test suite, and which part would you prefer to exclude ? What about using dinghy itself as a library, just like cargo-dighy does and take it from there ?

In terms of sharing VS cut and pasting, there are other factor to consider. On principle, sharing would undoubtly be better. On the other hand, Dinghy code is young, still feels clunky, and is probably fragile in ways I have no idea about. Putting it as-is under the strict-ish code management suitable for rustc may be a bit premature.

from dinghy.

Hi Mathieu! Basically I would need the deployment + execution part of dinghy, but not the compiling. Right now it would just be for the simulator. I think your idea on "What about using dinghy itself as a library, just like cargo-dighy does and take it from there ?" makes a lot of sense. That might not be possible in the compiler on a first pass but I think a longer-term goal it would definitely be neat to have everything related to both Android and iOS as a reusable library.

As an example here's how I did it for libc: https://github.com/rust-lang/libc/pull/498/files

from dinghy.

Hi, is this topic still active ? Have you tried moving some logic already ? or should we just close this ?

from dinghy.

Hi Mathieu, sorry, I didn't have email notifications enabled apparently. I haven't been writing Rust for mobile so I haven't really spent much time on it. 😇 So yes, we could just close this for now.

It would still be neat to do, and when we were discussing this I submitted a PR to rust-lang/libc a while ago that added support to the libc library: https://github.com/rust-lang/libc/pull/498/commits. I suppose something similar would work for the main repo.

from dinghy.