Git Product home page Git Product logo

mindustry-modtemplate's People

Contributors

antsif-a avatar qmelz avatar sonnicon avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar

mindustry-modtemplate's Issues

Release artifacts should not be split by type

The non-dexed JAR should not be uploaded to releases, as the dexed version works for both platforms. The file size difference is tiny, and there's no reason to upload two different versions.

The main reason I care about this is that it will break mod importing from the client - with two jars to pick from, it's not clear which is the correct one, and there's no reason to have two in the first place.

Proposed soution: Remove this block, and remove the "dexed-" jar prefix from the other artifact.

d8 --min-api incorrectly configured

This template sets d8's min-api to be 26, which is significantly higher than Mindustry's minimum API level (14). Roughly 25% of Android phones have an API level below 26, meaning that jar mods produced with this template will not work on 25% of devices - upon import, a cryptic "unknown dex version" error will be shown in the stack trace. Here's an issue directly caused by this.

Yes, d8 complains about missing classes at API <26, but that's only because no dependencies are provided. Class files cannot be desugared correctly without these.

A solution to this problem can be seen in BetaMindy's gradle script.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.