sonaza / dressup Goto Github PK

Hello,

so unfortunately the new patch broke the addon a bit :p, i really hope you can help us with this and come back from the fail BFA hibernation ^^

30x bad argument #1 to '?' (Usage: local isTransmogrified, hasPending, isPendingCollected, canTransmogrify, cannotTransmogrifyReason, hasUndo, isHideVisual, texture = C_Transmog.GetSlotInfo(transmogLocat
[string "=[C]"]: in function GetSlotInfo' [string "@DressUp\core.lua"]:1237: in function ShowingHelm'
[string "@DRESSUP\core.lua"]:1230: in function IsSlotHidden' [string "@DressUp\core.lua"]:1186: in function ResetItemButtons'
[string "@DRESSUP\core.lua"]:510: in function <DressUp\core.lua:486>
[string "=[C]"]: ?
[string "@ace3\AceAddon-3.0\AceAddon-3.0-13.lua"]:70: in function <Ace3\AceAddon-3.0\AceAddon-3.0.lua:65>
[string "@ace3\AceAddon-3.0\AceAddon-3.0-13.lua"]:527: in function `EnableAddon'
[string "@ace3\AceAddon-3.0\AceAddon-3.0-13.lua"]:630: in function <Ace3\AceAddon-3.0\AceAddon-3.0.lua:615>

i hope it's only a random bug when i logged in since i never had it before ( or never used AH since latest update lol ........ )

basically each time i tried to click an item to but it , this showed up and unable to buy anything it really blocked the interface buttons

14x DressUp\core.lua:451: attempt to index field 'background' (a nil value)
DressUp\core.lua:451: in function `SetDressUpBackground'
DressUp\core.lua:932: in function <DressUp\core.lua:925>
(tail call): ?
(tail call): ?
...ns\Blizzard_VoidStorageUI\Blizzard_VoidStorageUI-1.0.lua:396: in function <...ns\Blizzard_VoidStorageUI\Blizzard_VoidStorageUI.lua:384>

Locals:
self =

I don't know how else to describe it, so here is a screenshot to demonstrate what I'm talking about.

To reproduce:

1. Be wearing an item whose appearance has 3D bits (e.g. the sleeves on this chestpiece)
2. Open dressup
3. Choose a race to preview (can be you own)
4. Undress all

Actual Behavior

Lua error when logging in after patch 8.2.5

Steps to Reproduce the Problem

1. update to 8.2.5
   2.log in

these are a phew of the errors i have been getting with 8.2.5:

1x DressUp\core.lua:608: attempt to index global 'DressUpModelControlFrame' (a nil value)
DressUp\core.lua:608: in function ToggleGizmo' DressUp\core.lua:513: in function <DressUp\core.lua:485> [C]: ? Ace3\AceAddon-3.0\AceAddon-3.0-12.lua:70: in function <Ace3\AceAddon-3.0\AceAddon-3.0.lua:65> Ace3\AceAddon-3.0\AceAddon-3.0-12.lua:527: in function EnableAddon'
Ace3\AceAddon-3.0\AceAddon-3.0-12.lua:620: in function <Ace3\AceAddon-3.0\AceAddon-3.0.lua:605>
[C]: in function LoadAddOn' FrameXML\UIParent.lua:448: in function UIParentLoadAddOn'
FrameXML\UIParent.lua:567: in function `TimeManager_LoadUI'
FrameXML\UIParent.lua:1208: in function <FrameXML\UIParent.lua:1106>

1x Error: Original call failed after running hooks for: ContainerFrameItemButton_OnModifiedClick
FrameXML\DressUpFrames.lua:204: attempt to index local 'frame' (a nil value)(tail call): ?
[string ":OnClick"]:10: in function <[string ":OnClick"]:1>

(tail call): ?
Stubby\Stubby-8.2.6376 (SwimmingSeadragon).lua:382: in function <Stubby\Stubby.lua:326>
(tail call): ?
[string ":OnClick"]:10: in function <[string ":OnClick"]:1>

1x FrameXML\DressUpFrames.lua:204: attempt to index local 'frame' (a nil value)
FrameXML\DressUpFrames.lua:204: in function DressUpFrame_Show' DressUp\core.lua:1279: in function DressUpVisual'
...ceBlizzard_Collections\Blizzard_Wardrobe.lua:1956: in function <...ceBlizzard_Collections\Blizzard_Wardrobe.lua:1930>

Locals:
frame = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = "attempt to index local 'frame' (a nil value)"

Expected Behavior

Normally I'm able to resize the addon. By mistake I enlarged the window so big (it kind of glitched) it's outside of my WoW. I'm no longer able to resize the window.

Actual Behavior

The UI is too big and the scale corner is out of my screen. I can't save or reset neither cause the window is too big. I can move the Window horizontal only.

Steps to Reproduce the Problem

1. Open Inspector / Dressing Room.

Expected Behavior

Clicking the chat option "What are the strenghts of the ? option while talking to the representative in oribos brings up the "View the 's offerings window, showing abilities, soulbinds and sanctum feature.

Actual Behavior

Clicking the chat option "What are the strenghts of the ? option while talking to the representative in oribos brings up an empty dressing room

Steps to Reproduce the Problem

1. Enable DressUp
2. Log into a fresh level 60 on the thorghast beta server
3. Get the quest, talk to Secutor Mevix and click the first option

Hello,

while using the Armory addon to link a spell from the Spellbook, i get this error from Dressup lol :

4x DressUp\comms.lua:189: attempt to index local 'link' (a number value)
DressUp\comms.lua:189: in function `HandleModifiedItemClick'
[string ":OnClick"]:2: in function <[string ":OnClick"]:1>

Locals:
link = 79134
(*temporary) = nil
(*temporary) = 79134
(*temporary) = nil
(*temporary) = "attempt to index local 'link' (a number value)"
OriginalHandleModifiedItemClick = defined @FrameXML\ItemButtonTemplate.lua:135

could just be a taint from Armory itself but i prefer to warn both addon authors :p

Expected Behavior

correct gear list on character

Actual Behavior

wrong item listed in dressing room

Steps to Reproduce the Problem

1. use dressing room to see an item

Hello,

it's no major issue or anything but i just noticed one of my gears is not the same that is currently equipped by my character :p

so this is what the Dressing room (with Dressup) is showing me : https://imgur.com/0Uk67Nd

while this is the same item in Character info : https://imgur.com/CyEKAJO

seems to be a small bug (or limitation) with Warforged items ^^

ty.

This error happens when you try to preview an illusion from the appearances collection with DressUp:

1x ...ceBlizzard_Collections\Blizzard_Wardrobe.lua:1495: attempt to index field 'ModelScene' (a nil value)
...ceBlizzard_Collections\Blizzard_Wardrobe.lua:1495: in function `WardrobeCollectionFrame_GetWeaponInfoForEnchant'
...ceBlizzard_Collections\Blizzard_Wardrobe.lua:1958: in function <...ceBlizzard_Collections\Blizzard_Wardrobe.lua:1930>

Locals:
slot = "SECONDARYHANDSLOT"
(*temporary) = nil
(*temporary) = nil
(*temporary) = true
(*temporary) = false
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = "attempt to index field 'ModelScene' (a nil value)"

I had no other add-on enabled other than BugGrabber/BugSack and DressUp.

Illusions aren't handled the same way as other models in the dressing frame (from the collection).

Would be nice to be able to remove/hide the Icons because its right above my Pawn Button and kind of distracting. For me its enough to just have a changed preview Window with the buttons being displayed there anyway.

Reported an issue to MJE's author, and did the testing he asked me to help him track down the problem. Even though the error report is showing MJE as the responsible party, it's having DressUp enabled that actually makes the error come up. See pasted response below...

MJE ticket:

With just MJE and DressUp installed, got this error. In all combinations I tested, it was loading/unloading DressUp that changed whether an error was caught by BugSack. However, the error message has not fundamentally changed. I know that loading order can do wonky things to what is being reported as the problem, so it could be that your addon is unfairly getting the blame. Will cross-post to it's page.

153x ...aceMountJournalEnhanced\UI\DressUpButton.lua:27: Usage: hooksecurefunc([table,] "function", hookfunc)
[C]: in function hooksecurefunc' ...aceMountJournalEnhanced\UI\DressUpButton.lua:27: in function <...aceMountJournalEnhanced\UI\DressUpButton.lua:3> ...aceMountJournalEnhanced\UI\DressUpButton.lua:41: in function ApplyPreviewButton'
...ddOns\MountJournalEnhanced\Settings\OptionsPanel.lua:111: in function <...ddOns\MountJournalEnhanced\Settings\OptionsPanel.lua:77>
[C]: ?
Masque\Libs\AceGUI-3.0\AceGUI-3.0-40.lua:72: in function <Masque\Libs\AceGUI-3.0\AceGUI-3.0.lua:70>
Masque\Libs\AceGUI-3.0\AceGUI-3.0-40.lua:290: in function Fire' ...GUI-3.0\widgets\AceGUIContainer-BlizOptionsGroup.lua:32: in function <...GUI-3.0\widgets\AceGUIContainer-BlizOptionsGroup.lua:31> [C]: in function pcall'
FrameXML\InterfaceOptionsFrame.lua:206: in function <FrameXML\InterfaceOptionsFrame.lua:205>
[C]: in function `securecall'
FrameXML\InterfaceOptionsFrame.lua:229: in function <FrameXML\InterfaceOptionsFrame.lua:221>

Actual Behavior

as was to be expected the new races have no backgrounds :p ( https://imgur.com/AVn8P3C ) this is low prio obviously ^^

but i was surprised with a small error while using the race menu:

10x FrameXML\EasyMenu.lua:26: attempt to get length of local 'menuList' (a nil value)
FrameXML\EasyMenu.lua:26: in function initFunction' FrameXML\UIDropDownMenu.lua:77: in function UIDropDownMenu_Initialize'
FrameXML\UIDropDownMenu.lua:1085: in function `ToggleDropDownMenu'
[string ":OnClick"]:1: in function <[string ":OnClick"]:1>

Locals:
frame = DressUpContextMenuFrame {
0 =
Right = DressUpContextMenuFrameRight {
}
Left = DressUpContextMenuFrameLeft {
}
displayMode = "MENU"
initialize = defined @FrameXML\EasyMenu.lua:25
Button = DressUpContextMenuFrameButton {
}
Text = DressUpContextMenuFrameText {
}
Middle = DressUpContextMenuFrameMiddle {
}
Icon = DressUpContextMenuFrameIcon {
}
}
level = 1
menuList = nil
(*temporary) = 1
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = "attempt to get length of local 'menuList' (a nil value)"

it still works but i get the small spam messages lol

Steps to Reproduce the Problem

1. lookup an appearance with Vulpera or Mechagnomes

2. use the "change preview race" dropdown menu

It's a bit annoying when the model is moving when you're trying to get that exact look you want. It should stay idle, just like in the original DressUp frame.

Basically, in your DressUpFrame_Show, you should add this:

DressUpModel:SetAnimation(0, 0); -- SetAnimation(0) is the default, should be its 0 variant

Getting this error at login in patch 9.0.2 (error was not there with patch 9.0)

Message: Couldn't find inherited node: BrowserButtonTemplate
Time: Thu Nov 19 02:51:49 2020
Count: 8

That's the entire error, does not even show the addon's name.

I'm gettin the following error for a while:

4x ElvUI\Modules\skins\Skins.lua:392: does not exist.
[string "=[C]"]: ?
[string "@ElvUI\Modules\skins\Skins.lua"]:392: in function HandleMaxMinFrame' [string "@ElvUI\Modules\skins\Blizzard\DressingRoom.lua"]:21: in function <ElvUI\Modules\skins\Blizzard\DressingRoom.lua:6> [string "=[C]"]: ? [string "@ElvUI\Modules\skins\Skins.lua"]:1331: in function <ElvUI\Modules\skins\Skins.lua:1326> [string "=[C]"]: ? [string "=[C]"]: ? [string "=[C]"]: ? [string "=[C]"]: ? [string "=[C]"]: ? [string "=[C]"]: ? [string "=[C]"]: ? [string "@ElvUI\Core\Core.lua"]:1235: in function CallLoadFunc'
[string "@ElvUI\Core\Core.lua"]:1250: in function CallLoadedModule' [string "@ElvUI\Core\Core.lua"]:1276: in function InitializeModules'
[string "@ElvUI\Core\Core.lua"]:1534: in function <ElvUI\Core\Core.lua:1512>

While trying to fix it, I found out that it has to do with the minimize/maximize button on the Dressing Room.
ElvUI tries to skin that button even though DressUp is enabled and the button does not exist.

When I preview (CTRL + LMB) an Item with one of the Allied Races, the background is just green - and i can't change it with CTRL+Scroll.
But when I select one of the Allied Races in the drop down Menu, the Background is normal and changeable.

Hi, after the recent update to v2.1.6 it's causing DejaCharacterStats to break my character panel. It causes the panel to not extend showing the stats. It seems to work otherwise but throws errors for me.
When I disable DressUp, DejaCharacterStats works fine.
When I disable all addons but DressUp it errors and breaks the character panel.

Here's the error:

13x DressUp\core.lua:231: Usage: GetItemInfo(itemID|"name"|"itemlink") [C]: in functionGetItemInfo'
DressUp\core.lua:231: in function UpdatePaperDollItemLevels' DressUp\core.lua:1148: in function?'
...que\Libs\CallbackHandler-1.0\CallbackHandler-1.0-6.lua:145: in function <...que\Libs\CallbackHandler-1.0\CallbackHandler-1.0.lua:145>
[string "safecall Dispatcher[3]"]:4: in function <[string "safecall Dispatcher[3]"]:4>

[string "safecall Dispatcher[3]"]:13: in function ?' ...que\Libs\CallbackHandler-1.0\CallbackHandler-1.0-6.lua:90: in functionFire'
Bartender4\libs\AceEvent-3.0\AceEvent-3.0-3.lua:120: in function <Bartender4\libs\AceEvent-3.0\AceEvent-3.0.lua:119>

Locals:
nil`

Thanks for your time.

8x [string ":OnShow"]:2: Usage: PlaySound(soundKitID, optional["SFX","Music","Ambience", "Dialog" or "Master"], [forceNoDuplicates, runFinishCallback])
[C]: in function PlaySound' [string "*:OnShow"]:2: in function <[string "*:OnShow"]:1> (tail call): ? [C]: in function Show'
FrameXML\UIParent.lua:2441: in function SetUIPanel' FrameXML\UIParent.lua:2282: in function ShowUIPanel'
FrameXML\UIParent.lua:2151: in function <FrameXML\UIParent.lua:2147>
[C]: in function SetAttribute' FrameXML\UIParent.lua:2935: in function ShowUIPanel'
FrameXML\DressUpFrames.lua:113: in function <FrameXML\DressUpFrames.lua:105>
[C]: in function DressUpFrame_Show' DressUp\core.lua:1118: in function <DressUp\core.lua:1103> (tail call): ? (tail call): ? (tail call): ? FrameXML\ContainerFrame.lua:1077: in function <FrameXML\ContainerFrame.lua:1076> [C]: ? [C]: in function pcall'
Stubby\Stubby-7.4.5714 (TasmanianThylacine).lua:380: in function <Stubby\Stubby.lua:326>
(tail call): ?
[string ":OnClick"]:10: in function <[string "*:OnClick"]:1>

Locals:
(*temporary) = "igCharacterInfoOpen"

I am not playing the game for the lack of interest and cost. My updating this addon is thus quite unlikely in the near future.

Lack of interest is further compounded by Blizzard's wanton disregard for addon APIs with how they like to nuke things that work fine and then addons require major rewrites every patch. This addon was already majorly broken in patch 8.2.0. and as such would require a lot of rework to adjust it to the new model frame system.

Potentially spending tens of hours trying to fix this for no benefit of my own is not exactly my ideal pastime.

I may still be around to approve pull requests with fixes so if anybody wants to self-flagellate themselves with this, go right ahead. Or fork it, it's open source after all.