solusipse / ureq Goto Github PK

Extra null pointer checks are not needed in a function like "ureq_close".

struct Page is declared as follows:

struct Page {
    char *url;
    char *(*func)();
    char *method;
};

But in function ureq_serve which adds a page to the list of pages, its parameter to initialize the function pointer in a page is as follows:
char *(*func)(HttpRequest *)...

Is this something that was overlooked?

If yes, then I can send a commit to fix the issue in my already submitted PR...

Would you like to add more error handling for return values from functions like "malloc"?

I've taken the opportunity to make a major change in the structure of the project by introducing a more lean design, separating components of the system into their own file definitions (details)...

Details that is irrelevant to the user of the system has been hidden in a directory (internal)...

All a user should be concerned with now is the files in the root directory and the examples folder...

I've also renamed the http methods to use a pattern suggested here which includes UREQ_*...

You can now take it from here if this proposal is accepted and introduce proper source documentation in the interface file ureq.h for each function to make the framework self explanatory by just looking at that single file...

I suggest to add the key word "const" to the type specifiers for parameters like the following.

• r (function "ureq_get_header")
• return type (function "ureq_get_code_description")

Would you like to apply the advices from an article to more places in your source files?

Would you like to replace any double quotes by angle brackets around file names for include statements?

Especially for ESP8266.

It's very unstable right now. It should be entirely rewritten.

Have you thought about making this as a library for the Arduino IDE? I think it get a lot more usage since the current web server possibilities are quite unnstable.