solus-project / brisk-menu Goto Github PK

We have a bit of a weird situation going on with our "Copyright" strings in files, where one bit gets copied to another file, and the original copyright assignment is not quite preserved.

Proposal:

Collective copyright assignment to "The Brisk Menu Developers", i.e.

Copyright 2016-2017 Brisk Menu Developers

And an AUTHORS file to list contributors.

Sign Offs:

I'd need sign off from the following contributors to allow this to happen:

• @flexiondotorg
• @vkareh
• @cybre
• @feddasch
• @ikeydoherty

I think an option to disable pop-up windows for brisk menu would be nice.

Brisk menu doesn't show some icons, whereas the advanced mate menu shows theme normally. I tried with different icon themes but the problem presists. I am on Manjaro MATE edition. See images below:
http://imgur.com/a/UOQnN
http://imgur.com/a/GewvB

see https://github.com/flexiondotorg/ubuntu-mate-themes/issues/83#issuecomment-290109573
Would be nice to have a style class like this
button.flat.toggle.brisk-button {}

When Brisk Menu is added to a vertical panel (left or right side) it still displays it's label horizontally. You'll need the panel to be 48px or more wide to see this. The text label should be orientated vertically when Brisk is in a vertical panel.

It is a vast improvement for nontech-savvy users that may not have a clue why apps are named Caja, notepad - Pluma or be confused that calculator cannot be found because it's called Galcuclator. On the other hand calling all popular applications like Chrome - an "Internet browser" may be confusing too.

The pop-up window of the shutdown button doesn't always appear and appears to be slower than the others.

How to reproduce:
Move the cursor onto the shutdown icon from different angles and at different speeds.

There is no bash prompt [tex@localhost ~]$ when launching a terminal (mate-terminal) from the brisk menu.

brisk-menu 0.3.0
mate 1.16.x

Now on Ubuntu Mate 17.04 it's possible to use SuperKEY to use the Brisk Menu. It's posible that when SuperKEY is pressed and the Menu apear if I press SuperKEY again the Menu to disapear?... At this moment I need to press ESC not SuperKEY to exit from Menu from shortcuts.

Resume:

• accesing and exiting Brisk Menu NOW: SuperKEY+ESC
• accesing and exiting Brisk Menu IN THE FUTURE: SuperKEY+SuperKEY

I am using the brisk menu on a vertical panel and it shows the menu lower than the icon, almost like it should appear on a horizontal panel.

For a vertical panel, I think the menu should start at the top of the icon but out to the right side of it so not to cover the panel itself but also cover the open space to the right of the button under the top panel.

I would prefer the center button of my trackpad or middle mouse button to automatically launch brisk menu.

@ikeydoherty
@flexiondotorg
Would you consider this https://github.com/ukui/ukui-menu instead of Brisk? I like the Mate DE a lot. The only reason I've never adopted it was the lack of a good startmenu. I think Brisk is okay but the one developed by the Kylin guys is better. Seems there's a compatibility issue but nothing huge, probably. Thanks for reading through.

It would be really nice if you could implement these:

1. Text field should be always focused even when you select applications using "down" and "up" keys so that you can always immediately type something different. This behaviour exists in the Advanced MATE Menu.

2. Using "left" key should make "down" and "up" keys to select categories and then using "right" should enable you to select applications again. For speed reasons, when you are selecting categories using keyboard, "Enter" should launch the first application of the category and text field should again be focused to enable you fast search in "All" applications.

Hi,

I had the brisk menu dump core.
I installed a new application (with a *.desktop flie in /usr/share/applications) and when I opened the menu immediately after that, the menu crashed.
I can upload the core file if it helps.

For a consistent desktop experience multi language support would be nice.

When moving through brisk with the arrow keys (up/down) the font next to the icons disappears. The default behavior should be identical when browsing the categories with a mouse or a track point.

As discussed with @ikeydoherty briefly, a gsettings option will be added to Brisk to render something similar to how Slingscold does so that applications are presented as large icons while retaining the search filter and category selection.

The reason for suggesting this feature is so Brisk can be used in as a pseudo replacement for the Unity dash in MATE.

Please add a right click context menu to Brisk that expose the ability to launch a menu editor. MATE users expect this because the traditional menu had that capability going back to the GNOME2 days.

The default menu editor in MATE is Mozo, forked from Alacarte. However mate-panel will support Menulibre and fallback to Mozo, in the next stable release. See this upstream commit for the rationale:

• mate-desktop/mate-panel@a506150

I know this isn't an actual issue, but I have no idea how to do this.
OS Version: Mint Mate 18.1
Mate Version: 1.16.0

I download the repo, extract it, run "./autogen.sh" and then "sudo make install" and I get missing packages on "./autogen.sh" and nothing to make on "sudo make install". Can somebody tell me how to install it?

• OS: Solus 2017.01.01.0
• Brisk version: 0.3.0

Same behavior as the old Budgie 8 menu:

https://youtu.be/vkg_NTfL_N4

It should be in the upper left corner but it doesn't appears and it is not clickable:

But it's opening with the super key.
In the journal, I found this:

mai 19 10:56:59 solus-laptop brisk-menu[3816]: Negative content width -11 (allocation 1, extents 6x6) while allocating gadget (node button, owner GtkToggleButton)

My system has been updated (and rebooted) with the brand new brisk menu 0.4.0

Every time I install a new app in Solus I have to log out and back in to get brisk to see new applications. Is this not implemented or just not working?

if you open the menu, use the arrow keys to navigate to an item and then open the menu for a second time, focus is on the application list and you have to tab back to the text field to type.

Dear developer,
With the recent update to brisk menu 0.4.0 the super key shortcut is being hijacked and other shortcuts that use the super key dont work anymore for example i have super+space configured for "albert" launcher and it doesn't work since the latest brisk update.

Edit: this seems to only affect the left super key the right super key works fine.

Also another issue is super key opens the brisk menu it would be nice if hitting the supper key once the menu is open would close the menu.

thank you and keep up the good work.

The categories in Brisk can end up requiring a scrollbar being required to see the full extent of the categories and favourites. Make the height of the menu dynamically calculated based on the sum of visible categories and favourites.

Please add the capability to rebind the key combination to activate Brisk Menu.

More importantly for Ubuntu MATE users is that this keyboard shortcut also supports binding to the Super key only. But, if Brisk Menu activation is bound to the only the Super key:

• Other keyboard shortcuts that include the Super key should not be swallowed. (As happens in MATE Menu)
• Launching another application with a keyboard shortcut that includes the Super key should not also activate Brisk Menu. (As happens in Whisker Menu)

Exposing this configuration via gsettings only is fine because adding a UI to configure Brisk is a separate Roadmap item :-)

Right now Brisk basically has the secondary "drill down" portion of most menus, i.e it contains the category filter + item filtering.

However most menus also contain a primary view, with top pinned favourites (or recently launched),
and the ability to have arbitrary "sidebar pins".

To support such a mechanism, and indeed, the #36 "Dash" issue, we should look to abstract the views outside of the window itself.

Ideally we would be able to assign backends to a given view, and allow them to add items solely to that view.

For a landing "Favourites" page, it would use it's own unique list, and the Items would add straight to the primary view. The search field remains in a fixed mechanism, and the views can be wrapped in a GtkStack - allowing us to split a landing view from the drill down view.

The bitwise operators for calculating the search bar placement are inverted:

• Automatic should be 4 but is 1, which is Bottom.
• Bottom should be 1 but is 4, which is Automatic.

Some categories presented by Brisk Menu are empty, it would be preferable and consistent with the default MATE menu to not present any categories that are empty.

The scroll bar on the right side of Brisk Menu gets stuck when scrolling it.

How to reproduce:
Left click on the scroll bar and keep the button pressed while moving a pointing stick or mouse (in my case Lenovo TrackPoint) up or down.

Feature request: It would be great if we could easily edit the text on the applet, not just for internationalisation, but for general configurability. On my Thai desktop it really looks out of place, I've not encountered a menu where this was not easily configurable

Enable the user to drag the scrollbar with their mouse even if the mouse cursor is not over the widget.

The initial Super_L to open the Brisk menu is successful, but pressing Super_L a second time doesn't close it. Is this intended behaviour?

On a somewhat unrelated note, is it possible to change the keybinding if I for instance wanted to bind Super_L to Albert / Synapse?

Thank you for this brilliant menu, the new update which populates the menu with stuff from Control Center is great! :)

Edit: I forgot to mention that I'm using Ubuntu Mate 17.04 with Martin Wimpress' PPA https://launchpad.net/~flexiondotorg/+archive/ubuntu/brisk-menu

I notice that applications that start with a lowercase letter get sorted at the bottom of the menu. Can all items be listed in alphabetical order regardless of case sensitivity.

Currently, the list of applications in any category updates only after a mouse click on that category. It'd be nice if the list would update immediately on the mouse hovering over a category. Thanks.

Not sure if it's just a problem with Steam and Brisk Menu but if I look under /usr/share/applications there aren't any .desktop duplicate files.

This is on a clean install of Solus MATE.

Hello,

It would be great if the Brisk Menu could have a favorites menu and an option to be able to right click on any program and add it to that favorites menu,

Thank you,

EastAPOLO

Hi there,
I just tried to get rid of the Menu label on the panel and found that when you leave the default string, which is '' or you change the custom value to '', you still see the Menu word in the panel. The workaround was to change the value to space.

Cheers

PS: hope this is the right place to report issues

Decided to make this one request instead of two

A) Hover over (?? option?.... default action?) where instead of going over the categories if your using a mouse and then having to click the category to see the apps in it ... just hovering over the category brings up that specific categories apps

Wow I said categories alot there

B) While I love the superkey to open feature, If i accidentally hit the superkey i have to hit escape to close the menu .... perhaps maybe "If the brisk menu is open, and the super key is hit again, close the brisk menu" sort of thing... minor thought but it is a thought

Currently the menu main categories are as follows:

• Accessories
• Education
• Games
• Graphics
• Internet
• Office
• Programming
• Sound & Video
• System Tools
• Universal Access

Do these follow the freedesktop.org specifications in some way? https://specifications.freedesktop.org/menu-spec/latest/apa.html#main-category-registry

I am not sure what is the best way to solve this but why not use them as a basic orientation but ultimately develop a more intuitive categorization system. I've never really been a fan of the freedesktop categories. They are neither efficient (in the sense of finding what I need) nor exploratory (in the sense of software discoverability) but simply a convention system some people thought made sense to them.

Lastly, I think the categories should match those of the Software Center or vice versa.

on my Arch Linux with MATE 1.18 already installed GTK-noCSD and qt5ct. By using script on /etc/profile.d/, the variabel environment i.e GTK_CSD=0 and QT_QPA_PLATFORMTHEME=qt5ct was set

But when launch Gthumb from Brisk-Menu , it still use CSD windowing. Same goes Virtualbox (qt5) not get native theme. It's like they not get GTK_CSD=0 nor QT_QPA_PLATFORMTHEME=qt5ct

Is there a way or workaround to make a program launched from Brisk-Menu get all environment variables??

In addition to #13 please add a gsettings option to disable the text label completely such that only the icon is displayed for Brisk Menu in the menubar.

Steps:

1. Open brisk menu
2. Cursor is in search field
3. Press down to reach the application list
4. Selected entry's text label disappears, likely because it turns to white and the background is white

Tested on Solus Mate 2017.04.18 with full updates

Brisk menu cannot find with search applications like "Appearance", "Startup Applications", "MATE Tweak" and other items that exist on control center.

So, maybe add a "Settings" category or make the "Control Center" entry expandable or something so that brisk menu will be able to search and find these items.

Currently the "All" button is hard-coded and has a special path within the sidebar.

More importantly, this allows better organisation of the sidebar, and would then allow us to introduce an option to select the default backend, i.e. which view to show first when opening the menu. This would allow us to expose an option to switch between "All" and "Favourites" as the primary view when opening the menu.

Implementation specifics:

• Implement BriskSection->can_show_item to always return `TRUE.
• Emit this single BriskSection with an _("All") name
• Instead of selecting the button prior to view, select the first BriskMenuCategoryButton in the backend's box (self->section_boxes)

I prefer it on the bottom (like how it is on Windows) because then my eyes barely have to move from the location of the menu button.

Hi @ikeydoherty,

I tried to compile your early code on Manjaro, but failed:

libtoolize: putting auxiliary files in '.'.
libtoolize: linking file './config.guess'
libtoolize: linking file './config.sub'
libtoolize: linking file './install-sh'
libtoolize: linking file './ltmain.sh'
libtoolize: putting macros in AC_CONFIG_MACRO_DIRS, 'm4'.
libtoolize: linking file 'm4/libtool.m4'
libtoolize: linking file 'm4/ltoptions.m4'
libtoolize: linking file 'm4/ltsugar.m4'
libtoolize: linking file 'm4/ltversion.m4'
libtoolize: linking file 'm4/lt~obsolete.m4'
libtoolize: Consider adding '-I m4' to ACLOCAL_AMFLAGS in Makefile.am.
libtoolize: putting auxiliary files in '.'.
libtoolize: copying file './ltmain.sh'
libtoolize: putting macros in AC_CONFIG_MACRO_DIRS, 'm4'.
libtoolize: copying file 'm4/libtool.m4'
libtoolize: copying file 'm4/ltoptions.m4'
libtoolize: copying file 'm4/ltsugar.m4'
libtoolize: copying file 'm4/ltversion.m4'
libtoolize: copying file 'm4/lt~obsolete.m4'
libtoolize: Consider adding '-I m4' to ACLOCAL_AMFLAGS in Makefile.am.
configure.ac:3: installing './compile'
configure.ac:2: installing './missing'
Makefile.am: installing './depcomp'
checking for a BSD-compatible install... /usr/bin/install -c
checking whether build environment is sane... yes
checking for a thread-safe mkdir -p... /usr/bin/mkdir -p
checking for gawk... gawk
checking whether make sets $(MAKE)... yes
checking whether make supports nested variables... yes
checking whether UID '1000' is supported by ustar format... yes
checking whether GID '100' is supported by ustar format... yes
checking how to create a ustar tar archive... gnutar
checking for gcc... gcc
checking whether the C compiler works... yes
checking for C compiler default output file name... a.out
checking for suffix of executables... 
checking whether we are cross compiling... no
checking for suffix of object files... o
checking whether we are using the GNU C compiler... yes
checking whether gcc accepts -g... yes
checking for gcc option to accept ISO C89... none needed
checking whether gcc understands -c and -o together... yes
checking for style of include used by make... GNU
checking dependency style of gcc... gcc3
checking for gcc option to accept ISO C99... none needed
checking for gcc option to accept ISO Standard C... (cached) none needed
checking whether make supports nested variables... (cached) yes
checking build system type... x86_64-unknown-linux-gnu
checking host system type... x86_64-unknown-linux-gnu
checking how to print strings... printf
checking for a sed that does not truncate output... /usr/bin/sed
checking for grep that handles long lines and -e... /usr/bin/grep
checking for egrep... /usr/bin/grep -E
checking for fgrep... /usr/bin/grep -F
checking for ld used by gcc... /usr/bin/ld
checking if the linker (/usr/bin/ld) is GNU ld... yes
checking for BSD- or MS-compatible name lister (nm)... /usr/bin/nm -B
checking the name lister (/usr/bin/nm -B) interface... BSD nm
checking whether ln -s works... yes
checking the maximum length of command line arguments... 1572864
checking how to convert x86_64-unknown-linux-gnu file names to x86_64-unknown-linux-gnu format... func_convert_file_noop
checking how to convert x86_64-unknown-linux-gnu file names to toolchain format... func_convert_file_noop
checking for /usr/bin/ld option to reload object files... -r
checking for objdump... objdump
checking how to recognize dependent libraries... pass_all
checking for dlltool... no
checking how to associate runtime and link libraries... printf %s\n
checking for ar... ar
checking for archiver @FILE support... @
checking for strip... strip
checking for ranlib... ranlib
checking command to parse /usr/bin/nm -B output from gcc object... ok
checking for sysroot... no
checking for a working dd... /usr/bin/dd
checking how to truncate binary pipes... /usr/bin/dd bs=4096 count=1
checking for mt... no
checking if : is a manifest tool... no
checking how to run the C preprocessor... gcc -E
checking for ANSI C header files... yes
checking for sys/types.h... yes
checking for sys/stat.h... yes
checking for stdlib.h... yes
checking for string.h... yes
checking for memory.h... yes
checking for strings.h... yes
checking for inttypes.h... yes
checking for stdint.h... yes
checking for unistd.h... yes
checking for dlfcn.h... yes
checking for objdir... .libs
checking if gcc supports -fno-rtti -fno-exceptions... no
checking for gcc option to produce PIC... -fPIC -DPIC
checking if gcc PIC flag -fPIC -DPIC works... yes
checking if gcc static flag -static works... yes
checking if gcc supports -c -o file.o... yes
checking if gcc supports -c -o file.o... (cached) yes
checking whether the gcc linker (/usr/bin/ld -m elf_x86_64) supports shared libraries... yes
checking whether -lc should be explicitly linked in... no
checking dynamic linker characteristics... GNU/Linux ld.so
checking how to hardcode library paths into programs... immediate
checking whether stripping libraries is possible... yes
checking if libtool supports shared libraries... yes
checking whether to build shared libraries... yes
checking whether to build static libraries... no
checking for pkg-config... /usr/bin/pkg-config
checking pkg-config is at least version 0.16... yes
checking for GTK... yes
checking for GIO... yes
checking for MENU... yes
checking for APPLET... yes
checking that generated files are newer than configure... done
configure: creating ./config.status
config.status: creating Makefile
config.status: executing depfiles commands
config.status: executing libtool commands

        brisk-menu 0.0.1
        =====================

        prefix:                 /usr
        libdir:                 ${exec_prefix}/lib
        sysconfdir:             /etc
        exec_prefix:            ${prefix}
        bindir:                 ${exec_prefix}/bin
        datarootdir:            ${prefix}/share

        compiler:               gcc
        cflags:                 -march=x86-64 -mtune=generic -O2 -pipe -fstack-protector-strong
        ldflags:                -Wl,-O1,--sort-common,--as-needed,-z,relro

glib-compile-resources --manual-register --target=brisk-resources.h --sourcedir=./data --generate-header --c-name brisk_resources data/brisk.gresource.xml
glib-compile-resources --manual-register --target=brisk-resources.c --sourcedir=./data --generate-source --c-name brisk_resources data/brisk.gresource.xml
make  all-am
make[1]: Entering directory '/build/brisk-menu/src/brisk-menu-7c94bb669c8456bc74e981704295349c0ffac7ea'
  GEN      data/org.mate.panel.applet.BriskMenuFactory.service
  GEN      data/com.solus_project.brisk.BriskMenu.mate-panel-applet
  CC       libbriskresources_la-brisk-resources.lo
  CC       src/brisk_menu-applet.o
  CC       src/brisk_menu-category-button.o
  CC       src/brisk_menu-desktop-button.o
  CC       src/brisk_menu-entry-button.o
  CC       src/brisk_menu-key-binder.o
  CC       src/brisk_menu-menu-keyboard.o
  CC       src/brisk_menu-launcher.o
  CC       src/brisk_menu-menu-grabs.o
  CC       src/brisk_menu-menu-search.o
  CC       src/brisk_menu-menu-sort.o
  CC       src/brisk_menu-menu-loader.o
  CC       src/brisk_menu-menu-window.o
  CCLD     libbriskresources.la
ar: `u' modifier ignored since `D' is the default (see `U')
  CCLD     brisk-menu
/usr/bin/ld: src/brisk_menu-key-binder.o: undefined reference to symbol 'XGrabKey'
/usr/lib/libX11.so.6: error adding symbols: DSO missing from command line
collect2: error: ld returned 1 exit status
make[1]: *** [Makefile:605: brisk-menu] Error 1
make[1]: Leaving directory '/build/brisk-menu/src/brisk-menu-7c94bb669c8456bc74e981704295349c0ffac7ea'
make: *** [Makefile:472: all] Error 2

Points all down to following line: https://github.com/solus-project/brisk-menu/blob/master/src/key-binder.c#L206

Here is the used PKGBUILD:

# Contributor: Philip Müller (manjaro)

pkgname=brisk-menu
pkgver=0.0.1
pkgrel=1
_commit=7c94bb669c8456bc74e981704295349c0ffac7ea
pkgdesc="A modern, clean menu for the MATE Desktop"
arch=('i686' 'x86_64')
url="https://github.com/solus-project/brisk-menu"
license=('GPL')
depends=('mate-panel-gtk3')
makedepends=('autogen')
source=("$pkgname-$pkgver.tar.gz::${url}/archive/${_commit}.tar.gz")
sha256sums=('ab88caf5a17f75ca7910ddeb5085850c5ec654d5c5af832d9a53b4cba2e88070')

build() {
  cd ${pkgname}-${_commit}
  ./autogen.sh
  make
}


package() {
  cd ${pkgname}-${_commit}
  make DESTDIR="${pkgdir}/" install
}

Do you need any further information from my end?

with that other issue I fully know this could be an issues could be a wonky install ... and in that case so you guys know, I will try a reinstall and close both of these "issues"

when I try to switch to any of the layouts in mate-tweak (which did work for me on Solus mate, no problem) ... this is what I get from the terminal.

Window Manager is: compiz
Base layout: fedora
Current layout: fedora
Switching to: default

(mate-tweak:1937): GLib-GIO-ERROR **: Settings schema 'org.mate.interface' does not contain a key named 'gtk-shell-shows-menubar'
Trace/breakpoint trap

or (picked randomly ... in case Compiz was the issue)

Window Manager is: marco
Base layout: default
Current layout: default
Switching to: solus

(mate-tweak:1990): GLib-GIO-ERROR **: Settings schema 'org.mate.interface' does not contain a key named 'gtk-shell-shows-menubar'
Trace/breakpoint trap

The only two updates that I have not installed are those two listed Nvidia updates (this is a 2009 Toshiba with an ATI card anyway) and Libre office ... all other updates are done ... even hit "refresh" in the updater just to be sure i am not missing a new package that may fix this.

Update: removed some text from my original post and I am STILL seeing this AFTER A FRESH install of Solus Mate

It would be great if we can resize the menu. On large screens, it look a bit small. Keep up the great work guys, it is already very great!