The archiso-sb-shim from solsticedhiver

archiso-sb-shim's People

Contributors

Stargazers

Watchers

archiso-sb-shim's Issues

Variable reference typo in patch file

Hi!
I latest patch version there's a typo in variable reference:

archiso-sb-shim/mkarchiso.patch

Line 187 in 16aac5c

+ install -m 0644 DB.cer $"{isofs_dir}/EFI/BOOT/DB.cer"

With this typo and patch in-place creation of the ISO file will fail.
Thank you for your hard work.

"efibootimg" variable is incorrectly referenced as "efiboot.img" in the patch file

Hello,

It seems you have used incorrect variable name in your patch file.
${efiboot.img} is used, and ${efibootimg} should be used, at least - it looks so...
My build passes only when the blow corrections are applied to the patch file:

--- mkarchiso.patch-orig        2022-09-08 14:04:27.795838919 +0200
+++ mkarchiso.patch     2022-09-08 14:05:50.579990918 +0200
@@ -26,10 +26,10 @@
 +    mcopy -i "${efibootimg}" \
 +        "${pacstrap_dir}/usr/share/shim-signed/mmx64.efi" ::/EFI/BOOT/mmx64.efi
 +    # Copy systemd-boot EFI binary as grubx64.efi chainloaded by shimx64.efi
-+    mcopy -i "${efiboot.img}" \
++    mcopy -i "${efibootimg}" \
 +        "${pacstrap_dir}/usr/lib/systemd/boot/efi/systemd-bootx64.efi" ::/EFI/BOOT/grubx64.efi
 +    if [[ -f DB.cer ]] ;then
-+        mcopy -i "${efiboot.img}" DB.cer ::/EFI/BOOT/DB.cer
++        mcopy -i "${efibootimg}" DB.cer ::/EFI/BOOT/DB.cer
 +    fi

Without it, building ISO always fails:

[...]
[mkarchiso] INFO: Done! SYSLINUX set up for BIOS booting from a disk successfully.
[mkarchiso] INFO: Setting up SYSLINUX for BIOS booting from an optical disc...
[mkarchiso] INFO: Done! SYSLINUX set up for BIOS booting from an optical disc successfully.
[mkarchiso] INFO: Setting up systemd-boot for UEFI booting...
[mkarchiso] INFO: Creating FAT image of size: 47104 KiB...
mkfs.fat 4.2 (2021-01-31)
/usr/sbin/mkarchiso: line 767: ${efiboot.img}: bad substitution

Thanks for all your work.
Much appreciated!

Recommend Projects