Git Product home page Git Product logo

tagmanager's Introduction

Tag Manager

Introduction

An extensible javascript tag manager. jQuery is required. Support is specifically built in for Bootstrap typeahead. Javscript is written in TypeScript. Style sheets are written in LESS for easy customization.

Development

The home page for this project is http://soliantconsulting.github.com/tagmanager

License

Copyright 2012 Soliant Consulting http://www.soliantconsulting.com

Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated documentation files (the "Software"), to deal in the Software without restriction, including without limitation the rights to use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the Software, and to permit persons to whom the Software is furnished to do so, subject to the following conditions:

The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software.

THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.

tagmanager's People

Contributors

tomhanderson avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

tagmanager's Issues

Bootstrap 3.0 will no longer have typeahead support.

I was using the tagmanager that you originally based yours off of and then ran into an issue when I tried to swap out Bootstrap Typeahead for Twitters typeahead.js. Yesterday it was announced that Bootstrap is dropping their native typeahead functionality.

Heads up on v3 change: we're dropping our typeahead for @twitter's typeahead.js. Relevant commit: github.com/twitter/bootst…

— Twitter Bootstrap (@twbootstrap) May 9, 2013
<script async src="//platform.twitter.com/widgets.js" charset="utf-8"></script>

I'm going to try setting yours up in my project and see how it plays with Twitter's typeahead.js and then I'll report back.

Usage of "delete" and "import" function names in JS

The TagManager object has two functions (prototype) which are reserved keywords in JavaScript: delete and import.

It's not a bug per se, but some JS minifiers aren't able to handle this.

I suggest renaming the functions to

  • deleteTag
  • importTags (which unfortunately is a breaking change)

Strategy is accidentally over-written and *always* set to "ajax"

When checking if the current strategy is "ajax", you've accidentally forgotten one of the "=" signs needed for the comparison:

if (this.options.strategy = 'ajax' ...

As a result, its always setting the strategy to ajax, even if I want to use an array strategy instead.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.