Git Product home page Git Product logo

active_skin's People

Contributors

adamfrydrychrst avatar jeansreal avatar lfolv avatar mbbernstein avatar patrickwestwood avatar ravbaker avatar theflow0360 avatar viniciusalmeida avatar wojtek-krysiak avatar yogipatel avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

active_skin's Issues

$skinLogo doesn't find the image

When defining $skinLogo: url("logo.svg") no repeat 0 0; I get:

Started GET "/assets/logo.svg" for 127.0.0.1 at 2017-07-24 11:02:46 +0200
ActionController::RoutingError (No route matches [GET] "/assets/logo.svg"):

Even though I have it in assets. What's wrong here?

Footer overlays bottom data

There is no pusher for footer. If data is bigger than one screen, footer overlays bottom data, making it impossible to see.

active_skin.sassc: can't dump hash with default proc

No have idea how fix it..(

W, [2017-07-16T02:58:55.108297 #23723] WARN -- : Warning. Error encountered while saving cache 84ab4be3ee80d22bfd40c0fb8262dcd720bb16a2/active_skin.sassc: can't dump hash with default proc

I tried:

RAILS_ENV=production bundle exec rake tmp:cache:clear

and comment:
@import "active_skin";

active_skin header not responsive

After adding active_skin header is not responsive. Not able to override the styles. Please look into the picture below and let me know how can I solve it.

Screenshot 2019-04-10 at 11 37 26 AM

Thanks.

Plans for any js improvements?

This is awesome!
Do u guys have any js improvements in mind for near future?

For eg:

  • Integrating keyboard shortcuts.
  • Loading show page via ajax. If this is a possibility then can be have split screen view for the list as in gmail, when show is clicked.

New release with latest critical changes

Are there any plans to release the changes already available in master? The last version available in ruby-gems is 0.0.12 (october 2015), and it is very outdated.

Since some of the changes like the bugfix for google fonts issue are critical (without them this gem wont work with rails >= 6.0.1), could you please release a new version of this gem?

I know we can reference the master branch in our gemfiles but I think that it is not the best way as it goes against the purpose of locking specific versions.

@wojtek-krysiak maybe you can give us some hope regarding this topic 🙏! Thank you!

Google Font import

I think the @import directive on the very top of the active_skin.sass file is causing my application to to slow down because of the slow response from Google Fonts.

Is this an issue with Google Fonts?

Is there a strategy to minimize or to make it load faster?

$skinLogo Overrides the config.site_title_link

Anyone find a clean way to keep the link that is defined in the active_admin initializer?

I did the below to fix it on my end.

h1.site_title {  
  background: none !important;  
  padding-left: inherit !important;  
  text-indent: 0 !important;  
 }

remove ugly color scheme examples

@PatrykZ - please write which colour schemes are ugly and shouldn't be in readme. Also you could write me other - more pleasing to the eye - color schemes (two colors per scheme - header bck + action)

Design improvements

  1. Let's change the orange from psd to: #f57b0f
  2. Global font should be changed from Helvetica to Source Sans Pro.
  3. Chevron in top menu is overlapping text.
  4. Delete 1px white text-shadow on top right buttons. (image attached)
  5. Add the "+" icon.
  6. The red 4px height line should have an orange left side.
  7. Pagination is default, not according to design.
  8. Border of all checkboxes should be 1px #d3d8dc, after clicking the check should be red.
  9. Alert boxes are hiding under "title_bar" (image attached)
  10. "Witaj w panelu admina..." - should be #7f8c8d not #aaa.
  11. When I'm inside "Baza Danych" or any other submenu the gray block is going outside of the line by 1px (image attached)
  12. All inputs should be the same height (26px) without border-radius (image attached)

bad_inputs
alertbox
button
1px

Webpacker support

Any chance of releasing a package with the scss on npm to support activeadmin's new webpacker mode?

From a quick look the only issue would be the following line, since it can't find the image.

$skinLogo: #fff image-url("active_skin/default_logo.png") no-repeat 30px 0 !default

everything else should work as-is once published on npm.

drop-down menu ?

Your sample pictures suggest that it is the ability to create drop-down menus.
How do you manage it?

regards

Consistent style for tabs?

I wanted to use the tabs, but had to notice they don't really match the style:

edituser

Is there a style for them and I'm doing something wrong, or is it really missing?

Sass::SyntaxError: Undefined mixin 'rounded'

Getting the following error when precompiling. active_skin works fine in development.

ActiveAdmin version: 1.0.0.pre2

Sass::SyntaxError: Undefined mixin 'rounded'.
  (in /srv/app/shared/bundle/ruby/2.0.0/gems/active_skin-0.0.12/app/assets/stylesheets/active_skin.sass)
/srv/app/shared/bundle/ruby/2.0.0/gems/active_skin-0.0.12/app/assets/stylesheets/active_skin.sass:42:in `rounded'
/srv/app/shared/bundle/ruby/2.0.0/gems/active_skin-0.0.12/app/assets/stylesheets/active_skin.sass:42
/srv/app/shared/bundle/ruby/2.0.0/gems/sass-3.4.21/lib/sass/tree/visitors/perform.rb:349:in `block in visit_mixin'
/srv/app/shared/bundle/ruby/2.0.0/gems/sass-3.4.21/lib/sass/stack.rb:98:in `block in with_mixin'
/srv/app/shared/bundle/ruby/2.0.0/gems/sass-3.4.21/lib/sass/stack.rb:115:in `with_frame'
/srv/app/shared/bundle/ruby/2.0.0/gems/sass-3.4.21/lib/sass/stack.rb:98:in `with_mixin'
/srv/app/shared/bundle/ruby/2.0.0/gems/sass-3.4.21/lib/sass/tree/visitors/perform.rb:347:in `visit_mixin'
/srv/app/shared/bundle/ruby/2.0.0/gems/sass-3.4.21/lib/sass/tree/visitors/base.rb:36:in `visit'
/srv/app/shared/bundle/ruby/2.0.0/gems/sass-3.4.21/lib/sass/tree/visitors/perform.rb:158:in `block in visit'
/srv/app/shared/bundle/ruby/2.0.0/gems/sass-3.4.21/lib/sass/stack.rb:79:in `block in with_base'
/srv/app/shared/bundle/ruby/2.0.0/gems/sass-3.4.21/lib/sass/stack.rb:115:in `with_frame'
/srv/app/shared/bundle/ruby/2.0.0/gems/sass-3.4.21/lib/sass/stack.rb:79:in `with_base'
/srv/app/shared/bundle/ruby/2.0.0/gems/sass-3.4.21/lib/sass/tree/visitors/perform.rb:158:in `visit'
/srv/app/shared/bundle/ruby/2.0.0/gems/sass-3.4.21/lib/sass/tree/visitors/perform.rb:431:in `block (2 levels) in visit_rule'
/srv/app/shared/bundle/ruby/2.0.0/gems/sass-3.4.21/lib/sass/tree/visitors/perform.rb:431:in `map'
/srv/app/shared/bundle/ruby/2.0.0/gems/sass-3.4.21/lib/sass/tree/visitors/perform.rb:431:in `block in visit_rule'
/srv/app/shared/bundle/ruby/2.0.0/gems/sass-3.4.21/lib/sass/tree/visitors/perform.rb:179:in `with_environment'
/srv/app/shared/bundle/ruby/2.0.0/gems/sass-3.4.21/lib/sass/tree/visitors/perform.rb:429:in `visit_rule'
/srv/app/shared/bundle/ruby/2.0.0/gems/sass-3.4.21/lib/sass/tree/visitors/base.rb:36:in `visit'
/srv/app/shared/bundle/ruby/2.0.0/gems/sass-3.4.21/lib/sass/tree/visitors/perform.rb:158:in `block in visit'
/srv/app/shared/bundle/ruby/2.0.0/gems/sass-3.4.21/lib/sass/stack.rb:79:in `block in with_base'
/srv/app/shared/bundle/ruby/2.0.0/gems/sass-3.4.21/lib/sass/stack.rb:115:in `with_frame'
/srv/app/shared/bundle/ruby/2.0.0/gems/sass-3.4.21/lib/sass/stack.rb:79:in `with_base'
/srv/app/shared/bundle/ruby/2.0.0/gems/sass-3.4.21/lib/sass/tree/visitors/perform.rb:158:in `visit'
/srv/app/shared/bundle/ruby/2.0.0/gems/sass-3.4.21/lib/sass/tree/visitors/perform.rb:431:in `block (2 levels) in visit_rule'
/srv/app/shared/bundle/ruby/2.0.0/gems/sass-3.4.21/lib/sass/tree/visitors/perform.rb:431:in `map'
/srv/app/shared/bundle/ruby/2.0.0/gems/sass-3.4.21/lib/sass/tree/visitors/perform.rb:431:in `block in visit_rule'
/srv/app/shared/bundle/ruby/2.0.0/gems/sass-3.4.21/lib/sass/tree/visitors/perform.rb:179:in `with_environment'
/srv/app/shared/bundle/ruby/2.0.0/gems/sass-3.4.21/lib/sass/tree/visitors/perform.rb:429:in `visit_rule'
/srv/app/shared/bundle/ruby/2.0.0/gems/sass-3.4.21/lib/sass/tree/visitors/base.rb:36:in `visit'
/srv/app/shared/bundle/ruby/2.0.0/gems/sass-3.4.21/lib/sass/tree/visitors/perform.rb:158:in `block in visit'
/srv/app/shared/bundle/ruby/2.0.0/gems/sass-3.4.21/lib/sass/stack.rb:79:in `block in with_base'
/srv/app/shared/bundle/ruby/2.0.0/gems/sass-3.4.21/lib/sass/stack.rb:115:in `with_frame'
/srv/app/shared/bundle/ruby/2.0.0/gems/sass-3.4.21/lib/sass/stack.rb:79:in `with_base'
/srv/app/shared/bundle/ruby/2.0.0/gems/sass-3.4.21/lib/sass/tree/visitors/perform.rb:158:in `visit'
/srv/app/shared/bundle/ruby/2.0.0/gems/sass-3.4.21/lib/sass/tree/visitors/base.rb:52:in `block in visit_children'
/srv/app/shared/bundle/ruby/2.0.0/gems/sass-3.4.21/lib/sass/tree/visitors/base.rb:52:in `map'
/srv/app/shared/bundle/ruby/2.0.0/gems/sass-3.4.21/lib/sass/tree/visitors/base.rb:52:in `visit_children'
/srv/app/shared/bundle/ruby/2.0.0/gems/sass-3.4.21/lib/sass/tree/visitors/perform.rb:167:in `block in visit_children'
/srv/app/shared/bundle/ruby/2.0.0/gems/sass-3.4.21/lib/sass/tree/visitors/perform.rb:179:in `with_environment'
/srv/app/shared/bundle/ruby/2.0.0/gems/sass-3.4.21/lib/sass/tree/visitors/perform.rb:166:in `visit_children'
/srv/app/shared/bundle/ruby/2.0.0/gems/sass-3.4.21/lib/sass/tree/visitors/base.rb:36:in `block in visit'
/srv/app/shared/bundle/ruby/2.0.0/gems/sass-3.4.21/lib/sass/tree/visitors/perform.rb:186:in `visit_root'
/srv/app/shared/bundle/ruby/2.0.0/gems/sass-3.4.21/lib/sass/tree/visitors/base.rb:36:in `visit'
/srv/app/shared/bundle/ruby/2.0.0/gems/sass-3.4.21/lib/sass/tree/visitors/perform.rb:157:in `visit'
/srv/app/shared/bundle/ruby/2.0.0/gems/sass-3.4.21/lib/sass/tree/visitors/perform.rb:8:in `visit'
/srv/app/shared/bundle/ruby/2.0.0/gems/sass-3.4.21/lib/sass/tree/root_node.rb:36:in `css_tree'
/srv/app/shared/bundle/ruby/2.0.0/gems/sass-3.4.21/lib/sass/tree/root_node.rb:20:in `render'
/srv/app/shared/bundle/ruby/2.0.0/gems/sass-3.4.21/lib/sass/engine.rb:278:in `render'
/srv/app/shared/bundle/ruby/2.0.0/gems/sass-rails-3.2.6/lib/sass/rails/template_handlers.rb:106:in `evaluate'
/srv/app/shared/bundle/ruby/2.0.0/gems/tilt-1.4.1/lib/tilt/template.rb:103:in `render'
/srv/app/shared/bundle/ruby/2.0.0/gems/sprockets-2.2.3/lib/sprockets/context.rb:193:in `block in evaluate'
/srv/app/shared/bundle/ruby/2.0.0/gems/sprockets-2.2.3/lib/sprockets/context.rb:190:in `each'
/srv/app/shared/bundle/ruby/2.0.0/gems/sprockets-2.2.3/lib/sprockets/context.rb:190:in `evaluate'
/srv/app/shared/bundle/ruby/2.0.0/gems/sprockets-2.2.3/lib/sprockets/processed_asset.rb:12:in `initialize'
/srv/app/shared/bundle/ruby/2.0.0/gems/sprockets-2.2.3/lib/sprockets/base.rb:249:in `new'
/srv/app/shared/bundle/ruby/2.0.0/gems/sprockets-2.2.3/lib/sprockets/base.rb:249:in `block in build_asset'
/srv/app/shared/bundle/ruby/2.0.0/gems/sprockets-2.2.3/lib/sprockets/base.rb:270:in `circular_call_protection'
/srv/app/shared/bundle/ruby/2.0.0/gems/sprockets-2.2.3/lib/sprockets/base.rb:248:in `build_asset'
/srv/app/shared/bundle/ruby/2.0.0/gems/sprockets-2.2.3/lib/sprockets/index.rb:93:in `block in build_asset'
/srv/app/shared/bundle/ruby/2.0.0/gems/sprockets-2.2.3/lib/sprockets/caching.rb:19:in `cache_asset'
/srv/app/shared/bundle/ruby/2.0.0/gems/sprockets-2.2.3/lib/sprockets/index.rb:92:in `build_asset'
/srv/app/shared/bundle/ruby/2.0.0/gems/sprockets-2.2.3/lib/sprockets/base.rb:169:in `find_asset'
/srv/app/shared/bundle/ruby/2.0.0/gems/sprockets-2.2.3/lib/sprockets/index.rb:60:in `find_asset'
/srv/app/shared/bundle/ruby/2.0.0/gems/sprockets-2.2.3/lib/sprockets/bundled_asset.rb:16:in `initialize'
/srv/app/shared/bundle/ruby/2.0.0/gems/sprockets-2.2.3/lib/sprockets/base.rb:252:in `new'
/srv/app/shared/bundle/ruby/2.0.0/gems/sprockets-2.2.3/lib/sprockets/base.rb:252:in `build_asset'
/srv/app/shared/bundle/ruby/2.0.0/gems/sprockets-2.2.3/lib/sprockets/index.rb:93:in `block in build_asset'
/srv/app/shared/bundle/ruby/2.0.0/gems/sprockets-2.2.3/lib/sprockets/caching.rb:19:in `cache_asset'
/srv/app/shared/bundle/ruby/2.0.0/gems/sprockets-2.2.3/lib/sprockets/index.rb:92:in `build_asset'
/srv/app/shared/bundle/ruby/2.0.0/gems/sprockets-2.2.3/lib/sprockets/base.rb:169:in `find_asset'
/srv/app/shared/bundle/ruby/2.0.0/gems/sprockets-2.2.3/lib/sprockets/index.rb:60:in `find_asset'
/srv/app/shared/bundle/ruby/2.0.0/gems/actionpack-3.2.19/lib/sprockets/static_compiler.rb:19:in `block in compile'
/srv/app/shared/bundle/ruby/2.0.0/gems/sprockets-2.2.3/lib/sprockets/base.rb:219:in `block in each_logical_path'
/srv/app/shared/bundle/ruby/2.0.0/gems/sprockets-2.2.3/lib/sprockets/base.rb:206:in `block (2 levels) in each_file'
/srv/app/shared/bundle/ruby/2.0.0/gems/sprockets-2.2.3/lib/sprockets/base.rb:196:in `each'
/srv/app/shared/bundle/ruby/2.0.0/gems/sprockets-2.2.3/lib/sprockets/base.rb:196:in `each_entry'
/srv/app/shared/bundle/ruby/2.0.0/gems/sprockets-2.2.3/lib/sprockets/base.rb:204:in `block in each_file'
/srv/app/shared/bundle/ruby/2.0.0/gems/sprockets-2.2.3/lib/sprockets/base.rb:203:in `each'
/srv/app/shared/bundle/ruby/2.0.0/gems/sprockets-2.2.3/lib/sprockets/base.rb:203:in `each_file'
/srv/app/shared/bundle/ruby/2.0.0/gems/sprockets-2.2.3/lib/sprockets/base.rb:217:in `each_logical_path'
/srv/app/shared/bundle/ruby/2.0.0/gems/actionpack-3.2.19/lib/sprockets/static_compiler.rb:18:in `compile'
/srv/app/shared/bundle/ruby/2.0.0/gems/actionpack-3.2.19/lib/sprockets/assets.rake:56:in `internal_precompile'
/srv/app/shared/bundle/ruby/2.0.0/gems/actionpack-3.2.19/lib/sprockets/assets.rake:70:in `block (3 levels) in <top (required)>'
/srv/app/shared/bundle/ruby/2.0.0/gems/actionpack-3.2.19/lib/sprockets/assets.rake:60:in `block (3 levels) in <top (required)>'
Tasks: TOP => assets:precompile:primary

UI is getting overridden

I am getting this :
messy-ui-active-skin

when I am using active_skin with active admin 0.6.0 for rails 3.2.13.
The css contains body.active_admin prefix to the styles and it is causing the issues, here is a snippet:
body.active_admin #header ul.tabs { display: inline-block; height: 100%; margin: 0; padding: 0; } body.active_admin #header .header-item { float: left; height: 20px; position: relative; top: 2px; }

Please guide me what I am missing here.

Change of colors

Design was made in CMYK so colors are a little darker than they should be (especially action color). @PatrykZ - please change it.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.