softwareag / cumulocity-tenant-option-management-plugin Goto Github PK

I have created a tenant option with a single value of type boolean. Once I want to edit the tenant option, the JSON editor will be opened to update the value. I would expect the text editor to be opened to update the value instead of the JSON editor

this.jsonEditorData = JSON.parse(this.option.value) as object; doesn't throw an error if the value is of type boolean for whatever reason.

Right now json needs to be inputted in a free manner. Users can add configurations to show input masks for creation/ update of tenant options.

First of all: Nice plugin!

When I open the tenant-options view for the first time it is kind of empty:

Even if I have some tenant options already created via API. However, when I add a tenant option, it is shown correctly.

So my question:

• Should this plugin show existing tenant options or is there some logic to hide certain existing options? If there is some logic, what is it?
• The view looks broken if existing tenant options should be hidden. Maybe add an empty state to the list view would help. I thought the view is broken in the first place :/

Right now the plugin only loads the first page with a page size of 2000 for the tenant options.

tenant-option-management\tenant-option-management.service.ts

  getAllOptions() {
    return this.tenantOption
      .list({
        pageSize: 2000,
      })
      .then((res) => res.data.map((o) => ({ id: `${o.category}-${o.key}`, value: o.value })));
  }

It's unusual, but there could be use cases, which have more than 2000 tenant options. In this case, it might happen that not all options are displayed correctly, because they can't be found on the page loaded.

Proposed Solution

Update the query to include query parameter withTotalPages and load all available pages for tenant options.