rust github webhook server
License: MIT License
I'm on a curiosity voyage and these keys are my paddles 👨💻
I would like to receive pull_request_review event, but it seems not to be supported.
Any plan to support this?
By the way, the following events do not seem to be supported (I compared event list in GitHub and afterparty's document).
For now, I am interested only in pull_request_review event.
This project is now a library, not an app
I just run the example and get a error
fn main() {
let mut hub = Hub::new();
hub.handle("*", |delivery: &Delivery| {
println!("rec delivery {:#?}", delivery)
});
hub.handle_authenticated("pull_request", "secret", |delivery: &Delivery| {
println!("rec authenticated delivery");
match delivery.payload {
Event::PullRequest { ref action, ref sender, .. } => {
println!("sender {} action {}", sender.login, action)
},
_ => ()
}
});
let srv = Server::http("0.0.0.0:4567").unwrap()
.handle(hub.handle);
println!("hub is up");
srv.unwrap();
}
and error is
trait `for<'r, 'r, 'r> afterparty::Hub: std::ops::FnOnce<(hyper::server::Request<'r, 'r>, hyper::server::Response<'r>)>` not satisfied
What's the reason?
For building and running
Make it more straight forward to wrote in process handlers
We currently parse and package deliveries for requests from github. This can be avoided by collecting interested hooks first then packaging deliveries
is really kinda janky now. it works. but its janky. we can do better
it would be nice to know that the structs generated from json would be instantiated from the same json in runnable test format
In Taster, I use afterparty to provide a regression testing service for Rust applications. As part of this, I need to keep some state across multiple webhook deliveries (namely, performance results from the previous delivery).
Unfortunately, the Hook implementation requires the closure passed to handle to be Fn, not FnMut, so I cannot have any mutable captures. However, such captures are required so that I can actually persist results across invocations.
Is this a restriction that could possibly be relaxed? I don't see any other way of implementing this use case.
(Likewise, I would like to use the closure passed to handle to only push a request to do some testing onto a work queue, rather than doing all the work before returning from the request, since GitHub keeps thinking that my webhooks time out when the testing takes a while. However, not being able to mutate anything from within the closure makes this impossible, too.)
(Cc @jonhoo)
Hey, I am trying to use this library for an experimental project. I really like how you are generating api bindings from example data 😄
However, using it I am getting tons of parse errors from various events when trying to run this at the moment. Here's output from the ping event:
afterparty: recv 'ping' event with signature 'Some(XHubSignature("sha1=e5cadd4c82bb46be2b19f3be79a7d0de4d8efa1b"))'
afterparty: failed to parse json SyntaxError(unknown field "type", 1, 81)
"{\"Ping\":{\"zen\":\"Responsive is better than fast.\",\"hook_id\":8872023,\"hook\":{\"type\":\"Repository\",\"id\":8872023,\"name\":\"web\",\"active\":true,\"events\":[\"issues\",\"issue_comment\",\"pull_request\",\"pull_request_review_comment\",\"push\",\"status\"],\"config\":{\"content_type\":\"json\",\"insecure_ssl\":\"0\",\"secret\":\"********\",\"url\":\"http://109.146.234.160:54857\"},\"updated_at\":\"2016-06-23T19:25:48Z\",\"created_at\":\"2016-06-23T19:25:48Z\",\"url\":\"https://api.github.com/repos/clux/volf/hooks/8872023\",\"test_url\":\"https://api.github.com/repos/clux/volf/hooks/8872023/test\",\"ping_url\":\"https://api.github.com/repos/clux/volf/hooks/8872023/pings\",\"last_response\":{\"code\":null,\"status\":\"unused\",\"message\":null}},\"repository\":{\"id\":61758654,\"name\":\"volf\",\"full_name\":\"clux/volf\",\"owner\":{\"login\":\"clux\",\"id\":134092,\"avatar_url\":\"https://avatars.githubusercontent.com/u/134092?v=3\",\"gravatar_id\":\"\",\"url\":\"https://api.github.com/users/clux\",\"html_url\":\"https://github.com/clux\",\"followers_url\":\"https://api.github.com/users/clux/followers\",\"following_url\":\"https://api.github.com/users/clux/following{/other_user}\",\"gists_url\":\"https://api.github.com/users/clux/gists{/gist_id}\",\"starred_url\":\"https://api.github.com/users/clux/starred{/owner}{/repo}\",\"subscriptions_url\":\"https://api.github.com/users/clux/subscriptions\",\"organizations_url\":\"https://api.github.com/users/clux/orgs\",\"repos_url\":\"https://api.github.com/users/clux/repos\",\"events_url\":\"https://api.github.com/users/clux/events{/privacy}\",\"received_events_url\":\"https://api.github.com/users/clux/received_events\",\"type\":\"User\",\"site_admin\":false},\"private\":false,\"html_url\":\"https://github.com/clux/volf\",\"description\":\"A simple Github webhook bot (SKELETAL CODE ONLY SO FAR)\",\"fork\":false,\"url\":\"https://api.github.com/repos/clux/volf\",\"forks_url\":\"https://api.github.com/repos/clux/volf/forks\",\"keys_url\":\"https://api.github.com/repos/clux/volf/keys{/key_id}\",\"collaborators_url\":\"https://api.github.com/repos/clux/volf/collaborators{/collaborator}\",\"teams_url\":\"https://api.github.com/repos/clux/volf/teams\",\"hooks_url\":\"https://api.github.com/repos/clux/volf/hooks\",\"issue_events_url\":\"https://api.github.com/repos/clux/volf/issues/events{/number}\",\"events_url\":\"https://api.github.com/repos/clux/volf/events\",\"assignees_url\":\"https://api.github.com/repos/clux/volf/assignees{/user}\",\"branches_url\":\"https://api.github.com/repos/clux/volf/branches{/branch}\",\"tags_url\":\"https://api.github.com/repos/clux/volf/tags\",\"blobs_url\":\"https://api.github.com/repos/clux/volf/git/blobs{/sha}\",\"git_tags_url\":\"https://api.github.com/repos/clux/volf/git/tags{/sha}\",\"git_refs_url\":\"https://api.github.com/repos/clux/volf/git/refs{/sha}\",\"trees_url\":\"https://api.github.com/repos/clux/volf/git/trees{/sha}\",\"statuses_url\":\"https://api.github.com/repos/clux/volf/statuses/{sha}\",\"languages_url\":\"https://api.github.com/repos/clux/volf/languages\",\"stargazers_url\":\"https://api.github.com/repos/clux/volf/stargazers\",\"contributors_url\":\"https://api.github.com/repos/clux/volf/contributors\",\"subscribers_url\":\"https://api.github.com/repos/clux/volf/subscribers\",\"subscription_url\":\"https://api.github.com/repos/clux/volf/subscription\",\"commits_url\":\"https://api.github.com/repos/clux/volf/commits{/sha}\",\"git_commits_url\":\"https://api.github.com/repos/clux/volf/git/commits{/sha}\",\"comments_url\":\"https://api.github.com/repos/clux/volf/comments{/number}\",\"issue_comment_url\":\"https://api.github.com/repos/clux/volf/issues/comments{/number}\",\"contents_url\":\"https://api.github.com/repos/clux/volf/contents/{+path}\",\"compare_url\":\"https://api.github.com/repos/clux/volf/compare/{base}...{head}\",\"merges_url\":\"https://api.github.com/repos/clux/volf/merges\",\"archive_url\":\"https://api.github.com/repos/clux/volf/{archive_format}{/ref}\",\"downloads_url\":\"https://api.github.com/repos/clux/volf/downloads\",\"issues_url\":\"https://api.github.com/repos/clux/volf/issues{/number}\",\"pulls_url\":\"https://api.github.com/repos/clux/volf/pulls{/number}\",\"milestones_url\":\"https://api.github.com/repos/clux/volf/milestones{/number}\",\"notifications_url\":\"https://api.github.com/repos/clux/volf/notifications{?since,all,participating}\",\"labels_url\":\"https://api.github.com/repos/clux/volf/labels{/name}\",\"releases_url\":\"https://api.github.com/repos/clux/volf/releases{/id}\",\"deployments_url\":\"https://api.github.com/repos/clux/volf/deployments\",\"created_at\":\"2016-06-22T23:37:16Z\",\"updated_at\":\"2016-06-22T23:40:11Z\",\"pushed_at\":\"2016-06-22T23:39:47Z\",\"git_url\":\"git://github.com/clux/volf.git\",\"ssh_url\":\"[email protected]:clux/volf.git\",\"clone_url\":\"https://github.com/clux/volf.git\",\"svn_url\":\"https://github.com/clux/volf\",\"homepage\":\"\",\"size\":6,\"stargazers_count\":0,\"watchers_count\":0,\"language\":\"Rust\",\"has_issues\":true,\"has_downloads\":true,\"has_wiki\":true,\"has_pages\":false,\"forks_count\":0,\"mirror_url\":null,\"open_issues_count\":0,\"forks\":0,\"open_issues\":0,\"watchers\":0,\"default_branch\":\"master\"},\"sender\":{\"login\":\"clux\",\"id\":134092,\"avatar_url\":\"https://avatars.githubusercontent.com/u/134092?v=3\",\"gravatar_id\":\"\",\"url\":\"https://api.github.com/users/clux\",\"html_url\":\"https://github.com/clux\",\"followers_url\":\"https://api.github.com/users/clux/followers\",\"following_url\":\"https://api.github.com/users/clux/following{/other_user}\",\"gists_url\":\"https://api.github.com/users/clux/gists{/gist_id}\",\"starred_url\":\"https://api.github.com/users/clux/starred{/owner}{/repo}\",\"subscriptions_url\":\"https://api.github.com/users/clux/subscriptions\",\"organizations_url\":\"https://api.github.com/users/clux/orgs\",\"repos_url\":\"https://api.github.com/users/clux/repos\",\"events_url\":\"https://api.github.com/users/clux/events{/privacy}\",\"received_events_url\":\"https://api.github.com/users/clux/received_events\",\"type\":\"User\",\"site_admin\":false}}}"
afterparty: failed to parse event "ping" for delivery "49e54600-3978-11e6-8326-aa9bc862137f"I cross-referenced the data sent with the data/schema you are using to build the Event type and it appears to miss out a couple of things.
Presumably this should just be a case of updating the data directory and rebuilding afterparty?
It can technically be any json value, not just a map
this is less than idea, and takes forever to compile
$ ls -trlh
total 9952
-rw-r--r--+ 1 doug staff 144K Dec 1 15:24 events.rs.in
-rw-r--r--+ 1 doug staff 4.7M Dec 1 15:24 events.rs
Just a quick heads-up from a passer-by:
https://github.com/softprops/afterparty/blob/master/src/hook.rs#L45
This comparison might be vulnerable to timing attacks because it's not constant-time. Not sure if that's relevant here at all. I'm reporting such issues to a couple of repositories, please just ignore/close if it isn't applicable here.
Hey @softprops,
I ported afterparty to hyper 0.11 (and the hyper-related semantics seem to work), but the 'static lifetimes used for the hooks are causing troubles.
New hyper service: https://github.com/psychonautwiki/afterparty/blob/master/src/lib.rs#L129-L199
I've done most of the heavy lifting, maybe you could look into a smart way to fix this?
Error output: https://gist.github.com/KenanSulayman/89ea6158df1589540e1f28db5df99379
Cheers,
-- Kenan
🐝
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
Django
The Web framework for perfectionists with deadlines.
Laravel
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
Microsoft
Open source projects and samples from Microsoft.
Google
Google ❤️ Open Source for everyone.
Alibaba
Alibaba Open Source for everyone
D3
Data-Driven Documents codes.
Tencent
China tencent open source team.