society-for-internet-blaseball-research / cauldron Goto Github PK

It looks like the flag only ever gets set to false for STOLEN_BASE, but CAUGHT_STEALING also wouldn't end the plate appearance for the current batter. This may be a misunderstanding on my part of the meaning of the flag.

Baserunners who are put out on a play as a result of caught stealing, fielders choice, etc, currently do not appear in the base_runners events for the associated play. Ideally, the behavior would be for them to still appear in the play and either have base_after_play = 0, or to have a separate "out" flag, to denote that the runner was put out during the play.

Just keeping track of them so I don't forget!

• pitchesList should be IEnumerable<string>.
• gameId, batterId, batterTeamId, pitcherId, pitcherTeamId in GameEvent should be Guid.
• runnerId, responsibleBatterId in GameEventBaseRunner should be Guid.
• inning, errorsOnPlay, batterBaseAfterPlay, basesHit, runsBattedIn, outsBeforePlay, outsOnPlay should be sbyte.
• homeStrikeCount, awayStrikeCount, totalStrikes, totalBalls, totalFouls, lineupPosition should be short.
• baseBeforePlay, baseAfterPlay in GameEventBaseRunner should be sbyte.
• All decimal values should be double.

See game 00018bf4-9498-4ec7-ad49-cdf0a60efbed
Third out of bottom of 3rd is labeled as top of 4th

Game 00018bf4-9498-4ec7-ad49-cdf0a60efbed is missing this at least

Maybe save off their events with ToList or maybe just kill them once GameComplete has been called...

Game ID 0078d5d5-dc02-4025-821a-21fb7cc20556

"Kennedy Loser batting for the Crabs.",
"Ball. 1-0",
"Ball. 2-0",
"Kennedy Loser reaches on fielder's choice. Parker Parra out at second base. Valentine Games scores"

Event ends up with this:

"base_runners": [
		{
			"runner_id": "84a2b5f6-4955-4007-9299-3d35ae7135d3",
			"responsible_pitcher_id": "20fd71e7-4fa0-4132-9f47-06a314ed539a",
			"base_before_play": 0,
			"base_after_play": 1,
			"was_base_stolen": false,
			"was_caught_stealing": false,
			"was_picked_off": false
		},
		{
			"runner_id": "c675fcdf-6117-49a6-ac32-99a89a3a88aa",
			"responsible_pitcher_id": "20fd71e7-4fa0-4132-9f47-06a314ed539a",
			"base_before_play": 3,
			"base_after_play": 4,
			"was_base_stolen": false,
			"was_caught_stealing": false,
			"was_picked_off": false
		},
		{
			"runner_id": "7dcf6902-632f-48c5-936a-7cf88802b93a",
			"responsible_pitcher_id": "20fd71e7-4fa0-4132-9f47-06a314ed539a",
			"base_before_play": 1,
			"base_after_play": 4,
			"was_base_stolen": false,
			"was_caught_stealing": false,
			"was_picked_off": false
		}

We'll have to maintain a separate Dictionary mapping baserunners to responsible pitchers; when they disappear from the state, we'll delete them. Every time we reconstruct the baserunner list we'll pull the pitcher ID from there

It's only trying to set it for NEW baserunners

Game ID 00018bf4-9498-4ec7-ad49-cdf0a60efbed, a late-game home run

Not entirely possible what's making it happen, but I'm seeing some game events that do not have a batterId.

Example file: blaseball-log-1596003134151.json.gz

If a runner is batted in, there does not appear to be a baserunner record acknowledging that. The play should have a record with base_after_play set to 0 or 4 (ideally 4).

The responsible pitcher also seems to be always set to the current pitcher, regardless of who was actually responsible.

We may need to generally persist ALL info as soon as we reach 2 outs or something 🙄

Looks like maybe because the top of the 4th ended on a double play?

Make a hash of [inning, topOfInning, outsBeforePlay, eventIndex] on each GameEvent so they can be uniquely identified in the DB.

See game ID 07fb62fb-9b6d-419d-824f-bba0d217f028 (season 4 day 9)