snosme / poe-dat-viewer Goto Github PK

https://bugzilla.mozilla.org/show_bug.cgi?id=1639542

When using the file search in the left column, the ../ nav item is always hidden. Can you override it to always stay visible so we can still navigate folders when a search term is entered?

Zero index is "stable sorted" inside other null values

It's more of an issue of ooz-wasm lib, but since it doesn't have issues enabled I'm posting it here.

decompressUnsafe is so unsafe that it's unusable unless you have no parallel execution at all, because it requires processing output synchronously, while promises are always resolved asynchronously. So two calls to decompressSliceInBundle (or FileLoader.getFileContents) at the same time will always result in corrupted data.

decompress causes a runtime error, since it attempts to call module._free, but in this case module refers to global Node module and not to wasm module.

The best way to fix it (if the goal is to avoid unnecessary data copying) IMO is to pass a callback to process data synchronously before freeing memory. I made these changes in a fork @ d07RiV/ooz-wasm@7be502e but I can't make a PR since I had to add build folder into the repo for npm to work.

https://bugzilla.mozilla.org/show_bug.cgi?id=1346159

It would be a nice feature, to stand on a row, and then be able to do a reverse lookup, finding potential files which references this row.

Could be done by going through all known "refrence fields/arrays of references" and finding those which has a value corresponding to the selected rows index.

Hi,

after installing dependencies in /viewer & /lib the npm run dev command fails with the following error:

X [ERROR] No matching export in "node_modules/pathofexile-dat/dist/compute.js" for import "default"

node_modules/pathofexile-dat/dist/wasm.js:1:7:
  1 │ import Module from './compute.js';

The app starts when changing the import inside wasm.js into a named import:

import { Module } from "./compute.js

However, .dat files won't be correctly displayed since Module() is not a function.

When they are converted to JS f64 and then converted to String, extra digits of precision should not be shown.

Best proof will be

1. finding it as last bytes in "variable section" of Dat file,
2. be sure that found data makes sense.

Notice how array size is 1 but next variable data (string) is not on correct offset