sniebauer / jammming Goto Github PK

1. In App.js, the playList folder is spelled with a lower case 'l'. This caused the import to fail.

2. In playList.js, the import for playlist.css is spelled with a lower case 'l'. This caused the import to fail.

When the 'save to spotify' button is clicked. The searchResults resets but not the playlistTracks. We can reset the playlistTracks like so;

this.setState({
        playlistTracks: []
});

in the PlayList() function in app.js

The reason why the playlistName does not reset when the 'save to spotify' button is clicked is because the value of the input that displays the name has a default value not set to this.props.playlistName like so;

<input defaultValue={'New Playlist'} onChange={this.handleNameChange}/>

It should be like this instead;

<input value={this.props.playlistName} onChange={this.handleNameChange}/>

in playList.js

The project ran well. No major errors were detected. I would suggest running and testing the functionalities of the app before publishing to github. Ensure that all the features are working correctly. Since most of the errors were in relation to state, here is a great document to cover;

https://reactjs.org/docs/faq-state.html

No project detected. Please update and comment below to resume review.

Good idea removing your client id before uploading. The best way to do so would be to update the .gitignore file with config.js. That way config.js will not be uploaded. You could also leave instructions in readme.md on how developers can add their your config.js with the necessary credentials. Here is a reference document; https://www.atlassian.com/git/tutorials/gitignore