Git Product home page Git Product logo

Comments (14)

Oggom avatar Oggom commented on August 15, 2024

Works for me.

from snes9x.

Zelex avatar Zelex commented on August 15, 2024

Maybe a bad ROM then? I get a black screen when I load the ROM via snes9x 1.53 - so there is definitely something broken about it. However, it shouldn't cause a crash inside of libretro. Thats mainly what I'm complaining about. The crash, not so much the fact that it doesn't work.

from snes9x.

Zelex avatar Zelex commented on August 15, 2024

Can I send the ROM to you in some way for your testing?

from snes9x.

Zelex avatar Zelex commented on August 15, 2024

It crashes right after "Snes9x INFO: ROM image is in interleaved format - converting..."

from snes9x.

Oggom avatar Oggom commented on August 15, 2024

That's strange, have you tried another rom?

from snes9x.

Zelex avatar Zelex commented on August 15, 2024

Yeah, other games work fine. Its just this one so far. I'm going through my entire rom library and testing each one.

from snes9x.

Oggom avatar Oggom commented on August 15, 2024

Are you sure you are using the Snes9x core and not Snes9x Next?

from snes9x.

Zelex avatar Zelex commented on August 15, 2024

I am using this git repo with the libretro, whatever that uses.

from snes9x.

Oggom avatar Oggom commented on August 15, 2024

Then it might be a bad rom. Try redownloading it from a different source and see if that works.

from snes9x.

Zelex avatar Zelex commented on August 15, 2024

Well, I'll track it down then and fix it. I'll put the patch in this thread when I find it.

Latest info: crashes in S9xDeinterleaveType1(0x400000, ROM + CalculatedSize - 0x400000);

from snes9x.

Zelex avatar Zelex commented on August 15, 2024

Here is the fix. Enjoy! :)

@@ -1690,7 +1693,7 @@ bool8 CMemory::LoadROMInt (int32 ROMfillSize)
S9xDeinterleaveType1(0x400000, ROM);
S9xDeinterleaveType1(CalculatedSize - 0x400000, ROM + 0x400000);
}

  •                   else
    
  •                   else if(CalculatedSize >= 0x400000)
                    {
                            S9xDeinterleaveType1(CalculatedSize - 0x400000, ROM);
                            S9xDeinterleaveType1(0x400000, ROM + CalculatedSize - 0x400000);
    

from snes9x.

Zelex avatar Zelex commented on August 15, 2024

Wow, bad formatting. Basically replace the else there with a check to make sure the CalculatedSize is big enough, otherwise its memory corrupting.

from snes9x.

OV2 avatar OV2 commented on August 15, 2024

This path should only be hit if the rom is detected as tales of phantasia.
If at all, the size check should be in the S9xDeinterleaveType1 function, I'll take a look once I can find the time.

from snes9x.

Zelex avatar Zelex commented on August 15, 2024

Thanks! :)

from snes9x.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.