snapframework / snap-templates Goto Github PK

Following the instructions from the site, I try to use snap init followed by stack init to install those packages and stack complains that there's no compatible LTS with all the dependencies available.

Hi
Could you please add favicon.ico to each template into the static directories of the default, barebones and tutorial -templates. This way the access.log would be cleaner from the very beginning and maybe it is easier to someone then change the icon, too.
favicon.zip

Move as much as possible away from runTestsAndCoverage to cabal test

Potentially use --enable-library-coverage

A nitpick: currently, the repo is called snap-templates, while the package itself is called snap-template. This is confusing: one variant should be chosen and used everywhere.

otherwise the package is unbuildable with the ghc 8.6 series

Replacing stuff like this with a file.

If there is no file, everything is correct. Write the file.
If there is a file, compare against current result.

I am following directions from the site but the templates restrict me to using an older compiler because of MonadCatchIO-transformers. I just found out I need to delete that so that I can compile with ghc 8.

Hi
I tested the pull #13 by making the change by hand to the code. Monoids are not used meaning that the default-template will compile and install with cabal even if there is 'import Data.Monoid' in the source.

Thus, could you please decide whether to remove that line or leave it. I'll guess there will be good arguments for both actions. After that the pull-request could be closed (and this issue, too).

It seemed that the pull request has already the relevant code changes. Is it easy to merge that to the head branch? I'm asking this, because I could propose some minor additions or changes but I'm not sure what is an appropriate nor convenient way. (Late add: email had a suggestion to make commits and to make pull-requests, I'll try that.)

And where to discuss proposals? (E.g. I tried the forthcoming 1.0 version with a recent React.js -library and got some examples to work. What would you think about a new template 'snap init react' that has a couple of examples with source links to the official react-sources? Maybe later after 1.0 release?)

The tutorial claims that both MVars and IORefs are thread-safe, but IORefs are only thread-safe in very limited circumstances which require careful use of atomicModifyIORef and not more than one IORef. I'd recommend removing the bit about IORefs completely, as real applications with handlers accessing refs will almost always be better off with an MVar.

Currently tests are run with cabal-dev. Update this to cabal sandboxes.

The package fails to build with ghc 8.8.4 and is marked as broken on nixpkgs.
Specifically hashable, template-haskell and stm versions seem to prevent if from building.
I hope these versions can be relaxed so we can unbreak it for nixos users.
If there is nobody to look into this I can probably scrape up a PR myself.
Thanks!