smudge / freemail Goto Github PK

The currently released gem version 0.2.0 has different file permissions on the data file. Specifically, the disposable.txt is not world-readable:

-rw-r----- 1 user group  4695 Oct  4 17:04 disposable.txt
-rw-r--r-- 1 user group 50937 Oct  4 17:04 free.txt

This results in file access errors in our deployment environment since the actual application user is not allowed to read the file anymore after the gem was installed by a different user.

It would be great if you could release a new version (maybe even with the current state of the data :) ) which ensures that all the files are world-readable. For this, you probably need to change the file permission in your local checkout where build and push the gem.

As of version 0.5.0, get_domain method is implemented like this:

  def self.get_domain(email)
    email.split('@').last.downcase.strip
  end

However, it can return wrong domain or raise error for invalid inputs:

Freemail.get_domain('apple.com@') #=> "apple.com"
Freemail.get_domain('@') #=> undefined method `downcase' for nil:NilClass (NoMethodError)

It should raise ArgumentError:

Freemail.get_domain('apple.com@') #=> ArgumentError
Freemail.get_domain('@') #=> ArgumentError

Or probably should return empty value (or nil):

Freemail.get_domain('apple.com@') #=> ""
Freemail.get_domain('@') #=> ""

Hello dear maintainers,

First of all thanks for your work on this gem. Kudo!

I was looking at the domains list and probably the lists have been growing for the last 3 years.
I was wondering whether we could update it from time to time. For this I was thinking to this which provides frequently updated a list in different formats.

I would be glad to hear your opinion and, if needed, would be happy to contribute.