smilo-platform / smilo-api Goto Github PK

Steps to reproduce:

• Start the API like you normally would (with nodes running locally)
• Stop the API
• Start unit tests

You'll notice the unit tests fail with lots of weird assertions. Deleting the database and then running the tests again will clear these errors. It appears the database is not yet properly mocked?

The /status endpoint now always returns "ok". I think we can do more with this:

• Show connection status with each node
• Show last received block timestamp
• Show block height
• Show database stats (amount of transactions/blocks/addresses stored)

Basically any info which might help us detect problems while at the same time not exposing any sensitive information.

Data should be returned as JSON. In the future we might be able to use this endpoint to monitor the API :)

Two endpoints should be added:
/asset
/asset/<asset_id>

The first should return all known assets (XSM and XSP) in a list. The second should return detailed information about a specific asset.

For now these endpoints do not need to be backed by a database. The returned data should be hardcoded.

Returned data:

totalSupply = 200000000;
       name = “Smilo”;
       decimals = 0;
       symbol = “XSM”;

totalSupply = 200000000000000000000000000;
       name = “SmiloPay”;
       decimals = 18;
       symbol = “XSP”;

e.g. instead of accepting and sending Transaction objects we accept/send TransactionDTO objects.

The logic validating if a transaction is valid is very basic right now. We should extend this so it also covers at least:

• Signature validation
• Balance validation

Looking at the API it appears the BalanceController is no longer used (superseded by the AddressController).

The PriceController is a dummy right now and the StoredCoinService is not used (and will look very different in its final form). Since it might be a long time before we start using these wouldn't it be better to just remove them right now? Makes for a cleaner code base.

When a transaction is posted to the API currently a check is made to see if the account has enough balance. However this check does not include any pending transactions. The complete check should therefore be: balance + pending transactions.

When a transaction is invalid or rejected by the blockchain it will remain in the pending transaction list until the app is rebooted.

The core will get the field 'version' and 'extraData' soon. The API must be updated so it handles these fields correctly. Especially serializing/deserializing must handle this properly.

Update the readme with more detailed information.