smile-sa / elasticsuite-for-retailer Goto Github PK

Overview

The wrong header and footer is being displayed in the checkout when using the Smile_StoreDelivery module

Steps to replicate

1. Add any product to the cart.
2. Navigate to the checkout.

Expected Result

The isolated checkout header and footer content should be displayed at checkout.

Actual Result

The global header and footer content is displayed at checkout.

Solution

Remove layout="1column" from https://github.com/Smile-SA/magento2-module-store-delivery/blob/master/view/frontend/layout/checkout_index_index.xml so the page layout reverts back to checkout (as set in Magento_Catalog)

Hi,

when trying to install a new site on Magento 2.1.10, I am getting an exception

[RuntimeException]
  Source class "\Smile\Retailer\Ui\Component\Retailer\Form\Field" for "Smile\Retailer\Ui\Component\Retailer\Form\FieldMapper" generation does not exist.

When I clear var/generation and run the installation again, all works fine.

Would you have any ideas why this might be happening?

Thanks,

Lukas

store location is not accurate because
smile_retailer_address latitude longitude is FLOAT data type
Please change to DECIMAL(10,8) and DECIMAL(11,8)

Set up a tooltip in the Magento Back office in order to explain how to delete a slice slot.

i found that the problem is on schedule.js

because the str.replace will only replace the first occurrence so the locale variable will be changed from zh_Hans_CN to zh-Hans_CN but the correct locale should be zh-Hans-CN

Fix:
Changing the schedule.js like this to replace all occurrence in locale

On a EE 2.3.0 with 2 store views and web/url/use_store set to yes (to have URLs prefixed by the store code) - but I'm not sure it's relevant -, the URLs to the shop view page placed on the "Details" link are incorrectly built on the name of the retailer instead of its url key, leading to a 404 page.

Preconditions

Magento Version : EE 2.3.0

ElasticSuite for Retailer Version : 1.4.3

Environment : developer

Third party modules : none, only the requirement of smile/elasticsuite-for-retailer
See below

smile/elasticsuite                                          2.7.1    
smile/elasticsuite-for-retailer                             1.4.3    
smile/module-map                                            1.1.5    
smile/module-offer                                          1.3.3    
smile/module-retailer                                       1.2.4    
smile/module-retailer-offer                                 1.3.6    
smile/module-seller                                         1.2.4    
smile/module-store-delivery                                 1.1.2    
smile/module-store-locator                                  1.3.6

Steps to reproduce

1. Install an EE 2.3.0 + Luma
2. (not sure if relevant) Create an additional website / store group / store view (of code for instance "eu")
3. (not sure if relevant) Set web/url/use_store to 1/yes so URLs are prefixed by the store view code (ie default and eu)
4. Create an enabled Retailer with the following data
   Retailer name: Smile Asnières
   Seller code: asn
   URL Key: asn
5. In frontend of the default store view, to go to the retailer/shop search page /default/stores and look for the retailer and display the information popup
6. Hover and click on the Details link

Expected result

1. The link's URL is /default/stores/asn which leads to the shop information page

Actual result

1. The link's URL is /default/stores/smile-asnieres which leads to a 404 error page

Preconditions

During checkout I get the following error:
PHP Fatal error: Uncaught Error: Call to a member function setDiscounts() on array in vendor/magento/module-sales-rule/Model/Quote/Discount.php:122

Magento Version : Commerce 2.3.5-p1
ElasticSuite for Retailer Version : 2.0.0

Environment : Default

Third party modules : No, Magento Vanilla installation

Steps to reproduce

1. Create a retailer in the backend
2. Create a retailer offer in the backend
3. Add product to cart and proceed to checkout
4. Select retailer in checkout => Error in log file

Expected result

1. Checkout should be possible without errors

Actual result

1. Error in log file
   PHP Fatal error: Uncaught Error: Call to a member function setDiscounts() on array in vendor/magento/module-sales-rule/Model/Quote/Discount.php:122

New Custom attribute value not saving.

Preconditions

Magento Version : 2.4.2 E.E

ElasticSuite for Retailer Version : 1.2.9.1

Environment : Production

Third party modules :

Steps to reproduce

1. Create a Custom Attribute with Patch Data.
2. Save attribute value in retailers form.

Expected result

1. Create a Custom Attribute with Patch Data.
2. Save attribute value in retailers form.
3. That attribute should save value.

Actual result

1. [Screenshot, logs]
2. Create a Custom Attribute with Patch Data.
3. Save attribute value in retailers form.
4. That custom attribute didn't save value.

Attempting to install this module and get getting a fatal error that the signature for IsDiscount::getSearchQuery does not match the parent signature.

PHP Fatal error:  Declaration of Smile\RetailerOffer\Model\Rule\Condition\Product\SpecialAttribute\IsDiscount::getSearchQuery() must be compatible with Smile\ElasticsuiteCatalogRule\Model\Rule\Condition\Product\SpecialAttribute\IsDiscount::getSearchQuery(Smile\ElasticsuiteCatalogRule\Model\Rule\Condition\Product $condition) in /vendor/smile/module-retailer-offer/Model/Rule/Condition/Product/SpecialAttribute/IsDiscount.php on line 72

Preconditions

Using Magento 2.4 EE on Cloud.

Steps to reproduce

1. composer require smile/elasticsuite-for-retailer
2. git add . -A && git commit -am 'Added elasticsuite' && git pull && git push
3. ^^joined above lines with && for brevity. Naturally I do this as separate commands.

Expected result

1. Magento cloud runs upgrade and di compilation with no issues.

Actual result

1. Compilation error due to mismatching signatures.

Here we can see Smile\ElasticsuiteCatalogRule\Model\Rule\Condition\Product\SpecialAttribute\IsDiscount, the signature for the function getSearchQuery is: public function getSearchQuery(ProductCondition $condition).

Smile\RetailerOffer\Model\Rule\Condition\Product\SpecialAttribute\IsDiscount (that extends from the above) has the following signature: public function getSearchQuery()

It is observed that a user cannot place an order when shipping method selected is Store Pickup. After selecting "Store Pickup" as the shipping method on Shipping page and then navigating to Payment page, the shipping method is displayed as "undefined". The Store address is correct.

Preconditions

Magento Commerce Cloud 2.3.0
Smile_StoreLocator 1.2.2
Smile_StoreDelivery 1.2.0

Environment : Production
https://mcprod.bronsonsafety.com.au/

Third party modules : N/A. Can be reproduced on clean install of Magento EE 2.3.0

Steps to reproduce

Please refer to video link: https://youtu.be/LdMAt6aBok0

Expected result

1. Shipping method must be displayed on Payment page as per what was selected on Shipping page
2. User can place order as parameters are correct.

Actual result

1. Shipping method displayed on Payment page is "undefined".
2. User cannot place order as Order button is greyed out.

Add autocomplete by city, postcode and department.

In the Store details page, would it be possible to add the "click-to-call" feature on the phone number of the store ?

How-to explanations:
https://css-tricks.com/the-current-state-of-telephone-links/

I also tried to create clustered markers using Leaflet.markercluster plugin but page is still too slow on loading with around 4000 stores

checkout page throw Please specify a shipping method

The shipping method is too long and has underscore make magento cant recognize the shipping method when checkout

if i replace all smile_store_delivery with smilestoredelivery and problem is temp fixed but the name is still too long it may broke magento checkout

Preconditions

Magento Version : 2.1.9
Module Version : 1.3.0
Environment : Developer

Steps to reproduce

1. Create a retailer and copy this url_key.
2. Go to detail page : http://mymagento.local/stores/{url_key}

Expected result

1. Retailer informations (address, opening hour, ...)

Actual result

1. PHP Exception: Warning: Invalid argument supplied for foreach() in vendor/smile/module-store-locator/Model/Retailer/ScheduleManagement.php on line 128

How to reproduce
I'm trying to retreive the products from a virtual category via API.
The virtual category has been created on the "Only discounted products" criteria.

Problem
Following the recomandation found on this subject Smile-SA/elasticsuite#217.
I tried retrieving the products via the REST search API using the price.is_discount field but it doesn't work.

Reason
After diging I found that the index is made on an offer.is_discount field which is inconsistent with the field used in the Magento.

Solution
So the module needs to eather set the offer.is_discount as the field for "Only discounted products" or index on the price.is_discount field instead of the offer.is_discount.

Hi Smile Team

I saw that the Minimum version requirement for the module is 2.1.x. We just installed it on 2.2.3 and seems to work basically, but we get an exception in Checkout if you select a store
Could this be a compatibility problem? Are there any plans for M2.2 support?

Preconditions

Magento Version : M2.2.3

ElasticSuite for Retailer Version : 1.2.0

Environment : Production

Third party modules : Elasticsuite
'Dotdigitalgroup_Email' => 1,
'Magento_WishlistAnalytics' => 1,
'Mageplaza_Core' => 1,
'Mageplaza_LayeredNavigation' => 1,
'Nosto_Tagging' => 1,
'Shopial_Facebook' => 1,
'Smartwave_Core' => 1,
'Smartwave_Filterproducts' => 1,
'Smartwave_Megamenu' => 1,
'Smartwave_Porto' => 1,
'Smartwave_Socialfeeds' => 1,
'Smile_ElasticsuiteCore' => 1,
'Smile_ElasticsuiteCatalog' => 1,
'Smile_ElasticsuiteCatalogRule' => 1,
'Smile_ElasticsuiteCatalogOptimizer' => 1,
'Smile_ElasticsuiteSwatches' => 1,
'Smile_ElasticsuiteThesaurus' => 1,
'Smile_ElasticsuiteTracker' => 1,
'Smile_ElasticsuiteVirtualCategory' => 1,
'Smile_Map' => 1,
'Smile_Seller' => 1,
'Smile_Retailer' => 1,
'Smile_Offer' => 1,
'Smile_StoreLocator' => 1,
'Smile_StoreDelivery' => 1,
'Smile_RetailerOffer' => 1,
'Temando_Shipping' => 1,
'WeltPixel_Backend' => 1,
'WeltPixel_Quickview' => 1,

Steps to reproduce

1. Select a store in Checkout

Expected result

1. One should see the payment step

Actual result

following exception
[2018-09-05 14:22:51] main.CRITICAL: Report ID: webapi-5b8fe6bbd4296; Message: Property "RetailerId" does not have corresponding setter in class "Magento\Quote\Api\Data\AddressExtensionInterface". {"exception":"[object] (Exception(code: 0): Report ID: webapi-5b8fe6bbd4296; Message: Property "RetailerId" does not have corresponding setter in class "Magento\Quote\Api\Data\AddressExtensionInterface". at /var/www/html/vendor/magento/framework/Webapi/ErrorProcessor.php:205, LogicException(code: 0): Property "RetailerId" does not have corresponding setter in class "Magento\Quote\Api\Data\AddressExtensionInterface". at /var/www/html/vendor/magento/framework/Reflection/NameFinder.php:100)"} []

Retailer opening hours time slots are getting reset automatically. It shows differently in admin. When we resave retailer then the reset hours starts showing in frontend.

Preconditions

Magento Version : EE 2.4.2

ElasticSuite for Retailer Version : 1.2.9.1

Environment : Production

Third party modules :

Steps to reproduce

1. Create a Retailer.
2. After some time its opening hours time slot will get reset in admin but will show right on frontend.
3. If you resave that retailer again, wrong opening hours will start showing on frontend also.

Expected result

1. Opening hour time slot should not reset.

Actual result

1. [Screenshot, logs]