Git Product home page Git Product logo

Comments (3)

andrewpye avatar andrewpye commented on May 28, 2024

Currently the ember-polaris component properties that get passed to render-content is pretty low as we only added that quite recently. Over time we'll look at using render-content in those places that should support it, and we'll make sure we update the docs as we go. As such I'm not convinced there's any need to document render-content itself, since it's (currently) completely internal to ember-polaris's components. For that reason I'm going to close this, but feel free to reopen or comment further if you disagree! 👍

from ember-polaris.

sivakumar-kailasam avatar sivakumar-kailasam commented on May 28, 2024

I meant it as a document for contributors of the addon. Something like, here are some useful internals that you could use to improve/match the components in this repo to polaris' spec.

from ember-polaris.

andrewpye avatar andrewpye commented on May 28, 2024

Ah OK. Yes we could do that... another thought I've had is that render-content is pretty generic so it's a candidate for becoming its own addon (with its own documentation, of course 😉). Your suggestion is a nice idea for making this accessible to first-time contributors without having to go through a PR review to find out this stuff exists... will give it some more thought 👍

from ember-polaris.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.