polaris-select considers wrong item selected on initialisation about ember-polaris HOT 3 CLOSED

@tomnez thanks for investigating! I think we should definitely update to use value={{value}} instead of value={{selectedOption}} (that just seems like a small bug that slipped through). I've tested something like your suggested fix of passing selected explicitly on the option element and it seems to solve the problem. I'd say let's roll with that - I'd rather differ slightly from the React code and have the same functionality/lack of bugs, than match their code word-for-word 😉 The only thing I'd suggest would be to pass selected={{eq opt.value value}} since it seems slightly more prudent to match on the underlying values rather than on labels. I'll let you put a PR up to claim the glory for this one! 💪🔥

from ember-polaris.

@andrewpye I looked into this and can't really see any big difference in implementation other than us using value={{selectedOption}} instead of value={value} to set the value attr of the select tag. But changing to value={{value}} doesn't make a difference either.

I tried waiting until selectedOption was set to render the select field, but that didn't help (thought maybe it could be a weird render issue with setting value after render or something).

The only thing that seemed to work for me was explicitly adding a selected attr to the option tags:

<option
  selected={{eq selectedOption opt.label}}
  value={{opt.value}}
  disabled={{opt.disabled}}
  hidden={{opt.hidden}}
>

but that goes against the React implementation so I'm not sure if we want to do that. Thoughts?

from ember-polaris.

Closed in #245

from ember-polaris.