Comments (5)
@andrewpye let's keep items unchecked until they are merged, so when checked they are usable. Instead for the ones that are ready and just waiting for review link to the PR from that item
from ember-polaris.
@robinsharma I think we're going to need the Page component too right? I currently have a hopefully MVP of that sitting on a branch, I'll put a PR in for it shortly.
from ember-polaris.
@robinsharma I think the titles and text components are worth implementing where we need them, they're generally relatively quick and painless to put together. I've already got Display text, Heading and Subheading components merged down to master, and from a quick flick through the mockups it looks like we don't need any others. We already export the Polaris SASS from this addon so unless I'm missing something we should be good to go on the typography side of things, right?
A point here is that in browsing the code rendered by the React components, internally some of them use other React components. I've just put in a PR for the Card component and internally it uses the Heading and Subheading components. In cases like this when we need the functionality, I think it's worth implementing an MVP of whichever components are used internally by other components so that we don't build up tech debt.
from ember-polaris.
@vladucu good point, thanks!
from ember-polaris.
Closing this as we've built out everything we need at this point
from ember-polaris.
Related Issues (20)
- Update labelled component to v2.11.0 HOT 1
- Update page component to v2.11.0 HOT 1
- Update radio button component to v2.11.0 HOT 1
- Upgrade drop-zone component to v2.11.0
- Add Sticky component HOT 1
- Add Select component HOT 1
- Upgrade button-group component to v2.11.0
- Upgrade action-list/item component to v2.11.0
- Create new OptionList component HOT 1
- Refactor ActionList and sub components HOT 1
- Breadcrumb onAction handler gets passed click event object HOT 1
- polaris-select considers wrong item selected on initialisation HOT 3
- polaris-select selects first option as selected if null value is passed in HOT 7
- [DatePicker] Issues HOT 1
- Callout card illustration is missing alt text HOT 3
- Resource list filter creator does not update filter value selector type
- Dependency Dashboard
- How exactly to install and use? HOT 3
- Action Required: Fix Renovate Configuration
- Failed Install HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ember-polaris.