Git Product home page Git Product logo

Comments (5)

vladucu avatar vladucu commented on May 24, 2024 2

@andrewpye let's keep items unchecked until they are merged, so when checked they are usable. Instead for the ones that are ready and just waiting for review link to the PR from that item

from ember-polaris.

andrewpye avatar andrewpye commented on May 24, 2024

@robinsharma I think we're going to need the Page component too right? I currently have a hopefully MVP of that sitting on a branch, I'll put a PR in for it shortly.

from ember-polaris.

andrewpye avatar andrewpye commented on May 24, 2024

@robinsharma I think the titles and text components are worth implementing where we need them, they're generally relatively quick and painless to put together. I've already got Display text, Heading and Subheading components merged down to master, and from a quick flick through the mockups it looks like we don't need any others. We already export the Polaris SASS from this addon so unless I'm missing something we should be good to go on the typography side of things, right?

A point here is that in browsing the code rendered by the React components, internally some of them use other React components. I've just put in a PR for the Card component and internally it uses the Heading and Subheading components. In cases like this when we need the functionality, I think it's worth implementing an MVP of whichever components are used internally by other components so that we don't build up tech debt.

from ember-polaris.

andrewpye avatar andrewpye commented on May 24, 2024

@vladucu good point, thanks!

from ember-polaris.

andrewpye avatar andrewpye commented on May 24, 2024

Closing this as we've built out everything we need at this point

from ember-polaris.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.