Git Product home page Git Product logo

Comments (3)

joeljfischer avatar joeljfischer commented on July 19, 2024
  • Is the problem being addressed significant enough to warrant a change to SDL?

    Yes, I believe that the ability to play general audio files directly from the head unit, as in non-media / from the phone audio, is useful.

  • Does this proposal fit well with the feel and direction of SDL?

    I'm not sure. This proposal is to change TTSChunk but the proposal seems to imply that more than simply Text-to-Speech files will be played. I don't feel very good about having a struct named TTSChunk that plays generic, non-TTS files.

  • If you have used competitors with a similar feature, how do you feel that this proposal compares to those?

    N/A

  • How much effort did you put into your review? A glance, a quick reading, or an in-depth study? Please state explicitly whether you believe that the proposal should be accepted into SDL.

    I did an in-depth reading of this proposal and discussion with the author of the proposal. I think the ability to play audio files is warranted, but I would hesitate to accept this proposal without considering possible alternatives. I do not like that this is a generic "play audio" wrapped in a struct meant for Text-to-Speech. I do like that this requires so little changes to SDL and automatically fits with PerformAudioPassThru, Alert, etc.
    I give this a very hesitant yes.

from sdl_evolution.

joeljfischer avatar joeljfischer commented on July 19, 2024

This proposal was accepted. The committee feels it is a good feature to add to give apps some personality and to enable new features, and while the naming isn't ideal, it gives us the maximum amount of flexibility with the minimum extra development cost.

The implementation will have to be fleshed out on core to ensure backward compatibility.

from sdl_evolution.

theresalech avatar theresalech commented on July 19, 2024

Issues entered:
Android
Core
iOS
RPC Spec

from sdl_evolution.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.