sman591 / csh-drink-ios Goto Github PK

When visiting a machine's item list and at least one of the item names exceed the horizontal space provided, the name is cut off. But, upon scrolling the item out and back into view in the list, the title wraps correctly.

Such as:

Big Drink -> 4 drinks available
Little Drinks -> 3 drinks available

etc. somehow that's not obtrusive but still useful.

There are two reasons we disable items:

• User cannot afford item
• Item is unavailable

However:

• The first user-actionable (add money to your account) while the second isn't (only by a drink admin)
• Both are shown in the UI with pink text.

If the error is user-actionable, it should stay highlighted in pink, while if it isn't actionable, it should be gray like the rest of the text.

Maybe even let the user tap on the user-actionable items, just to see an info popup.

When a user drops a drink, the history table and user credits should be automatically updated. Technically, the machine should be reloaded for that slot in the event that drop was the last available from the slot.

Eg, if I dropped an item 1 minute ago and 10 minutes pass by, my screen should automatically say 11 minutes ago without any manual interaction/triggering.

Basic user info & ability to log out

Steps to reproduce:

1. Open app, login if needed
2. Go to the account screen
3. Sign out
4. Sign in again

Currently, it returns to the previous screen (account info), but it should really go to the machine list screen.

Replace with full can that isn't as tall as Jolt?

Steps to reproduce:

1. Select a machine
2. Swipe left on an enabled drink
3. Swipe that same row right, or tap out of the row
4. Attempt to repeat step 2. Will require two swipes to activate

Something like this, all in one table view. There's no need to drill down by machine.

Big Drink

• Coke
• Sprite
• ...

Little Drink

• Coke
• Sprite
• ...

Snack

• ...
• ...

For those items that don't yet have images

Lighten text color & prevent drink drops

As seen in e317a36, compiler optimization for final products had to be disabled in order to fix a bug where the app crashes at launch.

A possible workaround is to implement a different keychain wrapper.

Such as dropping an item, swiping to delay, checking credits.

Gecco

Looks like icons have changed slightly in shape, and there's also some missing ones in image assets.

Example: try to drop a disabled drink (first invalidate the item struct)

Example:

However, it doesn't always happen - if the title is a bit longer, it will wrap correctly.

Thanks @dag10

Simple GET /drops/status call: https://github.com/bencentra/WebDrink-2.0/blob/master/docs/API.md#drops

Possibly via a notification banner, or alert view.

Such as today, yesterday, this week, past month, past 3 months, greater than 3 months

Steps to reproduce:

1. Drop an item with a delay (eg 30 seconds), without dismissing the dialogue
2. Go to the home screen
3. Re-open the app

Currently, a alerts are closed & re-opened between the confirmation & dropping states, which is not ideal. It'd be best if the background remained and only the alert switched out, but will require a bit of re-working JSSAlertView.

Due to an apparent (bug?) in WebDrink's API, multiple items can be dropped for the cost of only one item if submitted during a delay. Example:

1. Drop an item with a 60 second delay
2. Continue to trigger item drops during those 60 seconds
3. Watch neither your history nor credits reflect the extra drinks

It's worth noting, this could be easily exploited via someone manually querying the API.

Maybe a 'Drop Latest Drink' or something.

New users won't know out of the box how to delay a drink drop unless they experiment with swiping on table cells or talking to someone else with the app.

Could just be a webview to drinkstats.csh.rit.edu

Seeing exact dates isn't fancy enough

Only show relative time for those within the last month, later than that just show a formatted date (Discourse style)

Would improve the authorization process by a lot. Implementable via deep links, probably could be compatible with the android app as well.

Goal behavior:

1. User opens iOS app for first time, is asked for API key
2. User taps on button that brings them to WebDrink
3. Authenticates with WebAuth if needed
4. WebDrink sends them back to the iOS app via a deep link that includes their API key
5. User is signed in

The app doesn't realize when it's API key has been invalidated.

Steps to reproduce:

1. Open drink app & log in
2. Open WebDrink, generate a new API key
3. Force-close & re-open the drink app

The user credits count will be 0, no drinks will be droppable, and the drop history will show everyone's history, not the logged in user's.

Never really got fastlane fully working. Goal:

• New commits/merges to develop trigger a build just to make sure it passes
• New commits/merges to master trigger a build and deploy a new version to the App Store if successful
• PRs get tested