Git Product home page Git Product logo

search's Issues

Replace SearchItem type into a generic type

Brief Description

Currently searchItems type, and search() function return type is SearchItem.
However, it could be great to add support to a generic type, to make the function return a custom type (extending from SearchItem).

If that's okay, I can make a PR myself.

Environment

  • @smakss/search version: 2.0.1
  • node.js version: v21.7.1
  • npm version: v10.5.0

Code Snippet

Here's an example of what it could be.

interface MyCustomType extends SearchItem {}

const items: MyCustomType[] = [{}, {}, {}] // …
const result: MyCustomType[] = search<MyCustomType>({ searchItems: items, searchText: '…' });

search function options shouldn't be a partial type from SearchOptions

Brief Description

Currently the options parameter of the search function is of type Partial<SearchOptions>.
All properties have a default value.
As searchItems and searchText are mandatory for the search, they shouldn't be optional.

The options type should be a type with keys, include, exact optional, and searchItems, searchText required.

If that's okay, I can make a PR myself.

Environment

  • @smakss/search version: 2.0.1
  • node.js version: v21.7.1
  • npm version: v10.5.0

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.