smajda / todo.txt-web Goto Github PK

When I go to the page after I have set up my config.php file with a user and password, it put in my user and password and press submit and nothing happens, I can't figure what is wrong.

Okay, so this is one of those places where "ls" is distinct from basically every other todo.sh command because it doesn't make any changes, and thus would, conceptually, be safe to bookmark. Even desirable -- there's a number of searches I do regularly and repeatedly that'd be sweet to have on the bookmark bar, e.g. "ls +work -@office" when working from home, that kind of thing.

But POST is used for everything. And it should be for all the ones that make changes, for obvious reasons. But... spitballing... perhaps special casing ls/list to be sent as a GET? (I guess technically that should include all the ls* variants, I just never use them...) Or is there a better way to get what I want, here? (The possibility of which is why I haven't just forked and started coding.) I'd be very happy to discover I'm missing something obvious. :-)

Since PHP 5.4, you are not allowed to overwrite 'superglobal' variables ($_POST is one such variable) according to stackoverflow.
As such doing any action on the website crashes it with error:

PHP Fatal error:  Cannot re-assign auto-global variable _POST in /includes/todo.php on line 4

Fixing this is trivial, as there is no reason to name first argument of get_cmd() "$_POST" any other variable name would work just fine.

I'll submit a pull request fixing this.

Hello, I was customizing todo.txt-web and ended up implementing color support for the browser.
It parses the ANSI escapes from CLI output using this nice script and converts them to css colors.

The only thing is that it will break for users with old config settings, so it can't be merged into master.
If you are interested, create a colorfull branch or something and I will submit a pull request there.