slimeknights / tinkersconstruct Goto Github PK

1.6.2, using Forge 817.
Having any TCon tools that have enchant glow on me causes enormous FPS lag.

They don't fill hunger though

http://pastebin.com/W3K9w3aJ

Recreation:
Hold a Tool Station in your active action slot and have a Part Builder somewhere in your action bar.

1. Select the Tool Station
2. Hold right-click. (The Tool Station will be placed and InvTweaks will move your Part Builder to the active action slot)
3. The game crashes.
   Images: http://imgur.com/a/YPu98

Tinkers' Construct v. 1.5.1_1.4.1.7

Situation:
I have been automatically casting ingots with a hopper underneath the assembly table, and a vanilla 5 torch pulser activating the drain to make ingots.

Whenever I unload the chunk and there is an ingot that has been poured completely, but not set, it freezes in this state and does not progress to the item as per normal.

This does not happen when the cast is not entirely filled, the smeltery will continue to fill the cast after being loaded again. Only for ingots that have been poured completely, but not set.

Potential fix:
The only fix that I can see is to break the casting table and place it down again. To prevent from happening a chunk loader will work.

Specifications:
SMP server running FTB Unleashed v1.0.3 using Tinkers Construct v1.4.1.7

The Power on the tool doesn't go down. It stays full so its always working and unbreakable.

I got this error after trying to switch into the search creative tab. Full log here: http://paste.ubuntu.com/5758075/

2013-06-12 08:39:08 [INFO] [STDERR] net.minecraft.util.ReportedException: Updating
screen events
2013-06-12 08:39:08 [INFO] [STDERR] at net.minecraft.client.Minecraft.func_71407_l(Minecraft.java:1507)
2013-06-12 08:39:08 [INFO] [STDERR] at net.minecraft.client.Minecraft.func_71411_J(Minecraft.java:835)
2013-06-12 08:39:08 [INFO] [STDERR] at net.minecraft.client.Minecraft.run(Minecraft.java:760)
2013-06-12 08:39:08 [INFO] [STDERR] at java.lang.Thread.run(Unknown Source)
2013-06-12 08:39:08 [INFO] [STDERR] Caused by: java.lang.NullPointerException
2013-06-12 08:39:08 [INFO] [STDERR] at mods.tinker.tconstruct.library.tools.ToolCore.func_77633_a(ToolCore.java:513)
2013-06-12 08:39:08 [INFO] [STDERR] at net.minecraft.client.gui.inventory.GuiContainerCreative.func_74228_j(GuiContainerCreative.java:360)
2013-06-12 08:39:08 [INFO] [STDERR] at net.minecraft.client.gui.inventory.GuiContainerCreative.func_74227_b(GuiContainerCreative.java:570)
2013-06-12 08:39:08 [INFO] [STDERR] at net.minecraft.client.gui.inventory.GuiContainerCreative.func_73879_b(GuiContainerCreative.java:471)
2013-06-12 08:39:08 [INFO] [STDERR] at net.minecraft.client.gui.GuiScreen.func_73867_d(SourceFile:131)
2013-06-12 08:39:08 [INFO] [STDERR] at net.minecraft.client.gui.inventory.GuiContainer.func_73867_d(GuiContainer.java:989)
2013-06-12 08:39:08 [INFO] [STDERR] at net.minecraft.client.gui.inventory.GuiContainerCreative.func_73867_d(GuiContainerCreative.java:589)
2013-06-12 08:39:08 [INFO] [STDERR] at net.minecraft.client.gui.GuiScreen.func_73862_m(SourceFile:111)
2013-06-12 08:39:08 [INFO] [STDERR] at net.minecraft.client.Minecraft.func_71407_l(Minecraft.java:1500)
2013-06-12 08:39:08 [INFO] [STDERR] ... 3 more

When you try to place any Buildcraft pipes with the drawbridge, it crashes the server when switched on, and continues to crash every time the server is restarted.

Crash log: http://pastebin.com/7x1mfELs

FML log: http://pastebin.com/T0GB69Ks

custom tools from Tinkers Construct 1.3.4.6 (FTB 152wgt) eider revert back to a wood tool or a rainbow colored square when its placed in a chest, go to creative mode or re log.
if you use the tool it crash the game http://pastebin.com/tnegewwg
tested clean install on 2. computer all fine with no mcpc both single and server.
also confirmed it happens on clean with mcpc

posted this on mcpc plus also.
reff MinecraftPortCentral/Cauldron#1193

Hello everyone.

Did you know? Some tools can be eaten! Wait what?

Yes, it appears that chisels can be eaten. Right clicking with a chisel of any kind in your hand seems to play the sound that is played when eating food, and the item bounces in your hand, just as it would if you were eating an apple or beef.

The tool is not consumed, and it does not seem to be giving any hunger points.

I am no expert, but my best guess is the problem has to do with the onEaten part of the chisel.java class under onItemRightClick.

 @Override
    public ItemStack onItemRightClick (ItemStack stack, World world, EntityPlayer entityplayer)
    {
        if (entityplayer.capabilities.isCreativeMode)
        {
            onEaten(stack, world, entityplayer); // I think this is the source of the problem
        }
        else
        {
            NBTTagCompound tags = stack.getTagCompound().getCompoundTag("InfiTool");
            if (!tags.getBoolean("Broken"))
                entityplayer.setItemInUse(stack, getMaxItemUseDuration(stack));
        }
        return stack;
    }

Should note that the bug only works in survival and adventure mode. In creative there is no problem. (Unless you are looking at a block, then the item just jumps around and freaks out.)

The if is creative mode thing is throwing me off, as you would think that means if the player is in creative mode, then bla bla bla bugs bla bla bla. But instead there is no problem is creative.

http://pastebin.com/b3zpbcJH

http://puu.sh/3OsFb.png

With both Galacticraft and TConstuct installed, this is what appears for a survival inventory. Also, if the Galacticraft tab is clicked, the Vanilla and TConstruct tabs disappear and cannot be clicked. (See Picture1)

And the same goes for if TConstruct is clicked, except Galacticraft is hidden, instead. (See Picture2)

Picture1: http://puu.sh/3OsVf.png
Picture2: http://puu.sh/3OsQT.png

Also, when the game is resized - for example; Maximised from a window, the tabs disappear when the vanilla inventory is selected.

Probably not the intended action, but also probably not a high fix.

Minecraft 1.6 With TConstruct 1.4.dev23, Galacticraft & MicDoodle Core 548

md-5 told:

Can't support every mod out there. Bug the mod author to use Packet250

Would this be possible ?

If a stone torch is placed on the underside of a block when there is an adjacent block, the torch will float in midair, as if there is a block underneath it, even though there isn't.
http://imgur.com/cSylAuC

I was watching a live stream when this thought popped into my head. Would you be opposed to adding a Smeltery recipe for sand so you can then make Glass Panes/Blocks but with the standard ore doubling concept in mind and maybe make a glass ingot to add something to TC tools like a water tank to pick up lava as obsidian?

I believe this to be a bug.
If I try and select the next pattern button it stays as an ingot cast and when I click previous pattern, same result.
Also when I placed the cast into the stencil table I could remove it and replace it with a regular pattern (made from wood and sticks)
This also happens with any other items.
BUT
to replace the cast with the other item you must not remove it you must only pick up the other item and then click to swap items with the cast
I discovered this bug on my server and recreated this in single player
I hope this helps towards the future of Tinker's Construct

Just a tiny suggestion, obviously nothing major, but I'm sure would add to realism. Since liquid metals irl emit light, it would stand to reason that the liquid metals in the smeltery(and in transit via pipes and what not) also emit light. This is something that could simply be patched in by using the existing lighting mechanics used by lava.

AFAIK, TConstruct has IC2 integration for now. Would be nice to have support for BuildCraft/ThermalExpansion (the latter one has analog of charging bench since 2.4.1) and UniversalElectricity.

TC logs all the UIDs it creates, leading to the log file becoming very large: https://gist.github.com/ft975/7321d4879395ec92dddd
While this is not a huge issue on singleplayer, I expect it to be a much larger issue on servers where there are many players, leading to a larger log file.

A tool, while being enhanced with lapis, has a chance to obtain a level of luck of superior level before the hardcoded threshold.

IF it does, and you keep upgrading it it will lose its additional level.

Example:
You put 110 lapis into the tool, and by luck you get Fortune 2.
You add another piece of lapis to continue upgrading it, but it reverts back to Fortune 1.

This may be intended, but i think an additional check would be needed so if you got lucky with the early-upgrade you dont lose it.

Pastebin to Crash log: http://pastebin.com/fcxFVHk4

Repro information:
This crash occurred after some possible Railcraft interference on Forgecraft 2. Fell in the smeltery while it was attempting to cook some copper ingots, broke out way out. Ingots would not complete smelting. Removed ingots from the smeltery, and then accidentally shift clicked sand into the smeltery. Attempted to shift click the sand out via reflex, crash occurred.

I have seen instances of genned gravel ore floating above snow cover in wintry biomes. I'll try to post a fix in SurfaceOreGen tonight--but I am at work right now and I thought I'd post here in case you happened to be in that part of the code before I got to it.

A more drastic fix would be to move gravel ore gen to before snow gen using terrain events so that snow would properly cover the genned gravel--and the gravel placement code would be a bit simpler.

If the latter is your preference, I'd be happy to post that fix...just lemme know.

Currently, README.md says "alternate licenses are noted where appropriate", meaning that the entire source code must be read in order to determine what is and is not allowed with regards to the code as a whole. Information about alternate licenses should be duplicated in the readme or a COPYING file or similar.

I've been luring in the code for a while I can't seem to find where you define the how much each of the specific cast will cost (in ingot value or similar). I've searched the code for a while, and my best guess it's that's it is defined in TContent in addCraftingRecipes(), but I couldn't find the actual costs in there.

I wanted to change some stuff and learn how to create some new casts to create an addon.

PS: Sorry for creating an issue, but there's no other way to communicate in GH =/

When you right-click + charge with the battleaxe, once the effects wear off you can't walk up slabs of anykind. Chests that are submerged into the ground you have to jump off you can't walk off them. And it effects BoP puddles as well. If you relog it fixes the issue. Also can't walk upstairs.

FTB Unleashed pack 1.0.3
TConstruct_1.4.1.5

java.lang.NullPointerException
at mods.tinker.tconstruct.items.tools.LumberAxe.onBlockStartBreak(LumberAxe.java:151)
at net.minecraft.client.multiplayer.PlayerControllerMP.func_78751_a(PlayerControllerMP.java:132)
at net.minecraft.client.multiplayer.PlayerControllerMP.func_78744_a(PlayerControllerMP.java:81)
at net.minecraft.client.multiplayer.PlayerControllerMP.func_78743_b(PlayerControllerMP.java:193)
at net.minecraft.client.Minecraft.func_71402_c(Minecraft.java:1309)
at net.minecraft.client.Minecraft.func_71407_l(Minecraft.java:1795)
at net.minecraft.client.Minecraft.func_71411_J(Minecraft.java:835)
at net.minecraft.client.Minecraft.run(Minecraft.java:760)
at java.lang.Thread.run(Unknown Source)

Mods: FTB Unleashed 1.1.3 + Tubestuff
Affected Versions: TinkersConstruct 1.4.2.1

Using the hammer on railcraft blast furnace bricks (the furnace was not even formed into multiblock yet) breaks the standar 3x3x1 area but yields no blocks.

Im using the 152ngt FTB pack v0.8.

I made a full stone hammer. The bug i have found is that you can mine certain blocks that should not be able to.as long as the block next to it is stone.

For instance i can mine Thermal Expansion ores if you mine the stone next to it. Mining the actual block works as intended (not being able to). Normal vanilla ores it will not mine this way.

Not sure if other mod ores are the same as i'm running FTB with Thermal Expansion ore distro.

Had a Manyullyn Cleaver (Manyullyn blade/plate, paper rods) with 3 levels of sharpness and beheading. Unleashed 1.0.3

Sometimes when using a hammer on silver or tin (could happen on other ores too) the block breaking particles will show orange pieces (the copper ore ones).

This issue is very minor of course, and could be TE related, but only noticed them with the hammer.

Im using 152wgt v0.8

Moves harvested items and loot from killed mobs directly to player's inventory

I am not 100% sure on this but when using an alumite pickaxe (paper binding, obsidion rod) with Haste (100/100) Lapis (41/450) and Electric
While it's charged with EU the mining speed is Considerably slower than when the EU runs out.

Extra details:

I am using the Feed the beast Modpack - 1.5.2 ngt 0.7 which includes Tinkers Construct - 1.3.6.3 (TConstruct_1.3.6.3.jar)

Optifine is causing missing textures in the TC books, I'm using 1.5.2. The first book that you spawn with, when i open the book, the crafting table on the first page is a missing texture, along with some of the other blocks thought out the book. One page has a white 3 in the place of a block that you can craft. I am using all the current versions of Optifine Ultra and Tinkers Construct.

Hello.
I have 31999 item ID problem after updating TConstruct from 1.3.4.5 to 1.3.6.7.
Running MCPC+ with forge 738 - server adds this ID and client doesnt. There is no config option for that.
What I'm doing wrong?

Server Log - https://dl.dropboxusercontent.com/u/26284017/Minecraft/ErrorLogs/ForgeModLoader-server-0.log
Client Log - https://dl.dropboxusercontent.com/u/26284017/Minecraft/ErrorLogs/ForgeModLoader-client-0.log

I have written up code for connected textures for Clear Glass, Clear Soul Glass and Stained Glass. The source and textures can be downloaded here: https://www.dropbox.com/s/5nezbnjrrbgkv5i/ConnectedTextures%20pack.zip .

The source needs to be merged with TC code, since I don't have a cloned copy of TC locally available, this is the reason why I didn't submit a PR.

Edit: Also includes something like an API for connected textures making it not take much time at all to add a connected textures block(except for textures).

I tried to place tool dynamism with a drawbridge and minecraft crashed.

So I like the IDEA of Nitro Creepers and i was wondering if you've thought of making Creepers for the end that can teleport.

due to placing berries in inventory at click on berry bush the golem is eating item, when as suppose to drop it on ground, i suggest check if EntityPlayer what case event is a player and if it is place item stack into inventory, otherwise drop item on ground .

Given the relatively slow/uncertain nature of IC2 updates and the very active state of Mekanism and other UE mods, it'd be really awesome if we could still have "electric" modifiers for your tools even if IC2 isn't installed but Universal Electricity is.

The actual integration is trivial. It's more a question of if you'd like to do it. It'd probably make sens to use a Mekanism "Energy Tablet" as the modifier component (basically no one uses Universal Electricity without Mekanism, and Mekanism is by far the most active mod in the set).

if you throw a knife in a ceiling its stuck there, and with normal physics it would fall down. http://i.imgur.com/G9wBdLj.png

it will be nice if stone golem could move casted items from smeltery, now it move only cast itself .

I am unable to interact with the part builder automatically by any means, including direct-inventory-access blocks like Inventory Turtles and Factorization Routers. Would it be feasible to allow automated interaction with the part builder, as such operations are already possible with the smeltery? For example, you could insert a pattern on the top side and the materials on the bottom, and extract the results out the side.

I cloned Tinker's Construct and paired it up with forge, but now there's something I don't understand...
you prevent the food stats from resetting by saving the stats, but it seems that those fields are "protected" and therefore not visible.
I can't really figure out what to do to fix it...

When I hold a TC bow in my hand, I get 15 FPS out of my normal 32 FPS. It drops to 7 FPS when I draw back the bow. I have tried this with the darkwood bow, bloodwood bow, manyllium bow, cobalt, and the alumite bow. As I have heard, giving yourself certain tools won't work because it's missing some data. So I gave myself 2 Manyllium tool rods, and a bow string and crafted one and FPS dropped to 15 again.

PS. This is tested on the Hexit modpack. I also know that bows are still really new. Btw, great work!

It's strange because all other gravel ores can be pulverized with no issues.

This issue has been reported on the Galacticraft repository, however micdoodle (the author) hasn't seemed to take interest in resolving the conflict quite yet. In case you don't know what the issue is, it seems that Galacticraft uses its own custom inventory screen and due to the fact that it's a coremod, it is loaded before Tinkers Construct and the game uses its GUI over Tinkers' GUI. This results in, for example, the backpack tab to disappear/not show up.

You promised everyone you'd do it!

Could you add support for the use of different kinds of metal nuggets?

You can eat your chisel. Though it is tasty, it's not very nutritious. it fills 0 hunger bars.

I have tried this with an all iron chisel, and a all manylliun chisel with moss, diamond, and emerald modifiers.