slimefun-addon-community / mobcapturer Goto Github PK

when trying to get piglin in the nether it generates this error in the console and only gives damage, in the world world it works normally, in the nether it does not

error piglin nether: https://mclo.gs/eSWWsNR

Paper git-Paper-130 (MC: 1.19.2)
Slimefun DEV - 1027 (git 96c873bd)
Metrics-Module #28
Java 18
Installed Addons: (17)
Networks vDEV - 44 (git 2e7bc54c)
DyedBackpacks vDEV - 17 (git 8b329e96)
ExtraTools vDEV - 36 (git 922c0324)
EcoPower vDEV - 5 (git 5c1ecd68)
HotbarPets vDEV - 38 (git fa6c871d)
DynaTech vDEV - 166 (git 92c8d415)
HeadLimiter v23
ExoticGarden vDEV - 78 (git 7f9a5f63)
Liquid vDEV - 14 (git 0f5346bf)
Supreme vDEV - 9 (git efe13820)
InfinityExpansion vDEV - 140 (git 0098d2fb)
LiteXpansion vDEV - 180 (git d574b154)
VillagerUtil vDEV - 1 (git 0a949b19)
MobCapturer vDEV - 18 (git df36d23)
FlowerPower vDEV - 14 (git 63a37cc0)
SimpleStorage vDEV - 10 (git ea5e5637)
FluffyMachines vDEV - 121 (git efca037f)

Description (Required)

Mob capture works on protected areas if I don't have permission to area.
I tested with WorlGuard but maybe mob capture works on protected PlotSquared plot, protected Griefprevention claim, and protected Bentobox island.

Steps to reproduce the Issue (Required)

1. Use Mob capturing cannon to steal mobs from protected areas.

https://www.youtube.com/watch?v=zwYwumaqaj4

Expected behavior (Required)

Mob capture not work on protected areas if I don't have permission to area.

Environment (Required)

Yatopia git-Yatopia-"f8c5c21" (MC: 1.16.5)
Slimefun DEV - 816 (git d3f4ca47)
Metrics-Module #21
Java 11

Installed Addons: (2)
RestrictedCreative v2.4.6
MobCapturer vDEV - 15 (git a42c9e0)

Description (Required)

When using the mob cannon and pellets, it just acts like throwing snowballs at the mob. It does not capture the mobs like it should. I have tried various mobs with the same result. It does give an error in the console (see below).

Steps to reproduce the Issue (Required)

Use the Mob Cannon and empty pellet. Try to capture a mob.

Expected behavior (Required)

I expect mobs to be captured.

Server Log / Error Report

https://pastebin.com/4zW1BScC

Environment (Required)

sf versions
[08:07:23 INFO]: This Server uses the following setup of Slimefun:
[08:07:23 INFO]: Paper v1_15_R1
[08:07:23 INFO]: CS-CoreLib vDEV - 90 (git 9dd4a1cf)
[08:07:23 INFO]: Slimefun vDEV - 720 (git 42f849d8)
[08:07:23 INFO]: Metrics build: #14
[08:07:23 INFO]:
[08:07:23 INFO]: Installed Addons: (1)
[08:07:23 INFO]: MobCapturer vDEV - 10 (git 33cdceb)

when you shoot a zombie with a cannon (all zombie types), it doesn't give you the egg

action to reproduce the error

when you shoot a mob, drop an egg with that same mob

Log

Versions

well I found a bug in the Bloodmoon Advanced and MobCapturer plugins

server and addons slimefun: https://prnt.sc/jmkljEFnfNgj
plugin Bloodmoon Advanced version: 4.5.3

video: https://www.youtube.com/watch?v=MQNuvas72q8

in Bloodmoon the monsters don't let the armor drop, but if I capture them, and release and kill the armor drop, making me get many armors and tools from the monsters
is there a way for mobcapture not to capture these blood moon monsters, or at least detect that it is a blood moon monster when released and be deleted?
People are abusing this and taking lots of armor.

Expected behavior: Placing a mob in an egg on a block should place the mob centered on that block.

Actual behavior: Placing the mob in an egg on a block spawns the mob at the corner of that block. This regularly causes the mob to suffocate when attempting to place them inside confined spaces.

Since Slimefun requires 1.16 now, maybe it is time to let MobCapturer build against Java 16 as well.

Description (Required)

MobCapturer Build #9 Doesn't Load whilst using Slimefun Dev Build 593

Steps to reproduce the Issue (Required)

Use Slimefun Dev Buid #593
Use MobCapturer Dev #9

Expected behavior (Required)

Load MobCapturer successfully whilst using the latest dev builds

Server Log / Error Report

https://pastebin.com/0z5p2i6M

Environment (Required)

Building a zoo on a survival world and fox are injured by the capture eggs, not captured. Holds true for all fox (red and snowy).

We can capture Panda and polar bears, so it's not just the age of the mob in the game.

Description (Required)

Endermen cannot be captured with the launcher.

Steps to reproduce the Issue (Required)

Attempt to capture an Enderman. It dodges the projectile and remains uncaptured.

Expected behavior (Required)

I expected to be able to capture all types of mobs with the launcher.

Since there is no egg for Endermen, I assume this is intentional, but special behavior may be needed to ensure the Enderman does not dodge the projectile.

https://prnt.sc/xkayld
happens since i turned on essentials jail

Expected behavior (Required)

for it still to work

Server Log / Error Report

https://pastebin.com/BAuXYBFH

Environment (Required)

https://prnt.sc/xkb129->

• Minecraft Version:
  https://prnt.sc/xkb129
  https://prnt.sc/xkb1s4

Reproduction:

• Capture some wild sheep. Note that the eggs do not stack.
• Place the sheep and breed them. Note that the eggs from the bred sheep DO stack.

I have diagnosed that this is due to the that fact that the floating value "Random spawn bonus" is stored on mob eggs from wild entities, when it does not exist on bred mobs.

This could be fixed by excluding the attribute when capturing mobs.

Withers, Wardens, and Ender Dragons cannot be captured with the launcher.

I assume this is intentional, but I think that all mobs should have capturing code in place, and the ability to capture these mobs should be simply disabled by default.

Checklist

• You are using official version downloaded from Builds (https://thebusybiscuit.github.io/builds/)
• You did not modify the jar file
• You searched existing issues, and could not find any existing bug report on this

Description

As discussed on Discord, when applying a custom texture pack with item-models.yml, the category items for both mobcapturer and tools do not display their designated textures and instead display the default textures.

Reproduction Steps

1. Change the item-model.yml and use any custom resource pack that has textures for all the items
2. restart the server
3. Textures don't apply.

Expected Behavior

The custom textures apply to both the mob capturer and items category items

Server log

No response

Error report

No response

Server Software

Purpur

Minecraft Version

1.20.x

Slimefun version

Plugin version

vDEV - 91 (git 085b1a8)

When capturing a Zombie Villager, the villager is reset to Novice and loses any trades it previously had.

Description (Required)

When using the mob cannon, you cannot capture a mob. You get an error in console (see below) when you hit one with the pellet. There is no error for just using the cannon without hitting a mob. I am trying to find out from which update this started (Paper/Slimefun/MobCapturer), but figured I would put this in here while I look for more info to help you out.

Steps to reproduce the Issue (Required)

Get a mob cannon and empty pellet.
Shoot a mob that can be captured.

Expected behavior (Required)

Expected to capture a mob when shooting the pellet at the mob from the cannon.

Server Log / Error Report

https://pastebin.com/eAQEnT6Q

Environment (Required)

sf versions
[13:49:57 INFO]: This Server uses the following setup of Slimefun:
[13:49:57 INFO]: Paper git-Paper-406 (MC: 1.16.4)
[13:49:57 INFO]: CS-CoreLib vDEV - 92 (git e9150d72)
[13:49:57 INFO]: Slimefun vDEV - 780 (git bc8d72b9)
[13:49:57 INFO]: Metrics build: #6
[13:49:57 INFO]:
[13:49:57 INFO]: Installed Addons: (1)
[13:49:57 INFO]: MobCapturer vDEV - 12 (git 4f65d33)

Villagers cannot be captured with the launcher.

This is significant, as they are one of the most important and frustrating mobs to transport around the player's world.

This will require an adapter to ensure their trades, experience, and reputation are retained when captured.

https://github.com/TheBusyBiscuit/MobCapturer/blob/ef565ca6bdddf944e0aa7812d88db163b7f23d1e/src/main/java/io/github/thebusybiscuit/mobcapturer/items/MobCannon.java#L34-L38

This issue was generated by todo based on a TODO comment in ef565ca. It's been assigned to @TheBusyBiscuit because they committed the code.