prj-rev-bwfs-tea-cozy's People
Contributors
Watchers
prj-rev-bwfs-tea-cozy's Issues
SUMMARY
Summary Grade: Satisfactory
Good job with your code! I really liked the way you clearly organized your html code with whitespace and indentations. It makes your code really easy to navigate and read. Also, I really like the way you used classes and ids to group your sections together. As your code grows in size, this will help organize and manage your website. Excellent start to the Ready program!
I included a few notes in both the html and css files for you to think more critically about. You can find these comments in the issues tab of your github. The most important thing is to add mobile resizing. I know that it can be tedious, but you should try to add mobile resizing so you control how your website looks even on different mobile screens. Some suggestions would be to decrease the size of the images when the screen size decreases or rearrange the layout of the text and images so you don’t have to scroll horizontally to read everything.
Add mobile resizing
In the future, try to incorporate mobile resizing. Though it may seem tedious, it is an incredibly important concept since screen sizes vary tremendously today and it’s important that you website looks exactly as you design it to. Check out this site for more information about it https://developer.mozilla.org/en-US/docs/Web/CSS/Media_Queries
https://github.com/Salpal14/prj-rev-bwfs-tea-cozy/blob/master/Tea_Cozy/resources/css/style.css#L1
Great use of divs and ids to group code
Great decisions on the classes and ids name. It makes it very clear what its purpose is and makes grouping your sections very effective. These organizational skills come in handy as you expand your code since you can modify entire sections at once. You also chose very clear and concise names for them. It pays off to spend time thinking of good names for classes, ids, and variables.
https://github.com/Salpal14/prj-rev-bwfs-tea-cozy/blob/master/Tea_Cozy/index.html#L64
Consider using proper html copyright symbol
Just know of the existence of the html copyright sign, which is © You can find all of special characters for html here https://www.ascii.cl/htmlcodes.htm
https://github.com/Salpal14/prj-rev-bwfs-tea-cozy/blob/master/Tea_Cozy/index.html#L101
Add favicon to browser header
Don't forget to put a favicon! This is the small icon on your browser tab. You can add <link rel="icon" href="http://example.com/favicon.png"> to you <head> element. It’s a small detail but helps your website look more complete!
https://github.com/Salpal14/prj-rev-bwfs-tea-cozy/blob/master/Tea_Cozy/index.html#L3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.