The vetclinic from slamaio

vetclinic's People

Contributors

Watchers

vetclinic's Issues

TimeSpan

VetClinic/VetClinic/TimeSpan.cs

Lines 7 to 8 in e1dafe8

 Month = 30, 

 Year = 365

Is all monthes have 30 days? and is all years have 365?

Let`s have just method, that will calculate date, that you need from date in paramethers and TimeSpan enum value

Bad practice

VetClinic/VetClinic/AnimalInfo.cs

Lines 21 to 26 in e1dafe8

 if (_lastVisit == null) 

 throw new Exception("Try AddVisit() instead."); 

 if (_lastVisit >= date) 

 throw new Exception("Try AddVisit() instead."); 

 if (VisitRecord[(DateTime)_lastVisit] != null) 

 throw new Exception("Try AddVisit() instead.");

VetClinic/VetClinic/AnimalInfo.cs

Lines 12 to 13 in e1dafe8

 if (_lastVisit != null && VisitRecord[(DateTime)_lastVisit] == null) 

 throw new Exception("Try AddDischarge() instead.");

i have some variants how to make this better:

make bool as return type, that says if we choosed correct method
just call another method
merge methods
throw different types of Exceptions of messages in them. It`s normal to have try {} catch in external code, but we want to know, what exactly gone wrong

Recommend Projects

React

A declarative, efficient, and flexible JavaScript library for building user interfaces.

Vue.js

🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

Typescript

TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

TensorFlow

An Open Source Machine Learning Framework for Everyone

Django

The Web framework for perfectionists with deadlines.

Laravel

A PHP framework for web artisans

D3

Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

javascript

JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

web

Some thing interesting about web. New door for the world.

server

A server is a program made to process requests and deliver data to clients.

Machine learning

Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

Visualization

Some thing interesting about visualization, use data art

Game

Some thing interesting about game, make everyone happy.

Recommend Org

Facebook

We are working to build community through open source technology. NB: members must have two-factor auth.

Microsoft

Open source projects and samples from Microsoft.

Google

Google ❤️ Open Source for everyone.

Alibaba

Alibaba Open Source for everyone

D3

Data-Driven Documents codes.

Tencent

China tencent open source team.

	if (_lastVisit == null)
	throw new Exception("Try AddVisit() instead.");
	if (_lastVisit >= date)
	throw new Exception("Try AddVisit() instead.");
	if (VisitRecord[(DateTime)_lastVisit] != null)
	throw new Exception("Try AddVisit() instead.");

	if (_lastVisit != null && VisitRecord[(DateTime)_lastVisit] == null)
	throw new Exception("Try AddDischarge() instead.");

slamaio / vetclinic Goto Github PK