There is "hello:someone" logs which don't match with the calling context. Probably forgot to modify on copy.

Using the method to save subscription would always lead to the follow error:

Error Domain=SKYOperationErrorDomain Code=108 "The server is unable to process the data." UserInfo={SKYErrorName=InvalidArgument, SKYErrorMessage=empty device_id, NSErrorFailingURLKey=http://127.0.0.1:3000/subscription/save, SKYOperationErrorHTTPStatusCodeKey=400, arguments=<CFArray 0x79889ba0 [0x56181f8]>{type = immutable, count = 1, values = (
    0 : <CFString 0x798810f0 [0x56181f8]>{contents = "device_id"}
)}, NSLocalizedDescription=The server is unable to process the data.}

skygear-server now requires subscription:save to supply device_id, but saveSubscription:completionHandler: didn't, leading to this error.

The following api should be exposed in container (or relation container), and can be called directly.

• queryFriend
• queryFollower
• queryFollowing
• addRelation
• removeRelation

They are now existing as SKYAddRelationsOperation, SKYRemoveRelationsOperation and SKYQueryOperation+QueryUser in the sdk.

I am suggesting that we persist current user information in SKYContainer. While the whoami action solves the problem for the client to find out the current user, asking the server each time the client want to figure out the username seems excessive.

The swift example app have this problem and it workaround this problem by storing the username outside of SKYContainer.

In current implementation, accessControl.setNoAccessForUser(userID) and accessControl.setNoAccessForRole(someRole) does not deny the access of specific user / role. What it actually does is remove the access control entry for specific user / role.

As in JS: https://docs.skygear.io/js/guide/pubsub

It will be helpful for developer to take appropriate action for alert the user or recover message during the disconnect.

connect SkygearIO/features#5

• -[SKYContainer loginWithFacebook:(NSDictionary*)options] and
• -[SKYContainer loginWithGoogle:(NSDictionary*)options]
  • options
    • uxMode - Either popup(default), or redirect, popup means in-app-browser (SFSafariViewController/WKWebView) and redirect means Safari.app
    • clientID
    • scope
    • version - FB Client SDK only
    • cookiePolicy - Google Client SDK only
    • use3rdPartyClient - whether to use 3rd party client, e.g. Facebook iOS SDK. Default false
  • Returns the user logged in via delegate.

refs https://developer.apple.com/videos/play/wwdc2015/401/

refs SkygearIO/skygear-server#262

SkygearIO/skygear-server#54

lambda:

• user:forgot-password
  • email
• user:reset-password
  • user_id
  • code
  • expire_at
  • new_password

FYI: https://github.com/SkygearIO/skygear-SDK-iOS/blob/master/Pod/Classes/Operations/SKYLambdaOperation.m#L59

Version: v0.19.0

Exception:
'NSInvalidArgumentException', reason: '*** setObjectForKey: object cannot be nil (key: asset)'

Note:

• the query has assets

Tasks:

• Convert Swift example to use Swift 3 syntax
• Add nullability annotation to Objective-C interfaces

connect SkygearIO/features#5

• -[SKYContainer loginWithOAuthProvider:(NSString*)providerID, options:(NSDictionary*)options completion:(void(^)(NSError*, SKYUser*))]
  • Create or login a new skygear user, associated with the provider
  • providerID - A string that identify the login provider
    • We will provide com.facebook, com.google
  • options
    • uxMode - Either popup(default), or redirect, popup means in-app-browser (SFSafariViewController/WKWebView) and redirect means Safari.app
    • clientID
    • scope
    • version - FB Client SDK only
    • cookiePolicy - Google Client SDK only
  • This function returns a skygear user, and an access token of the service, via a delegate.
• -[SKYContainer loginWithOAuthProvider:(NSString*)providerID, accessToken:(NSString*)accessToken completion:(void(^)(NSError*, SKYUser*))]
  • accessToken - Client calls this API if it already has an access token, skygear will try to login directly instead of going through the OAuth flow.
• -[SKYContainer associateAccountWithProvider:(NSString*)providerID options:(NSDictionary*)options completion:(void(^)(NSError*, SKYUser*))]
  • Add a new auth provider to the user by going through the auth flow
  • providerID - A string that identify the login provider
  • options
    • uxMode - Either popup(default), or redirect, popup means in-app-browser (SFSafariViewController/WKWebView) and redirect means Safari.app
    • clientID
    • scope
    • version - FB Client SDK only
    • cookiePolicy - Google Client SDK only
  • This function returns a skygear user, and an access token of the new service, via delegate.
• -[SKYContainer getOAuthTokensWithCompletion:(void(^)(NSError*, NSDictionary*))]

  • Return tokens

    [container getOAuthTokensWithCompletion:^(NSDictionary *tokens){
      //tokens['com.facebook'] is FB's access token
    }];
    

In the following lambda,

def handle_delete_conversation_lambda(conversation_id):
    __validate_user_is_admin(conversation_id)
     conversation = Conversation.fetch_one(conversation_id)
     handle_admins_lambda(conversation_id, conversation['admin_ids'], False)
     handle_remove_participants(conversation_id,
     conversation['participant_ids'])

the response is

{"result": null}

However, SKYLambdaOperation throws an error.

The expected result should be returning nil.

Re-open it from oursky/skygear-SDK-iOS#260

-[SKYNotification subscriptionID] is put inside a private header, it would be useful if we can get the subscription id from a notification.

We actually need it here: oursky/ufo#848

feature: SkygearIO/features#48
server issue: SkygearIO/skygear-server#393

• add signup(authData, password, [profile])
• add login(authData, password)
• update current signWithXXX and loginWithXXX to call new server api
• return User record in signup, login and whoami response
• remove APIs that are calling server user:xxx
  • remove saveUser
  • remove getUserByXXX
• remove User object (the original user object returned in signup/login api), the followings are needed to replace the api provided by the original User object
  • add add/get/deleteRoles api to skygear.auth, work with user id and role object
  • make ACL and Relation object consumes User record instead of User object

It appears there are two style of comments:

 /**
  Comment here.
  */

 /**
  * Comment here.
  */

Personally, I prefer the second style despite the fact that many of my comments in the file are made with the former style.

A developer is confused which API to call for registering/unregistering device:

• registerRemoteNotificationDeviceToken:completionHandler:
  • should add a method registerDeviceWithDeviceToken:completionHandler: to be consistent with other APIs
  • mention that this method is for registering remote notification (i.e. push notification)
  • mention that app should call unregisterDeviceCompletionHandler: to unregister device
• registerDeviceCompletionHandler:
  • mention that this method is for registering the device if user denied push notification permission / to register device for pubsub
  • mention that app should call unregisterDeviceCompletionHandler: to unregister device
• unregisterDevice
  • should be deprecated, call unregisterDeviceCompletionHandler: with nil parameter
• unregisterDeviceCompletionHandler:
  • mention that this method should be called to unregister device

SkygearIO/features#71

• Update Container api with the following grouping
• Update Test
• Update Example

Grouping:

Container:

  state:
    url
    apiKey
    timeoutOptions
    auth(AuthContainer)
    relation(RelationContainer)
    db(DatabaseContainer)
    pubsub(PubsubContainer)
    push(PushContainer)
    chat(ChatContainer)
    analytics(AnalyticsContainer)

  api:
    config
    configApiKey
    lambda
    sendRequestObject
    makeRequest


AuthContainer:

  state:
    accessToken
    user(User)

  api:
    signupWithUsername
    signupWithEmail
    signupWithUsernameAndProfile
    signupWithEmailAndProfile
    signupAnonymously
    loginWithUsername
    loginWithEmail
    loginWithProvider
    logout
    changePassword
    forgotPassword
    // following api would be affected by https://github.com/SkygearIO/features/pull/68
    saveUser
    whoami
    getUsersByEmail
    getUsersByUsername
    discoverUserByEmails
    discoverUserByUsernames


RelationContainer:

  api:
    queryFriend
    queryFollower
    queryFollowing
    addRelation
    removeRelation


DatabaseContainer:

  state:
    public(PublicDatabase)
    private(PrivateDatabase)
    cacheResponse(Boolean)

  api:
    makeUploadAssetRequest


PublicDatabase:

  state:
    cacheStore

  api:
    setAdminRole
    setDefaultRole
    getDefaultACL
    setDefaultACL
    setRecordCreateAccess
    setRecordDefaultAccess
    getRecordByID
    save
    query
    del
    clearCache
    fetchSubscriptionWithID
    saveSubscription
    deleteSubscriptionWithID


PrivateDatabase:

  state:
    cacheStore

  api:
    getRecordByID
    save
    query
    del
    clearCache
    fetchSubscriptionWithID
    saveSubscription
    deleteSubscriptionWithID


PubsubContainer:

  state:
    channel
    internalChannel
    autoPubsub(Boolean)

  api:
    on
    off

PushContainer:

  state:
    deviceToken
    deviceID

  api:
    registerDevice
    unregisterDevice
    sendPushNotification

ChatContainer:


AnalyticsContainer:

Example:

// Call API
#import <SKYKit/SKYKit.h>

SKYContainer *container = [SKYContainer defaultContainer];
[container.auth loginWithEmail:@"[email protected]" password:@"secret" completion:nil];
[container.auth forgotPasswordWithEmail:@"[email protected]" completion:nil];
[container.pubsub subscribeTo:"channel" handler:nil];

SKYRecord *sampleItem = [SKYRecord recordWithRecordType:@"SampleItem"];
[container.db.public saveRecord:sampleItem completion:nil];

// Retrieve contexts
#import <SKYKit/SKYKit.h>

SKYContainer *container = [SKYContainer defaultContainer];
NSString *apiKey = [container apiKey];
NSString *currentAccessToken = [container.auth currentAccessToken];
NSDictionary *publicDBCache = [container.db.public cache];

From the chat SDK, there is some code to copy a SKYRecord and create a custom subclass (such as SKYMessage. I suggest that we make ``SKYRecordDeserializer deserializer]` to return a singleton object and SDK user can register subclass to be used for deserialization when the deserializer encounter certain types:

id der = [SKYRecordDeserializer deserializer];
[der registerRecordClass:[SKYMessage class] forType:@"message"];

id record = [der recordWithDictionary:recordDict];
[record isKindOfClass:[SKYMessage class]]; // true

Current implementation always prefix with http. Since the input is NSString, I expect the program will detect if I supply protocol prefix and don't append http as protocol if I already provided https://

Currently the sdk saves accessToken and currentRecordID in [NSUserDefaults standardUserDefaults], which not accessible across apps in app group, in case I want to add extension to existing app.

follows #64

The iOS SDK expects the server to send valid response. In case the server sends a response that the iOS SDK does not expect, SKYDataSerialization returns nil (which IMHO is the expected behavior). This caused nil being added to NSDictionary, which is illegal.

The SKYRecordDeserializer should, on encountering a nil value, do one of the following (your pick):

• set [NSNull null]
• not set the key
• set SKYUnknownValue maybe not this one

and also emits a log stating that the value of the key failed to deserialize.

Swift code:

let asset = SKYAsset(name: "profile-picture", data: UIImagePNGRepresentation(UIImage()))
asset.mimeType = "image/png"

Error message:

Error Domain=SKYOperationErrorDomain Code=9 "The data sent by the server cannot be processed." UserInfo={SKYErrorName=InvalidData, NSLocalizedDescription=The data sent by the server cannot be processed., SKYErrorMessage=Uploaded asset does not have a name associated with it.}

When calling -[SKYContainer defineDefaultAccessWithRecordType] the SDK should remember the settings and apply default ACL settings to record when needed (see below). The default ACL settings does not need to persist across application relaunch because it is expected that the developer will always call this method when the app launches.

The default ACL should not be applied to a record when it is instantiated. The default ACL should only apply when the the developer tries to mutate the record ACL.

Since -[SKYRecord accessControl] is readonly and nil when record is instantiated, it is not reasonable to expect the developer to change the record ACL using methods provided in SKYAccessControl. To make the iOS SDK to match the design of the JS/Android SDK, we should add -[SKYRecord set[Public](No|ReadOnly|Write)Access[For(User|Role)]] that implement record ACL mutation.

When default ACL for the record type is not defined, the fallback ACL will apply. The fallback ACL is public-readable.

If record ACL is null, getting the record ACL will not cause the record ACL to change. Return the default ACL or fallback ACL in this case.

Implement -[SKYRecord get[Public](No|ReadOnly|Write)Access[For(User|Role)]] for getting record ACL.

In earlier versions of the SDK, +[SKYAccessControl (set|get)DefaultAccessControl] sets and gets the default ACL that applies to all record types. These methods should be retained but deprecated. These methods should alter the fallback ACL. In other words, calling these methods will override the fallback ACL of public-readable.

I have some issues when I tried to do “performCachedQuery” on the table News.

It seems to be fine for the first time but it crashed the app afterwards.
Below is the log of the issue:
* Terminating app due to uncaught exception 'NSInvalidArgumentException', reason: '* setObjectForKey: object cannot be nil (key: photo)'

Seems that there are some troubles in SKYRecordDeserializer. May you take a look on this issue?
And the code snippet is attached as follow. Thanks a lot!

A function implemented in SkygearIO/skygear-server#287

The following error could happen when uploading asset:

SkygearTest[10488:377789] error uploading asset: Error Domain=SKYOperationErrorDomain Code=108 “The server is unable to process the data.” UserInfo={arguments=(
    “content-size”
), NSErrorFailingURLKey=http://localhost:3000/asset/put, SKYErrorMessage=Missing content size or content size is invalid, SKYErrorName=InvalidArgument, SKYOperationErrorHTTPStatusCodeKey=400, NSLocalizedDescription=The server is unable to process the data.}

ref SkygearIO/skygear-server#350

Was inspired by this commit: oursky/doorlock@ba23e99

The developer in the above commit has to explicitly re-subscribe to a channel onConnectionClose()

The SDK maybe should have a default retry value and / or infinity by default?

As mentioned at SkygearIO/guides#48, Javascript support both array and hashtable for positional / named arguments of Lambda function.

So for consistency, we should support NSDictionary as another callLambda with NSArray.

error message:

-[SKYSequence encodeWithCoder:]: unrecognized selector sent to instance 0x7fc9236d42e0
*** Terminating app due to uncaught exception 'NSInvalidArgumentException', reason: '-[SKYSequence encodeWithCoder:]: unrecognized selector sent to instance 0x7fc9236d42e0'

code:

let todo = SKYRecord(recordType: "todo")
todo.setObject(title!, forKey: "title")
todo.setObject(SKYSequence(), forKey: "order")
todo.setObject(false, forKey: "done")

self.recordStorage.saveRecord(todo)

error message :
Failed to subscribe for my todo: Error Domain=SKYOperationErrorDomain Code=108 "The server is unable to process the data." UserInfo={arguments=<CFArray 0x125dae0f0 [0x19fcfa150]>{type = immutable, count = 1, values = (    0 : device_id )}, NSErrorFailingURLKey=https://todolist.skygeario.com/subscription/save, SKYErrorMessage=empty device_id, SKYErrorName=InvalidArgument, SKYOperationErrorHTTPStatusCodeKey=400, NSLocalizedDescription=The server is unable to process the data.}

 func application(application: UIApplication, didRegisterForRemoteNotificationsWithDeviceToken deviceToken: NSData) {
        print("Registered for Push notifications with token: \(deviceToken)");
        SKYContainer.defaultContainer().registerRemoteNotificationDeviceToken(deviceToken) { (deviceID, error) in
            if error != nil {
                print("Failed to register device token: \(error)")
                return
            }

            print("deviceID : \(deviceID)")  // has deviceID
            let query = SKYQuery(recordType: "todo", predicate: nil)
            let sortDescriptor = NSSortDescriptor(key: "order", ascending: false)
            query.sortDescriptors = [sortDescriptor]
            let subscription = SKYSubscription(query: query, subscriptionID: "my todos")
            SKYContainer.defaultContainer().privateCloudDatabase.saveSubscription(subscription,completionHandler: { (subscription, error) in
                if error != nil {
                    print("Failed to subscribe for my todo: \(error)")  // error occur
                    return
                }

                print("Subscription successful.")
            })
        }
    }

In the SKYContainer's register device method [1], if we try to register an existing device and the server couldn't find the supplied device ID, SKYContainer would re-register the device without supplying the device ID, in an attempt to register a new device.

However, subscription-related operations maintain a default itself, and would supply the device ID if it is not provided in the operation [2]. So SKYContainer's attempt to re-register a new device would fail in vain.

1. https://github.com/SkygearIO/skygear-SDK-iOS/blob/master/Pod/Classes/SKYContainer.m#L509
2. https://github.com/SkygearIO/skygear-SDK-iOS/blob/master/Pod/Classes/Operations/SKYRegisterDeviceOperation.m#L84-L89

Since SKYRecord doesn’t have metadata fields set in -init, the SKYRecordStorage should set those fields so that these fields can become sortable in SKYRecordStorage

SKYSequence is an object used by SDK users to denote a value that is finalized when saving at the server side. It should behaves like a NSValue returning an Integer. Currently it subclasses NSObject.

This causes problem in SKYRecordStorage because the record storage would try to sort an attribute consists of both NSValue and SKYSequence. Having SKYSequence implements NSValue will solve this problem.

This issue is reported by @a821246710.

Ref: SkygearIO/chat#40

• Project setup
• Sign up
• Login
• Record CRUD
• Query
• Pubsub