skidding / react-component-tree Goto Github PK

• react-component-tree/src/load-child.js

  Lines 60 to 62 in eb48ce1

  	if (!params.ref) {
  	params.ref = childName;
  	}

• https://twitter.com/skidding/status/666669809241858048

Here & Here

Need

As a developer
I want sensible warnings
So that I can be more productive.

Deliverables

Given I have a component
And it includes the `ReactComponentTree` mixin
And it defines a children method
When I call the method only once during a render cycle
Then no warning will be displayed.

Given I have a component
And it includes the `ReactComponentTree` mixin
And it defines a children method
And it doesn't define a `ref` prop
When I call the method more than once during a render cycle
Then a warning will be displayed.

Solution

Maybe keep a dict of calls that gets reset every render cycle?

/cc @skidding

The latest published version of your module is substantially older, so I tried installing from GitHub npm i --save https://github.com/skidding/react-component-tree#4335279 (had to use a commit ref as there are no tags).

This results in Error: Cannot find module 'react-component-tree' on first run. This is because the prepublish is never run when the module is installed like this, and so the dist directory is never created/populated, resulting in a require of a non-existant file.

I've forked and call compile on install, but still can't get the compile command to execute. When installed in this way, babel -d dist/ src/ complains src/ doesn't exist, I'm not sure why.

Looking at how other modules do this,
(use this one-liner to see the npm scripts for each of the modules in your current project that have a dist directory: for i in $( find . -name dist | grep -Eo '\./.++/'); do echo $i; node -e "console.log(require('$i' + 'package.json').scripts)"; done;
it seems that most modules simply commit their dist directories.

https://facebook.github.io/react/blog/2015/10/07/react-v0.14.html

Does any resemblence of this module still exist in react-cosmos? I looked and can't find any