sk- / phish-shell Goto Github PK

Sometimes the service is unavailable or the backend returns a non 200 response, in which case the shell does not do or report anything to the user.

Phpinfo returns html, which is not readable by humans. Replace it with a function that returns an array. See some of the implementations at http://php.net/phpinfo

The statement foo + produces the following response:
{"r":"syntax error, unexpected ';'"}{"r":"syntax error, unexpected ';'"}

Add an expiration date of static resources so they are cached.

Executing an invalid statements that may require saving, like for example:

$a = function foo() {};

will generate subsequent errors, as the statement is saved and will be executed every time before a statement.

The solution is to save the statement only if the previous statement was executed successfully.

It is annoying to have to type print_r or echo for simple statements. For example:

1 + 2
0
$a

When executing an undefined function a response with HTTP code 500 is returned, a 200 should be returned instead.

Running the command:
$a = eval('return function foo(){};');

gives the response:
{"r":""}
{"r":"syntax error, unexpected 'foo' (T_STRING), expecting '('"}

which of course is not valid JSON.

This is probably because the syntax error in this eval is ignoredm and the outer eval still returns.

php's empty should not be used for validating strings, as it rejects the statement 0 which is valid.