Global scan throughout the repository

• Contains a description
  • The repository does not have about description yet. Please keep it simple, for example, your student information and information about the course. Or just about the project.
• Contains a readme
  • The repository has a simple but understanding readme, describes the use case, a short description, installation, possible sources, and a GPLv3 license.
• Contains a license
• Contains a .gitignore
  • The repository contains a gitignore generated by GitHub. There are no node_modules or dirty junk.
• Concept described in the readme?
  • The in short section contains information globally over the project but not about the specific concept.
• Plagiarism and acknowledgments
  • None to be found; you have commented which documentation you have used from next.js

Assessment

Documentation is on the minimal side as the concept is lacking. Add your main research question as that would tie into the in short section.

Wiki

• Does the wiki contain a debrief?
  • It contains a debrief, which explains who the partner is and what we will be doing throughout the course. It also describes the freedom the students have within the theme.
• Data cleaning / transformation process described?
  • exploring data wiki page describes Shabier's data process sanitizing with the survey data.
  • The page starts with Shabier's research questions and the required data to visualize that question. It may be wise to move this to its own wiki page and later link it within the readme.
  • There is a typo in the title; it misses an I after san.
  • Described the data sanitization process with survey data, Starting with the eye color as an example.
  • Used code snippets wisely to show code pieces and the output of the code.
    • Code is adequately written and on par with his experience with programming.
  • Used regex to minimize chaining to convert RGB to HEX.
  • Kept functions pure and properly used a functional pattern throughout the code examples.
• Described which functional patterns are applied?
  • There are no functional patterns described or mentioned.
    • This could be fixed by creating a new wiki page about the theory of functional programming and patterns used within, such as factories, currying, first-class functions, and more.
      • Maybe also interesting to know what the other programming paradigms are?
• Do I see improvement? (where should I see improvement?)
  Not applicable.

Assessment

A clear process of how Shabier went through the cleaning process of the survey data. Nice touch of how you have used regex.

Code

• Can I understand the code flow?
  • Code Flow within [exploring data[(https://github.com/sjagoori/functional-programming/wiki/Exploring-data#santization-examples) is concise and structured clearly.
• Is the most important code at the top?
  • Import is at top and most important function right under it.
• Is everything split into functions? Are other principles of FP applied?
  • functions are split into its individual task.
  • RDW Nextjs app is simplistic; it loads and filters the data based on the license plate and create a list view.
  • Why are there two API calls? in index.js and a separate folder named API
• Are map / ForEach used correctly?
  • map and forEach are used in their respective manner.
• Check code quality (Is it functional, consistency, reusability, naming conventions, etc.).
  Yes.

Assessment

One would think you really want to develop a full-blown react application with the RDW data.
I think you belong to one of the more experienced developers in this course.

Onderzoeksvraag in repo
What are the effects of different parking fees affect a parking spot's demographic?

Interessante onderzoeksvraag, als ik het goed begrijp ga je dus op zoek naar verbanden tussen de demografie van de gebruikers van de parkeerplaats met de kosten van dat moment. Ben erg benieuwd of je hier goede resultaten uit kan halen, kan me namelijk voorstellen dat er veel parkeerplaatsen zijn die enkel betaald parkeren zijn waar veel verschillende mensen komen (zoals bij een winkelcentrum) en gratis parkeerplaatsen waar meestal dezelfde mensen terugkomen (in de buurt/voor hun huis). Je zou je twee ideeën ook kunnen combineren en een soort weekoverzicht maken waarop je zowel de verschillen in tijd als de verschillen per dag kan zien.

Ik hoop voor je dat het data ophalen voor deze onderzoeksvraag een beetje te doen is en dat er makkelijk onderscheid valt te maken tussen parkeerplaatsen die bedoeld zijn voor bewoners en parkeerplaatsen voor bezoekers van bijv. een winkelcentrum. Misschien dat je hiertussen een keuze zal moeten maken om een duidelijker beeld te krijgen in de visualisatie?

Hi, ik snap je onderzoeksvraag niet zo goed.

Hi Hi,

Begrijp je de onderzoeksvraag die in de readme staat?

If I understand, you would correctly find the differences in how people use the parking spots depending on the date, paid or not.

Welke (sub)vragen roept de onderzoeksvraag bij mij op?

• Is there a difference between EV parking, normal parking? Considering EV vehicles could also charge at certain parking garages.
• What are the rules for parking on religious grounds?
• Is there also a difference in value in the cars? But sadly because of the GDPR that isn't possible.

Welke data zou jij nog meer kunnen gebruiken?

Potentially you also could turn it around, what are the effects of parking spots are filled and why are they filled? This could be linked with a special day.