sjaehn / bslizr Goto Github PK

The Makefile doesn't honor setting CXXFLAGS or LDFLAGS (but it really should!) and therefore setting LDFLAGS to achieve full RELRO is not possible out-of-the-box.

In case you need inspiration on how to do this, you can have a look at brummer10/GxPlugins.lv2#23 and lsp-plugins/lsp-plugins#4

When packaging 1.2.4 for Arch Linux, I ran lv2lint and sord_validate on the resulting plugin, but both fail:

bslizr-1.2.4-1-x86_64-check.log

While sord_validate probably holds many false-positives, it would be nice, if the lv2lint errors would be fixed.
Thanks!

Hi @sjaehn , I noticed after running make that new files are created in the root of the build tree, i.e BSlicer.lv2/ BSlicer.so BSlicer_GUI.so , they are owned by ROOT as we have run the sudo command for building.
perhaps it would be better to either remove them right after the make install or have a separate build folder to work in ?

Hi,

Thanks for a great plugin!
I made a NixOS package for it.

I have some suggestions for the UI:

• Make the monitor switch respond to clicks as well as drags.
• Invert the release knob: low numbers on the left, high on the right.
• Add a reset button to the volume sliders, to quickly turn them all on again and make a new pattern.

Hello,

I have successfully build your software, it's running fine when I run it with jalv.gtk but not on Carla 1.9.13+2.0-RC3.

Nothing seems to be happening. The monitor is not "moving" even if it's switched on.

Do you think of anything that I might be doing wrong ?

Cheers
Erwan

Hi, thanks for this awesome plugin.

In order to compile BSlicer on Mint 18 (== Ubuntu 16.04) I had to:

1. comment out https://github.com/sjaehn/BSlicer/blob/master/src/BSlicer_GUI.cpp#L32
   "looparray.hpp" isn't in the source tree, as far as I can tell
2. add -std=c++11 to https://github.com/sjaehn/BSlicer/blob/master/makefile#L13 and https://github.com/sjaehn/BSlicer/blob/master/makefile#L17
   $(CC) $< -o $(BUNDLE)/$@ -std=c++11 -shared -fPIC -DPIC pkg-config --cflags --libs lv2 `$(CC) $< $(TK) -o $(BUNDLE)/$@ -std=c++11 -shared -DPUGL_HAVE_CAIRO -fPIC -DPIC `pkg-config --cflags --libs lv2 x11 cairo

Hi! I'm about to package bslizr for Arch Linux.
I noticed, that the Makefile doesn't honor DESTDIR at all, which is not so nice, as it now has to be hardcoded within the custom INSTALL_DIR.

It would be great if it could be changed to the more generic and widely adopted DESTDIR and PREFIX (see https://www.gnu.org/prep/standards/html_node/Directory-Variables.html#Directory-Variables as reference).