sir-dunxalot / ember-disqus Goto Github PK

Currently, it crashes apps based on Ember CLI 2.11 because its own Ember CLI setup is so old.

@sir-dunxalot Are you going to maintain this addon? Looks like it's been abandoned for two years.

I tried upgrading this addon's Ember CLI setup, but the tests are written in an outdated fashion, and I wasn't able to align them with modern conventions.

Please either upgade it to latest Ember CLI or consider passing it to another maintainer. I'm thinking of restarting this addon from scratch.

When you have multiple sites, you can share a thread with other sites if they are whitelisted in the admin panel.

In order to do this, you need to specify disqus_url and omit identifier.

First load works as expected.

However, if I visit a route that envokes the disqus-comments component, and then navigate to a new view with another instance of the disqus-comments, the "Loading Comments..." text is present above the iframe.

Installing this results in the following deprecation message:

DEPRECATION: Overriding init without calling this._super is deprecated. Please call `this._super.init && this._super.init.apply(this, arguments);` addon: `ember-cli-htmlbars`
    at Function.Addon.lookup (/var/www/myproject/node_modules/ember-cli/lib/models/addon.js:1009:27)

Ember      : 2.7.0
Ember Data : 2.7.0
jQuery     : 2.2.4

While testing the app, new discussions will be added. The Disqus links will be of the form:

http://localhost:4200/discussion-identifier

Wire up Disqus only in production mode.

I have a {{disqus-comments}} on a show page. On the first visit to the show page, the placeholder "Loading Comments..." is shown, then removed once Disqus is ready. Upon going back to my index page, then revisiting the show page, the placeholder text is no longer removed, but instead sits above the Disqus comments.

I'm currently getting around this by providing an empty block as the placeholder, but this obviously isn't ideal. Sorry I couldn't be of more help and debug this myself; I took a look through the code and couldn't find the logic tied to redrawing/overwriting the template/placeholder text.

I'd be happy to dig deeper if pointed in the right direction as far as where the redrawing happens.

First off, very nice plug in here... works just like you say it should.

Only minor change I would like to see so far is right now it appears the {{disuqs-comment-count}} gets the number of total comments per discussion INCLUDING deleted ones... As a discussion moderator and developer, I would like to see a comment-count of only APPROVED comments. It appears Disqus keeps all comments made per discussion (including deleted ones) so not sure if this is even possible or if there would be a way to filter down the list to simply approved ones.