singapore / gl-got Goto Github PK

Because this is a library that is consumed by others, should we "unpin" its dependencies and revert to ranges? And if so, then which ranges? And keep devDependencies pinned or also ranges?

@rarkins would you please publish version 7.0.0 to the npm registry?

I've merged in gh-got commits into gl-got.

Also, #26 can be closed as that update was one of the commits I pulled from gh-got.

While exploring gl-got, I realized that the unit tests have an online requirement. They require that a GitLab token be set so that the unit tests can access GitLab.com.

I would like to modify the unit tests by extending the use of nock to make all unit tests offline.

Using this new API could potentially simplify the code considerably. See: sindresorhus/gh-got#29 and the docs https://github.com/sindresorhus/got/blob/master/advanced-creation.md

I think the last major version update changed how tokens are handled.

Previously, we were supporting only Personal Access Tokens with this code:

Since v9.0.0, opts.token is passed through to got and I'm not sure if it's actually used there or not, based on the lack of hits for "token" here: https://github.com/sindresorhus/got/search?utf8=%E2%9C%93&q=token&type=

I was researching this code in the context of adding OAuth token support to this library in addition to Personal Access Token support, when I realised this unanticipated change in v9.

Cc @itaisteinherz @hbetts