sindreslungaard / duel-masters Goto Github PK

Both attacker (2k power) and darkness blocker (2k base power) died

Hey, thanks for releasing the code for this! I only briefly looked over the code but so far it looks very modular and easy to use, great job!

One thing I noticed is the kinda inconsistent coding style. E.g. some classes are lower case, while other are upper case. It might be a good idea to use a linter like eslint or tslint to enforce a consistent style. You then could even use something like husky to enforce the code style for commits.

This is just a small thing but I think it can be important when multiple people will contribute to this project.

Beklager wong spill/bruker.

Is there a way we can add automated tests? That might help with testing cards and their abilities as they get more complex.

I'm working on "a lot" of changes in the client (#11) and one of those is a better / expanded filtering system. It would be great if the cost, race and card type (spell, creature) could be added to the API response of cards. That way I can implement filters for it.

It seems to be adding itself from deck into hand (but it already exists on board)

The selection screen is fine, I was only able to choose survivors.

Hello, decks should be conditioned to consist of exactly 40 cards

lone tear destroys itself inside the deck in the duel logs at end of turn 1

Currently when you query for a deck through the API you just get a list of UIDs in the deck.cards property. That means for displaying names and other information in the deck builder I first need to convert the UIDs to proper card objects. It would be convenient if deck responses would contain the full card objects.

Hello. I propose first to modify Context to have prefxs, mainfx, these are proposed to tackle some problems that might prop up later, for e.g if zephyr precedes a creature that cannot attack for whom the attack is proposed, it'll be tough to handle such a situation. Secondly, I propose a conflict resolution mechanism, to prompt the user to choose what effect he wishes takes precedence, or overrides when there is a conflict, in accordance with the official rule book.

Chaos fish can attack untapped creatures and repeatedly use the ability (pulling x amount of cards), meaning you can pull your entire deck in one turn.