simplonco / galactic-space-combat Goto Github PK

View Code? Open in Web Editor NEW

2.0 20.0 9.0 8.99 MB

Un projet interpromo d'une semaine !

License: GNU General Public License v2.0

PHP 28.93% CSS 71.00% ApacheConf 0.07%

php mysql composer bootstrap challenge star

galactic-space-combat's Issues

die('Erreur : '.$e->getMessage()); => Recover error a bit more smootly!

Make tasks and DONE status look better!

Move in a separate generateRandomString function for example

$LENGHT could be a parameter 😉

Create a beautifull README.md

Because we have to start somewhere 😅!

Add unit automated tests

Like Travis CI !

Add a .htaccess to disable apache HTTP access inside includes folder

Disable apache HTTP access inside includes folder with a .htacess!

SELECT * is a bad coding practice..

For example, look inside control_center.php:

$req = $bdd->prepare('SELECT * from tasks WHERE private_key = ?');

Don't forget htmlspecialchars()

For example, inside includes/control_center.php:

<!-- TODO: Don't forget htmlspecialchars() -->
<form class="form" action="/api/create_task.php?key=<?php echo $_GET['key']; ?>" method="POST">

PHP Notice: Undefined index error

[Mon Jul 25 15:36:35.921490 2016] [:error] [pid 4052] [client ::1:52350]
PHP Notice:  Undefined index: error in /var/www/html/includes/welcome.php on line 4

Add new ideas of tasks!

Write ideas in the README.md 😄!

e.g:

Build a Gold Extract Factory LVL 1
Build a X230 Space Ship
...

Replace ugly PHP redirects by a cools JS ajax call and a partial HTML refresh!

http://api.jquery.com/jquery.ajax/

Add META markups

Inside index.php:

<head>
    <!-- TODO: add META markups -->
    <link rel="stylesheet" href="/assets/css/hack.css" />
    <link rel="stylesheet" href="/assets/css/dark.css" />
</head>

Like charset=utf8, etc..

Rename the GitHub project repository

big-project not so cool.. what's about galactic-space-combat 😄 ?

Fix XSS security issue

https://fr.wikipedia.org/wiki/Cross-site_scripting

Do you know why this button not working on click?

Inside index.php:

    <div class="form-actions">
        <!-- TODO: Do you know why this button not working on click? -->
        <button type="button" class="btn btn-default btn-block btn-ghost">Retreive your game!</button>
    </div>

What's happen if signup is not succesfull?

Add $req->closeCursor() everywhere!

Improve & Translate the README.md

Explain the purpose of the project 😉!

Database settings are duplicated

Define MySQL settings only one time..

$HOST = 'localhost';
$DBNAME = 'test';
$LOGIN = 'root';
$PASSWORD = 'root';

Look in create_task.php, signup.php and control_center.php files 😱..

A good idea could be to use a functionor PHP include keyword 😉!
http://php.net/manual/fr/function.include.php

simplonco / galactic-space-combat Goto Github PK

galactic-space-combat's Issues

Recommend Projects

Recommend Topics

Recommend Org