driverAlign() ignores gain sign, always "MOT: Success: 3" about arduino-foc HOT 4 OPEN

I agree we should change the code to only return 3 (or 4) if the gains were actually inverted compared to the user supplied setting. It's not a hard fix, so could be in the next release.

from arduino-foc.

Hi,

This is how the code works.
It will just give you success 3 if the gains are negative, even if it's correct.

That's not a problem but it could be improved.

from arduino-foc.

Thank you, it is a little bit confusing and I was not sure if the output was intended.
It would help, if you change the sign of the gain it should somehow influence the outcome downstream ...

from arduino-foc.

Hi guys,
The new current sense init #422 is in the release v2.3.4.
It has several new features and that make it easier to use and has the suggested modification. :D
The new code returns 3 or 4 only if the gains are actually inverted.

from arduino-foc.