Git Product home page Git Product logo

beautified-josm-preset's People

Contributors

beardhatcode avatar contrapunctus-1 avatar datendelphin avatar goldfndr avatar jidanni avatar ltog avatar mannivu avatar marcows avatar matkoniecz avatar morray avatar mueschel avatar nlehuby avatar riqq avatar sarabjeet108 avatar simonpoole avatar timmagee avatar versat avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

beautified-josm-preset's Issues

provide synonyms

In Polish "budowa" means construction, so somebody who wants to use landuse=construction may search using this word

Unfortunately, Vespucci is unable to guess that it refers to this form as to make meaning clear it is named "teren budowy".

It would be desirable to allow adding synonyms for use by search.

Government offices tagging scheme approved

With the new tagging scheme described here link number of presets are now outdated and should be changed. This include:

preset name; old tagging; new tagging
Register; office=register; office=government + government=register_office
Administrative; office=administrative; office=government
Public buildng; amenity=public_building; discouraged

From what I seen that should be it, but if someone could double check it I would be grateful.

Strange grouping and sub-grouping in JOSM

I discovered that JOSM is grouping the tags very strangely. Some groups that should be sub-groups end up as main groups (way, waypoint, access restrictions), and some groups and subgroups end up in groups where they do not belong (geography under highway, etc) Don't know exactly what makes this.

Pedestrian Crossing

Check if OH semantics + yes/no. for Crossing attendant
Preset seems to missing "crossing" tag.

Is it necessary for bays to be large?

A large body of water partially enclosed by land but with a wide mouth.

http://wiki.openstreetmap.org/wiki/Tag:natural%3Dbay is not mentioning "large" size of qualifier.

It may be related to cultural differences, but I am surprised by "large" requirements (Polish Wikipedia even explicitly mentions that size of water area is in not relevant).

transifex identifier: master_preset.xml:2936(label:text|group:Water|preset:Bay):

Redo access preset

The access ("Road Restriction") preset is fundamentally broken. Split it up into multiple individual prests selectable via the approriate street sign.

is it OK to translate "deprecated" as "outdated"?

In Polish there is no equivalent of "deprecated" and closest is "przestarzałe" what means "outdated".

Is it OK to use this pejorative translation?


There is number of terms to translate with "(deprecated)" as part ( https://www.transifex.com/openstreetmap/presets/translate/#pl/presetpot/116088711?q=deprecate )

Unfortunately in Polish there is no word equivalent to deprecated (for example http://edict.pl/dict?word=deprecated&words=&lang=EN translates deprecated as

określenie funkcji lub programu, który staje się przestarzały i jest powoli zamieniany innym, nowszysm produktem

, printed Kościuszko Foundation Dictionary has no word "deprecated" and "deprecate" has translations for different meanings)

https://www.transifex.com/openstreetmap/id-editor/translate/#pl/presets?q=deprecate is not helpful as iD is not displaying to user whatever tag is deprecated

Presets only in iD

Presets present only in iD, ordered by count in OSM database, bold == count less than 1'000, only for amenity, shop, man_made, highway, waterway, railway, historic, tourism, emergency, leisure, aeroway (none missing), aerialway (none missing), natural (none missing), landuse, office and craft. This only takes "primary" keys in to account, further differing attributes are ignored for now.

Note: this is not a diff, there are presets missing in iD that are present here (but not as many).

Stroked through values are deprecated in iD and should likely be so here to.

amenity

  • amenity=swimming_pool ignored
  • amenity=public_bookcase
  • amenity=dojo
  • amenity=boat_rental
  • amenity=animal_shelter
  • amenity=public_bath
  • amenity=register_office ignored
  • amenity=animal_boarding
  • amenity=crematorium
  • amenity=love_hotel
  • amenity=waste_transfer_station
  • amenity=coworking_space iD has replaced this with office=coworking which is however lower use and contrary to the current consensus, ignored
  • amenity=animal_breeding
  • amenity=monastery
  • amenity=planetarium
  • amenity=scrapyard iD replaced this recently with industrial=scrap_yard (exists as value in this preset) based on a bogus wiki page
  • amenity=car_pooling

shop

  • shop=vacant ignored
  • shop=massage
  • shop=second_hand
  • shop=trade
  • shop=fashion added as deprecated
  • shop=charity
  • shop=craft this is very confusingly named
  • shop=gas
  • shop=carpet
  • shop=bathroom_furnishing
  • shop=money_lender
  • shop=fishmonger ignored
  • shop=chocolate
  • shop=storage_rental
  • shop=herbalist
  • shop=radiotechnics
  • shop=e-cigarette
  • shop=scuba_diving
  • shop=leather
  • shop=tiles
  • shop=religion
  • shop=nutrition_supplements
  • shop=wholesale
  • shop=appliance this would seem to have an odd neither deprecated nor documented state
  • shop=weapons
  • shop=agrarian
  • shop=furnace added as deprecated, use shop=fireplace instead
  • shop=window_blind
  • shop=pyrotechnics
  • shop=anime
  • shop=water_sports no wiki entry
  • shop=candles

man_made

  • man_made=petroleum_well
  • man_made=mast
  • man_made=pumping_station

highway

  • highway=corridor

waterway

  • waterway=sanitary_dump_station
  • waterway=water_point

railway

  • railway=derail

historic

  • historic=tomb

tourism

  • tourism=gallery
  • tourism=aquarium

emergency

  • emergency=life_ring

leisure

  • leisure=resort
  • leisure=dance
  • leisure=adult_gaming_centre
  • leisure=outdoor_seating
  • leisure=bowling_alley
  • leisure=amusement_arcade
  • leisure=hackerspace

landuse

  • landuse=churchyard
  • landuse=harbour

office

  • office=coworking use amenity=coworking_space, ignored

craft

  • craft=electronics_repair changed craft=electronics to this
  • craft=sculpter this is a typo in the preset in iD should be sculptor, ignored

Present in both but deprecated in iD

  • amenity=nursing_home deprecated here too

optional names

I think that for following names also should be optional:

natural=wetland

natural=mud

man_made=pier

leisure=slipway

aerialway=pylon

amenity=taxi

tourism=viewpoint

leisure=dog_park

tourism=picnic_site

remove natural=fell preset

as part of gravitystorm/openstreetmap-carto#545 I checked how natural=fell is used

Actual use of the tag for areas as of October 2017 includes different kinds of treeless areas, in particular areas vegetated primarily by grasses (Poaceae) which are commonly tagged as natural=grassland or landuse=meadow, areas mostly vegetated by dwarf scrubs which are more commonly tagged natural=heath, rain fed peat producing wetlands for which the established tagging is natural=wetland + wetland=bog and areas with very little or no vegetation which in most cases qualify as natural=scree or natural=bare_rock. When mapping preferably choose the tag that best and most precisely describes the specific setting you are looking at. Data users should not expect a particular type of surface or vegetation for areas tagged natural=fell.

from https://wiki.openstreetmap.org/wiki/Tag:natural%3Dfell appears to be a good description of the situation

Therefore I think that natural=fell usage should not be encouraged. After #34 fell may be added as search term for natural=grassland, landuse=meadow, natural=heath, natural=wetland, natural=scree or natural=bare_rock to help users find more specific tags.

matching JOSM report: https://josm.openstreetmap.de/ticket/15515#ticket

matching iD report: openstreetmap/iD#4502

Missing icons

  • Abandoned Rail
  • Address Interpolation
  • Animal watering place
  • Aquaculture
  • Arcade
  • Avalanche Protector
  • Bandstand
  • Bare Rock
  • Bay
  • Bookmaker
  • Building part
  • Bunker (Golf)
  • Bunker Silo
  • Chocolate
  • City Wall
  • Cliff
  • Coastline
  • Colonnade
  • Commercial
  • Compressed Air
  • Cutline
  • Cycle Lane/Track
  • Disused Rail
  • Ditch
  • Drivng range (Golf)
  • Embankment
  • Fairway (Golf)
  • Fell
  • Fence
  • Field Hockey
  • Frontal Water hazard (Golf)
  • Funicular
  • Garages
  • General access
  • Green (Golf)
  • Greenhouse Horticulture
  • Guard Rail
  • Heath
  • Hedge
  • Hole (Golf)
  • Holiday apartment
  • Insulator
  • Internet Access
  • Internet Cafe
  • Island
  • Islet
  • Isolated Dwelling
  • Kerb
  • Kiln
  • Lateral water hazard (Golf)
  • Locality
  • Lottery
  • Magic Carpet
  • Movable Bridge
  • Mud
  • Multipolygon
  • Navigationaid
  • Named junction
  • Neighbourhood
  • Pastry
  • Perfumery
  • Photo booth
  • Pin (Golf)
  • Pipeline
  • Pipeline Marker
  • Pipeline Valve
  • Pole with switch
  • Power Portal
  • Protected Area
  • Public Bicycle Repair Station
  • Public bookcase
  • Quarter
  • Racetrack
  • Raceway
  • Railway Platform
  • Railway Signal
  • Ranger Station
  • Reef
  • Retaining Wall
  • Riverbank
  • Rock
  • Roller Skating
  • Rough (Golf)
  • Runway
  • Salt pond
  • Sand
  • Sanitary Dump Station
  • Scree
  • Shingle
  • Site
  • Sports Centre
  • Square
  • Stop Area
  • Stop Position
  • Taxiway
  • Tea
  • Tee (Golf)
  • Transformer Tower
  • Valley
  • Volcano
  • Wall

Improvements for natural=tree

Here are some improvements for natural=tree, see also https://github.com/simonpoole/beautified-JOSM-preset/blob/master/master_preset.xml#L10388

The key taxon is used rarely, species is the most important. Genus can be derived from species but is good to have in there, nevertheless. See also https://wiki.openstreetmap.org/wiki/Key:taxon

The keys type and cycle are no longer to be used for a tree, so these need to be removed as well. See also https://wiki.openstreetmap.org/wiki/Key:type and there is no wiki page for key cycle. Instead of these leaf_type and leaf_cycle need to be offered. See also https://wiki.openstreetmap.org/wiki/Key:leaf_type and https://wiki.openstreetmap.org/wiki/Key:leaf_cycle (Note that mixes for natural=tree should never be chosen. That is for forests etc.)

To be added, as it can be measured relatively easy by surveyors, is circumference. See also https://wiki.openstreetmap.org/wiki/Key:circumference

See also the following screenshots. What is a property and what is a detail is for me for trees prety much the same. Keys genus, leaf_type and leaf_ cycle can be derived from species, so those are to me details. A tree does often not have a proper name so that is for me a detail too. When it has a name, it usually also has an organisation taking care of it, so the key operator is also good to offer with name under details only.

tree_1_properties

tree_2_details

add noise_barrier

Add at wall=noise_barrier in some form to the barrier=wall preset.

Different meanings of "Island" need separate translation strings

The text "Island" is used in three places. The following two are together on transifex:

  1. master_preset.xml:106(list_entry:short_description|value:island):
  2. master_preset.xml:11659(item:name|group:Geography|preset:Island):

The third is alone in a separate text:
3. master_preset.xml:1941(item:name|group:Traffic_Calming|preset:Island):

In Finnish I would translate 1 and 3 with the same word ("saareke") and 2 with another ("saari").

Maybe it would be the best to split 1 and 2, i.e. have three individual translations strings.

poor Polish translation, makes adding objects under construction complicated in Vespucci

Reproduced with inexperienced person attempting to add landuse=construction

Vespucci followed system language (without override) and switched to Polish.

Searching "budowa" displayed confusingly titled craft=construction and highway=construction but not landuse=construction.

Neither highway=construction nor craft=construction was recognizable from title and icon. Landuse=construction was not found. It seems that switch to English is unavailable.

Moderate use tags without presets

The following shop and amenity values are used > ~300 times, have wiki page, but no preset (the list does not include tags listed in #27). Naturally some of these have better and more popular alternative tagging.

shop

  • shop=fishing (1320)
  • shop=electrical (1305)
  • shop=frozen_food (709)
  • shop=building_materials (632)
  • shop=insurance (609)for all practical purposes this has been replaced by office=insurance
  • shop=printing (590)
  • shop=shoe_repair (550)
  • shop=hunting (480)
  • shop=winery (466)
  • shop=games (462)
  • shop=tiles (451) now present in iD
  • shop=flooring (413)
  • shop=household (395)
  • shop=party (393)
  • shop=lamps (389)
  • shop=solarium (348) -> leisure=tanning_salon
  • shop=accessories (337)
  • shop=doors (334)
  • shop=office_supplies (325)
  • shop=discount (323)
  • shop=rental (319)
  • shop=water (316)
  • shop=swimming_pool (310)
  • shop=health_food (308)
  • shop=hobby (295)
  • shop=pottery (254)
  • shop=spices (250)

amenity

  • amenity=boat_storage (2653)
  • amenity=shop (2569) -> shop="
  • amenity=game_feeding (1971)
  • amenity=retirement_home (1858)-> social_facility=*
  • amenity=payment_terminal (1818)
  • amenity=events_venue (1813)
  • amenity=training (1679)
  • amenity=lavoir (1491)
  • amenity=ticket_validator (1473)
  • amenity=monastery (1422) now present in iD
  • amenity=vehicle_inspection (1342)
  • amenity=kneipp_water_cure (1289)
  • amenity=office (1246) -> office=*
  • amenity=feeding_place (1042)
  • amenity=gym (1010)
  • amenity=weighbridge (1008)
  • amenity=garages (989)
  • amenity=money_transfer (974)
  • amenity=water (961)
  • amenity=stables (945)
  • amenity=love_hotel (920)
  • amenity=dancing_school (873)
  • amenity=public_hall (797)
  • amenity=emergency_service (778)
  • amenity=advertising (756)
  • amenity=customs (695)
  • amenity=mortuary (676)
  • amenity=refugee_housing (676)
  • amenity=club (647)
  • amenity=spa (636)
  • amenity=conference_centre (617)
  • amenity=sanatorium (613)
  • amenity=dive_centre (610)
  • amenity=loading_dock (607)
  • amenity=language_school (554)
  • amenity=nameplate (490)
  • amenity=life_ring (440) this has been replaced by the equivalent emergency tag
  • amenity=nursery (400)
  • amenity=dog_bin (398)
  • amenity=rescue_station (373)
  • amenity=kitchen (372)
  • amenity=trolley_bay (371)
  • amenity=vacuum_cleaner (357)
  • amenity=payment_centre (357)
  • amenity=alm (299)

historic

  • historic=building (35 091)
  • historic=charcoal_pile (34 655)
  • historic=heritage (9 618)
  • historic=citywalls (9 362)
  • historic=mine_shaft (5 684) no wiki page
  • historic=railway (4 751) no wiki page
  • historic=hollow_way (4 528) no wiki page
  • historic=manor (3 694)
  • historic=summer_mountain_farm (3 464) no wiki page
  • historic=milestone (3 336)
  • historic=church (3 219)
  • historic=fort (2 910)
  • historic=mine (2 534)
  • historic=wreck (2 338)
  • historic=city_gate (2 245)
  • historic=house (2 226) no wiki page
  • historic=pa (2 119)
  • historic=roman_road (2 064)
  • historic=stone (2 040)
  • historic=bunker (1 987) no wiki page
  • historic=wayside_chapel (1 897) no wiki page
  • historic=farm (1 856)
  • historic=earthworks (1 752) no wiki page
  • historic=aircraft (1 418)
  • historic=monastery (1 352)
  • historic=cannon (1 203)
  • historic=bomb_crater (1 077)
  • historic=threshing_floor (950) no wiki page
  • historic=bridge (939) no wiki page
  • historic=tower (907)  no wiki page
  • historic=shieling (874)
  • historic=shelter (844) no wiki page
  • historic=pillory (675)
  • historic=path (611) no wiki page
  • historic=ship (609)
  • historic=industrial (596) no wiki page
  • historic=way (573) no wiki page
  • historic=fire_hydrant (566) no wiki page
  • historic=canal (523) no wiki page
  • historic=aqueduct (487)
  • historic=technical_monument (480) no wiki page
  • historic=locomotive (445)
  • historic=lavoir (444) no wiki page
  • historic=quarry (405) no wiki page
  • historic=palace (375) no wiki page
  • historic=marker (333) no wiki page
  • historic=road (320) no wiki page
  • historic=rune_stone (319)
  • historic=chapel (317) no wiki page
  • historic=cemetery (259) no wiki page
  • historic=railway_station (245) no wiki page

man_made

  • man_made=dyke (9 324)
  • man_made=dolphin (8 597)
  • man_made=MDF (6 999)
  • man_made=lamp (4 603) no wiki page
  • man_made=tank (4 513) no wiki page
  • man_made=waterway (4 510) no wiki page
  • man_made=antenna (4 507)
  • man_made=utility_pole (4 494)
  • man_made=water_tank (4 375) replaced by man_made=storage_tank
  • man_made=communications_tower (3 972)
  • man_made=water_tap (3 924)
  • man_made=reinforced_slope (3 572) no wiki page
  • man_made=beam (3 391) no wiki page
  • man_made=cairn (3 119)
  • man_made=clearcut (2 803)
  • man_made=stele (2 614) no wiki page
  • man_made=goods_conveyor (2 332)
  • man_made=oil_tank (2 158) no wiki page
  • man_made=snow_cannon (2 114)
  • man_made=snow_fence (2 034)
  • man_made=pole (1 995)  no wiki page
  • man_made=pumping_rig (1 711)
  • man_made=telephone_office (1 702) no wiki page
  • man_made=avalanche_protection (1 551) no wiki page
  • man_made=storage (1 538)  no wiki page
  • man_made=canopy (1 514) no wiki page
  • man_made=gantry (1 490) no wiki page
  • man_made=telescope (1 473)
  • man_made=well (1 445)
  • man_made=spoil_heap (1 295)
  • man_made=advertising (1 279) no wiki page
  • man_made=dike (1 266) this is a typo and should be man_made=dyke
  • man_made=torii (1 169) no wiki page
  • man_made=kiln (1 126)
  • man_made=mound (1 030) no wiki page
  • man_made=mussel_raft (936) no wiki page
  • man_made=basin (935) no wiki page
  • man_made=reservoir (852) no wiki page
  • man_made=fuel_storage_tank (849) no wiki page
  • man_made=quay (764)
  • man_made=water_pump (758) no wiki page
  • man_made=campanile (756)
  • man_made=logway (735) no wiki page
  • man_made=billboard (709) has been replaced by advertising=billboard
  • man_made=jetty (703)
  • man_made=stockyard (683) no wiki page
  • man_made=collecting_chute (609) no wiki page
  • man_made=dovecote (573)
  • man_made=water_canal (554) no wiki page
  • man_made=observatory (546)
  • man_made=wastewater_tank (544) no wiki page
  • man_made=cooling_tower (529)
  • man_made=manhole (524) no wiki page
  • man_made=pillar (510)
  • man_made=windpump (502)
  • man_made=maypole (484) no wiki page
  • man_made=communications_dish (483) no wiki page
  • man_made=frost_fan (468)
  • man_made=culvert (466) no wiki page
  • man_made=buoy (440)
  • man_made=cellar_entrance (438)
  • man_made=environmental_hazard (434) no wiki page
  • man_made=wildlife_crossing (402)
  • man_made=standpipe (399) no wiki page
  • man_made=offshore_platform (393)
  • man_made=birdhouse (389) no wiki page
  • man_made=courtyard (383) no wiki page
  • man_made=heat_exchange_station (381) no wiki page
  • man_made=obelisk (376)
  • man_made=pipeline_marker (376) no wiki page
  • man_made=flare (370)
  • man_made=communications_transponder (358) no wiki page
  • man_made=geoglyph (342)
  • man_made=bore_hole (313) no wiki page
  • man_made=winery (302) no wiki page
  • man_made=conveyor (301) no wiki page

drop payment:dogecoin

Dogecoin has miniscule adoption beyond tipping on social media, payment:dogecoin tag is used 68 times worldwide.

I propose to remove it from preset to reduce clutter on adding payment:* tags.

include wetland tags

It seems that wetland tags are missing from preset

What is surprising - searching for wetland in repository gives some limited results.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.