Issue with `+` in filename about jupyterlab-h5web HOT 4 CLOSED

Fixed by silx-kit/h5web#774 and silx-kit/h5web#781

from jupyterlab-h5web.

Probably need to use quote_plus

from jupyterlab-h5web.

Issue is also when opening h5web with a double click from the file browser.

from jupyterlab-h5web.

After thorough investigation, the escaping happens when the request URL is parsed on the backend. The culprit is tornado's parse_qs_bytes that parses arguments expecting them to be URL-encoded.

>>> parse_qs_bytes('file=stack+.h5&path=/')
{'file': [b'stack .h5'], 'path': [b'/']}
>>> parse_qs_bytes('file=stack%2B.h5&path=%2F')
{'file': [b'stack+.h5'], 'path': [b'/']}

To avoid problems of this type in the future, we should ensure that the filename is encoded every time it roundtrips between the front-end and the back-end.

This means encoding should happen in the following situations:

• When double-clicking on a file in the filebrowser. This is probably handled directly by JupyterLab.
• When passing the filename in argument of the H5Web widget. #46 may be the solution This is probably also handled by JupyterLab as it works without further work in jupyterlab-h5web
• When making GET requests in the H5GroveProvider with filename as arg. This must be fixed in h5web silx-kit/h5web#774.

from jupyterlab-h5web.