Git Product home page Git Product logo

Comments (19)

loichuder avatar loichuder commented on June 12, 2024 2

Thanks for following that up @lrlunin, it indeed sheds some light on the issue.

I will wait for JLab maintainers' answer to my comment to see if JLab has a consistent way of accessing custom drives (that is used for collaborative mode). If not, I will have to patch something together myself.

from jupyterlab-h5web.

loichuder avatar loichuder commented on June 12, 2024 2

Sorry, it has been a while before I got back to this. Next release should include a quick and dirty fix.

from jupyterlab-h5web.

loichuder avatar loichuder commented on June 12, 2024 1

On second thought, that may be completely unrelated 😂

I am wondering how Y.js (the tech powering the sharing of files in collaboration mode) deals with binary files. I understand it can work with plain text such as CSV but that may be another story with HDF5 files.

from jupyterlab-h5web.

Podolyakofs avatar Podolyakofs commented on June 12, 2024 1

Checked on new machine - looks like everything works!

from jupyterlab-h5web.

lrlunin avatar lrlunin commented on June 12, 2024

Can confirm the issue above.

from jupyterlab-h5web.

loichuder avatar loichuder commented on June 12, 2024

Thanks for the report !

The issue may be due to the patching I did to prevent the fetching of the file.

Hopefully, this should no longer be needed since we now only support JLab4 that has the file format null. So, it may be as simple as removing the patching and set the file format to null in HDF5_FILE_TYPE. To be tested 🤷

I will gladly accept a PR or a report on whether this fixes the issue. Otherwise, this will have to wait a bit until I find time to work on it.

from jupyterlab-h5web.

lrlunin avatar lrlunin commented on June 12, 2024

I am wondering how Y.js (the tech powering the sharing of files in collaboration mode) deals with binary files.

I was testing the new RTC version the whole day yesterday and still have the issue that the created .ipynb files are not saved :D (Was problem on my site)

I would expect that people will rather rarely edit HDF5 files in the collaborative mode in way like people edit .ipynb files. Maybe we should request to handle the "plain text" files (like .txt, .scv etc) with Y.js and then just ignore all other files formats which they cannot handle correctly.

from jupyterlab-h5web.

lrlunin avatar lrlunin commented on June 12, 2024

Hello, @loichuder

I guess this issue is realated to this issue: jupyterlab/jupyter-collaboration#183 (comment)

I believe they argue that need to be fixed on the extension site.

from jupyterlab-h5web.

betolink avatar betolink commented on June 12, 2024

I just ran into this issue, is there a known workaround? I'm using JLab 4 and the latest jupyterlab-h5web versions.

from jupyterlab-h5web.

loichuder avatar loichuder commented on June 12, 2024

I just released jupyterlab-h5web 12.0.0 that includes the aforementioned fix.

Since I don't use RTC myself, I was only able to do basic checks and I am not convinced it was the best way of solving the issue.

If anyone can test and report, that would be greatly appreciated. I'll leave this issue open and you are welcome to post further comments if additional problems are encountered.

from jupyterlab-h5web.

Podolyakofs avatar Podolyakofs commented on June 12, 2024

Checked the last version - got same error

File not found: 'RTC:discharges/2024/202402/20240226/M/647M 2024-02-26 13:56:07.nxs'
    tornado.web.HTTPError: HTTP 404: Not Found (File not found!)
[W 2024-02-26 19:28:38.604 ServerApp] 404 GET /h5web/meta/?file=RTC:discharges%2F2024%2F202402%2F20240226%2FM%2F647M+2024-02-26+13:56:07.nxs&path=%2F ([email protected]) 2.36ms referer=http://hdfcon.tkmk:8888/lab/tree/RTC%3Adischarges/2024/202402/20240226/M

Also in 12.0.0 get
image
In previous version (11.1) there is no error
image

from jupyterlab-h5web.

loichuder avatar loichuder commented on June 12, 2024

Thanks for checking @Podolyakofs

I'll have a second look

from jupyterlab-h5web.

loichuder avatar loichuder commented on June 12, 2024

It seems to run fine on my end. I'll try to reproduce the error with the same parameters as you.

@Podolyakofs could you give me:

  1. The list and versions of installed packages in the environment (pip freeze/list)
  2. The way you start and connect to the RTC instance of JupyterLab
  3. The file you are using (or a stripped down version, as long as it shows the error Expected Group)

That would be very helpful for me to debug, thanks.

from jupyterlab-h5web.

loichuder avatar loichuder commented on June 12, 2024

Great to read 😌 !

I'll keep following discussions on the JLab repo in case there is a better way of fixing it

from jupyterlab-h5web.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.