silvxlabs / driptorch Goto Github PK

https://github.com/silvx-io/driptorch/blob/5cd1314a0668bf3f4e1c0bd9815744b8bc2473e2/driptorch/personnel.py#L74

I noticed that there is a write_quicfire function in the IO (https://teamholtz.github.io/DripTorch/api/io.html), but any chance we can also get a read_quicfire function?

FastFuels data are exported in Albers while DripTorch ignition patterns are exported to QUIC-fire in UTM. We need to add an argument for setting the CRS in DT->QF exports.

    # TODO: Cleanup QF export method

https://github.com/silvx-io/driptorch/blob/3d3d8e21a4ab044a062fcdd19a7ac6f7ffcc0f42/driptorch/io.py#L194

https://github.com/silvx-io/driptorch/blob/5cd1314a0668bf3f4e1c0bd9815744b8bc2473e2/driptorch/personnel.py#L18

https://github.com/silvx-io/driptorch/blob/5cd1314a0668bf3f4e1c0bd9815744b8bc2473e2/driptorch/personnel.py#L73

For aerial ignitions (dot ignitions or format 4) the coordinates need to be scaled to the computational domain (they are not in meters; they change according to the resolution)

Users need to combine multiple firing techniques into a single pattern object. This would look something like pattern1.merge(pattern2, time_offset=100).

Get the following traceback when I run import driptorch

Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/opt/homebrew/Caskroom/miniforge/base/envs/test/lib/python3.10/site-packages/driptorch/__init__.py", line 2, in <module>
    from driptorch.unit import BurnUnit
  File "/opt/homebrew/Caskroom/miniforge/base/envs/test/lib/python3.10/site-packages/driptorch/unit.py", line 11, in <module>
    from driptorch.io import Projector, write_geojson, read_geojson_polygon
  File "/opt/homebrew/Caskroom/miniforge/base/envs/test/lib/python3.10/site-packages/driptorch/io.py", line 6, in <module>
    from driptorch.templates import quicfire
ModuleNotFoundError: No module named 'driptorch.templates'

For flank patterns, the crew ignites in one direction and travels back in the opposite direction without new ignitions. It doesn't appear the return trip is reflected in the output times. this is v0.4.0

We need an argument to control the depth between heats for flank firing. We'll also make this available in the strip technique as well.

https://github.com/silvx-io/driptorch/blob/5cd1314a0668bf3f4e1c0bd9815744b8bc2473e2/driptorch/unit.py#L19

i'm encountering several issues when using flank. it's possible i'm using the api wrong.

first, i always get n - 1 igniters in the output pattern. is this expected?

second, setting igniters to 4 gives an exception:

File "/igniter/./app/app.py", line 56, in create pattern = dt.firing.Flank(firing_area, crew).generate_pattern() File "/usr/local/lib/python3.10/site-packages/driptorch/firing/flank.py", line 36, in generate_pattern return self._generate_pattern() File "/usr/local/lib/python3.10/site-packages/driptorch/firing/_base.py", line 54, in _generate_pattern timed_paths = propagator.forward(init_paths, self._ignition_crew) File "/usr/local/lib/python3.10/site-packages/driptorch/pattern.py", line 266, in forward self._init_path_time(self.spacing) File "/usr/local/lib/python3.10/site-packages/driptorch/pattern.py", line 353, in _init_path_time path.start_time = prev_start_time + self._get_offset( File "/usr/local/lib/python3.10/site-packages/driptorch/pattern.py", line 393, in _get_offset cur_igniter.geometry.iloc[0].coords[0]) File "/usr/local/lib/python3.10/site-packages/shapely/coords.py", line 85, in __getitem__ raise IndexError("index out of range")

also, for higher numbers of igniters, the pattern stops before they all reach the boundary:

This firing technique will ignite every cell in the unit. 🔥 🔥 🔥

https://github.com/silvx-io/driptorch/blob/5cd1314a0668bf3f4e1c0bd9815744b8bc2473e2/driptorch/pattern.py#L315

• Write setup.py
• Configure GH action to auto publish on release

it would be nice if the pattern json included the total elapsed time (in seconds) required for the ignition pattern. now, i have to look at the times in each feature and calculate max - min to get elapsed.

https://github.com/silvx-io/driptorch/blob/5cd1314a0668bf3f4e1c0bd9815744b8bc2473e2/driptorch/pattern.py#L149

https://github.com/silvx-io/driptorch/blob/5cd1314a0668bf3f4e1c0bd9815744b8bc2473e2/driptorch/personnel.py#L72

A simple feature that could be added would be to make the blackline function a little bit more versatile.

It could still keep it's default values, but giving the option to specify a range of angles under which you would want the blackline. Another feature which could add to this would be the option of adding / merging multiple blacklines together (say you want a wider blackline in some parts, or a blackline that has a gap in it).

I know you can technically do some of this through using other functions together, but I think in particular the specification of a range of angles would be very helpful.

https://github.com/silvx-io/driptorch/blob/5cd1314a0668bf3f4e1c0bd9815744b8bc2473e2/driptorch/personnel.py#L153